From patchwork Thu Oct 25 09:44:37 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wei Yang X-Patchwork-Id: 10655661 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 3442113B5 for ; Thu, 25 Oct 2018 09:45:48 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 22A642B1DB for ; Thu, 25 Oct 2018 09:45:48 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 16B3B2B2A3; Thu, 25 Oct 2018 09:45:48 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id A7F642B1DB for ; Thu, 25 Oct 2018 09:45:47 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8A8DA6B027D; Thu, 25 Oct 2018 05:45:46 -0400 (EDT) Delivered-To: linux-mm-outgoing@kvack.org Received: by kanga.kvack.org (Postfix, from userid 40) id 82DD46B027E; Thu, 25 Oct 2018 05:45:46 -0400 (EDT) X-Original-To: int-list-linux-mm@kvack.org X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6D59C6B027F; Thu, 25 Oct 2018 05:45:46 -0400 (EDT) X-Original-To: linux-mm@kvack.org X-Delivered-To: linux-mm@kvack.org Received: from mail-pl1-f197.google.com (mail-pl1-f197.google.com [209.85.214.197]) by kanga.kvack.org (Postfix) with ESMTP id 2A7C86B027D for ; Thu, 25 Oct 2018 05:45:46 -0400 (EDT) Received: by mail-pl1-f197.google.com with SMTP id k12-v6so4809418plt.0 for ; Thu, 25 Oct 2018 02:45:46 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:dkim-signature:from:to:cc:subject:date :message-id:in-reply-to:references; bh=KKqarB6+TclYvRz6jTRg9yZmlYdYhBY/UUEFryGvU3A=; b=BMT4gl3qW+bILhT/9wjaa4H4OwjimaQzlkiOUp0G5GlL7GDa5K5bs7JWpJkLW5Hbzl DWEnDyCUMuToZok9LXl+tz/B/xx+jt6N6k/EOsKubw9CPTaKJXD7XWL6Zi6I+6k03KJF 9x/GjZPihiLNLOu6fZ7jJ8OsepiPUyTm3nNX5bOL/uq2vl7S/7k245xvAX1v3H8qmPA6 AOmsQ9hofWwmEqAXIOrzm+wqlgCoxa4/XhyjiAo6cxx5tPyu/nkqK7nZeKfhjnTSy4ZH v9YGxqcw3ulCTJaglNrA56Sv5IXdNECgle7kIv+sjc9zCOP4xt/466OcWTeyKOffuyGK HZog== X-Gm-Message-State: AGRZ1gI7Up7wcybE2BjBT0sWokLypmf7daJ4tgpA8010utT+STpZqjNs 4k5kNSZUo67DjhbHDeg6Ruf40iG/JWbxwozHedkXAAFDoRMfSAl6nCufl7Ps8DyfqEZpONQqbv5 GVEBWPe4vzYWD9tRL9j+rVxG4b+wb+2Kq7SiWSrmMbHHqbwDQDiWkIrjB6yk7w2Iwy/HT+8En9/ sLbG5jk/kfvejgcjh+EHji5HfFe0POyFvJplrnqEAZRGOHXfatmsNPi7yBDyQB/fVyXghg57Zgg NdJ2vlssgIantlBMAtAH+lI5W+a7qJrwFBlcOqDk0traHcAjhdeyUyAVX7JtqPZDID2AQpsAIwK oeBK8Q9ueqSpSSgo4bhZCcObcsW0Bx1OAn92fBT/iesL0WMWukZIiakvVFaDvroLd71S6o0qaYh A X-Received: by 2002:a17:902:9a9:: with SMTP id 38-v6mr808384pln.319.1540460745824; Thu, 25 Oct 2018 02:45:45 -0700 (PDT) X-Received: by 2002:a17:902:9a9:: with SMTP id 38-v6mr808357pln.319.1540460745100; Thu, 25 Oct 2018 02:45:45 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1540460745; cv=none; d=google.com; s=arc-20160816; b=ykd1VZ3fjISkjpxSzxccEPIeOoQ5t/qIIuj8O6OCl8ORTupUxuq+RHaDRqq5AZzBEn PX6Pid0wdxWJuI9NX10k+o7hRVeZMAPZ61stEHRoNHRXLNys8fUybT/7/2Wwc7yQ+jAo TVIspXKA4JMjWslBMNyjdAIuS2FirbXYPiWy4w/285wzANAAn7387XvhwOy9vKRc0WYv zVZRoFEUuW/ORNANAZDlplLs/PsytJr05VJj/lqaP0aba1ZR39von+wJ3T83yujgMFgi bZZXTGHdx/b7hILeR3X3PNumgZSKX8sP0/k1VOkATTiF0bPDKlvt+kqrxDn/2AkXxEFO fIRA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=KKqarB6+TclYvRz6jTRg9yZmlYdYhBY/UUEFryGvU3A=; b=IUZ1XT9bty/VnyyQRqAqkKyeaXpL9UrT5kmaBV3BNXlF9+U7FF2UZ9O7dgapHOH7g0 dr2FkpCz4LFREva4R5Q6h/E217tyf42cCn2SQ0A9Sq/DDkV0IKC2EZX3Kvd5A6s27fwh RtBBAZF6HUfDIYY7XCsTgZ0UHLP+PmcQpwkg/+kPryrJLrZp1QH5u6gwDtlW9rhqFD6C QEGr5AFp3H1pXOFAacv/akU0OORfQxJYIcUv93UjodDDUc9/rThNS0vmUTyuUgdriwcH Rh5ogItGwRfXj/P5qYbLp5c6SU3kr5OoL6MT15C8Ldk4BaWj+4qmm3JDvaT8gvfCpBXH cJoA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=uZ+LuSDo; spf=pass (google.com: domain of richard.weiyang@gmail.com designates 209.85.220.65 as permitted sender) smtp.mailfrom=richard.weiyang@gmail.com; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from mail-sor-f65.google.com (mail-sor-f65.google.com. [209.85.220.65]) by mx.google.com with SMTPS id x8-v6sor7022647pgp.61.2018.10.25.02.45.44 for (Google Transport Security); Thu, 25 Oct 2018 02:45:45 -0700 (PDT) Received-SPF: pass (google.com: domain of richard.weiyang@gmail.com designates 209.85.220.65 as permitted sender) client-ip=209.85.220.65; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=uZ+LuSDo; spf=pass (google.com: domain of richard.weiyang@gmail.com designates 209.85.220.65 as permitted sender) smtp.mailfrom=richard.weiyang@gmail.com; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=KKqarB6+TclYvRz6jTRg9yZmlYdYhBY/UUEFryGvU3A=; b=uZ+LuSDo2zG9o1yS6X7T8nwAMZQJo7Z+peOF89yAaUo0s7d1B0Zy51++owj4SVIQGX 9y9ITRvn3Y5JmsJAyj2R/8rvwc8Z1TTJNXZ9owTDFsihac+mRVTBnJPspeIaLi/VOVZY Zz/UOwj/Siyn2YZ8+vkCDIIcCfd48acsQM6+m1098QUSWgF8I1eoH6XtukMnA05nkP2W FrFJqyBCJsepALTEbxU6Yx7BBRgeyu1Z2hPc3+CpXO9UJtaN5uE9pmNoyk9Cnk+sMcPY GCJncXtV6AQTCPM2r5U7RTLArsvHYTf7vcYPX4uBi9DAYr4chu6/qntJGgm+NWDM6+GJ kAsg== X-Google-Smtp-Source: AJdET5du1bpDmY8VGfq02JoD8qQswtSTTIpM44d3H34UDd5KyucFjCEPgF9u/b/6TwKJNFzjGmfKNw== X-Received: by 2002:a63:3747:: with SMTP id g7-v6mr810424pgn.59.1540460744672; Thu, 25 Oct 2018 02:45:44 -0700 (PDT) Received: from localhost ([185.92.221.13]) by smtp.gmail.com with ESMTPSA id u190-v6sm28861157pgu.3.2018.10.25.02.45.43 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 25 Oct 2018 02:45:44 -0700 (PDT) From: Wei Yang To: cl@linux.com, penberg@kernel.org, rientjes@google.com Cc: akpm@linux-foundation.org, linux-mm@kvack.org, Wei Yang Subject: [PATCH 3/3] mm, slub: make the comment of put_cpu_partial() complete Date: Thu, 25 Oct 2018 17:44:37 +0800 Message-Id: <20181025094437.18951-3-richard.weiyang@gmail.com> X-Mailer: git-send-email 2.15.1 In-Reply-To: <20181025094437.18951-1-richard.weiyang@gmail.com> References: <20181025094437.18951-1-richard.weiyang@gmail.com> X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: X-Virus-Scanned: ClamAV using ClamSMTP There are two cases when put_cpu_partial() is invoked. * __slab_free * get_partial_node This patch just makes it cover these two cases and fix one typo in slub_def.h. Signed-off-by: Wei Yang Acked-by: Christoph Lameter --- include/linux/slub_def.h | 2 +- mm/slub.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/include/linux/slub_def.h b/include/linux/slub_def.h index 3a1a1dbc6f49..201a635be846 100644 --- a/include/linux/slub_def.h +++ b/include/linux/slub_def.h @@ -81,7 +81,7 @@ struct kmem_cache_order_objects { */ struct kmem_cache { struct kmem_cache_cpu __percpu *cpu_slab; - /* Used for retriving partial slabs etc */ + /* Used for retrieving partial slabs etc */ slab_flags_t flags; unsigned long min_partial; unsigned int size; /* The size of an object including meta data */ diff --git a/mm/slub.c b/mm/slub.c index 715372a786e3..3db6ce58e92e 100644 --- a/mm/slub.c +++ b/mm/slub.c @@ -2201,8 +2201,8 @@ static void unfreeze_partials(struct kmem_cache *s, } /* - * Put a page that was just frozen (in __slab_free) into a partial page - * slot if available. + * Put a page that was just frozen (in __slab_free|get_partial_node) into a + * partial page slot if available. * * If we did not find a slot then simply move all the partials to the * per node partial list.