Message ID | 20181107101830.17405-4-mhocko@kernel.org (mailing list archive) |
---|---|
State | New, archived |
Headers | show
Return-Path: <owner-linux-mm@kvack.org> Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id EDA7413A4 for <patchwork-linux-mm@patchwork.kernel.org>; Wed, 7 Nov 2018 10:18:54 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id DCFDF2B1F2 for <patchwork-linux-mm@patchwork.kernel.org>; Wed, 7 Nov 2018 10:18:54 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id D0DD22B22B; Wed, 7 Nov 2018 10:18:54 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.9 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 7C69C2B1F2 for <patchwork-linux-mm@patchwork.kernel.org>; Wed, 7 Nov 2018 10:18:54 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3044A6B04E3; Wed, 7 Nov 2018 05:18:49 -0500 (EST) Delivered-To: linux-mm-outgoing@kvack.org Received: by kanga.kvack.org (Postfix, from userid 40) id 268526B04E5; Wed, 7 Nov 2018 05:18:49 -0500 (EST) X-Original-To: int-list-linux-mm@kvack.org X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F33D76B04E6; Wed, 7 Nov 2018 05:18:48 -0500 (EST) X-Original-To: linux-mm@kvack.org X-Delivered-To: linux-mm@kvack.org Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by kanga.kvack.org (Postfix) with ESMTP id 979E76B04E3 for <linux-mm@kvack.org>; Wed, 7 Nov 2018 05:18:48 -0500 (EST) Received: by mail-wr1-f69.google.com with SMTP id v2-v6so15090593wrn.0 for <linux-mm@kvack.org>; Wed, 07 Nov 2018 02:18:48 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-original-authentication-results:x-gm-message-state:from:to:cc :subject:date:message-id:in-reply-to:references:mime-version :content-transfer-encoding; bh=k4D3ilvRNbEdywbamB4FAtEIm3b4AWw0D1l/xvNW28A=; b=dbNlFXLMTwKfFKubuUmogC//9iJdLK5UFuTt+qhRY8Pkp46g+2s6ZQXinRfkGRjXS5 be+vBY+FpiOatX778uafb2gw/lgNGqUZUF4bT4oSvs2Hn12muFQLPzA5b1ufcRNJyb8o C0WrxWxv6s1+12V6WBqJuHiCXx39xgSaErLwfJiY/XD90dxu33eJcQYpMZc0R9EWtWnn yF2BdsDO0NpQYqyfOQlYGCPGn/bseF2fb5jS39IMv/Mrz2RJkxWOIZrBMocU6wUSLJ1Q eHnrDExDuS1tMaXC5g447F77A8guMMRIhCyJRoX/dRZiKaOrovfiSf5avP90MuymCMTO MWeA== X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of mstsxfx@gmail.com designates 209.85.220.65 as permitted sender) smtp.mailfrom=mstsxfx@gmail.com; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org X-Gm-Message-State: AGRZ1gJ55KRgwf1WzkL7FKlPWA6zAr7/ka+3JmXcdfpAkUcgYkiXO3A4 DUyU28zQ8nL9PXeRSUVdjzis4Ii1wklGr1ONcxKt2dYR62bvDIj8U3nfLUa5qVK5oyg3ZmfYG+e 7YlKninyBo/IXEasWx2LOhUtgBV2iFcsJm4Lru5tWRBytvahMyBzD+XCBEdPOTVvlhwC1/5MdSH UV1vbzXmPfevKuj96HLRxc/CcATMom+PoPnj3vIcGwessfcZDU/JZa80Jgfvdg0K4igeArxT5+O ZDd5OnVZXbph/0WmmS4M4vhF0gzfME4ZKDGNdq1eZWIcr+40o9udAYiYyYcMHDM4jnm4XinmEDU SpB2I+TJsIcWCQeqrbj5/XdNSKf5PRyfP4wfcc7oQ7ZVQ9bDEeeMDMlu3PPG7uVOcAH9eMvwqw= = X-Received: by 2002:adf:c608:: with SMTP id n8-v6mr1314573wrg.174.1541585928178; Wed, 07 Nov 2018 02:18:48 -0800 (PST) X-Received: by 2002:adf:c608:: with SMTP id n8-v6mr1314527wrg.174.1541585927441; Wed, 07 Nov 2018 02:18:47 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1541585927; cv=none; d=google.com; s=arc-20160816; b=WkEYZa+AgDj1xy2bbRoOigJrd7dg33kiYiACVL7NNrbY28oD2ACz1QqIiuf0Xm0IZA Sglkn9CHK83Mo41Ec33WyMBdZkGEGvZnSxqS56Xn4uicQnmCJAJ/SadlFALHSIQhxajU rcOwNGuBQGhiAfcwyK8zv2lVuNCUgz0lp1Q017FjVPp91DzRPIGcRcx8/Z9GL61+3vJE pTNswIUJJ0cmeL3qdHAYV1nRbkT60zLCT00FG5yhyRM4Y/z9t6Odc2r/+Tok1KkfpgII buh/mvwHRotRqv7TPgq9XL1oC950Z5OUe5u9cTsyh9rQCZRfy9IoD81uD/nyySlPfX7E DLcw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from; bh=k4D3ilvRNbEdywbamB4FAtEIm3b4AWw0D1l/xvNW28A=; b=sjHoXlosMMnIrzKtrlqQ7qPFhbQkhxJnAW4Wu/Ca2JE56axC8aI2bZaHwrZ8701gkC BUgfpOrpMv9TtUYPRt2rSUypySeV6LDOv50wO20uOPiYZIadiKzznyY/tOJehtpD42JS ZTEs+j86TJHs9pX+M42s/5xpVyQLq406bsrLgI3ygduFARwohcxnPG0XudDdlVAjKf3Q lKumxYgB+6FIV2k8J9si0sKbCFGDND4zxaWMYRt9l7+qtmxU9Jhn+HK12LRhVN3hdv/D MA5hH3jr5TLD0xjPujB/uL+dxKT+h+HhXwdQyxektCV6TydJ+yrQlOenCvQGseYM2BnJ tezA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of mstsxfx@gmail.com designates 209.85.220.65 as permitted sender) smtp.mailfrom=mstsxfx@gmail.com; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from mail-sor-f65.google.com (mail-sor-f65.google.com. [209.85.220.65]) by mx.google.com with SMTPS id y207-v6sor411667wmd.1.2018.11.07.02.18.47 for <linux-mm@kvack.org> (Google Transport Security); Wed, 07 Nov 2018 02:18:47 -0800 (PST) Received-SPF: pass (google.com: domain of mstsxfx@gmail.com designates 209.85.220.65 as permitted sender) client-ip=209.85.220.65; Authentication-Results: mx.google.com; spf=pass (google.com: domain of mstsxfx@gmail.com designates 209.85.220.65 as permitted sender) smtp.mailfrom=mstsxfx@gmail.com; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org X-Google-Smtp-Source: AJdET5e39Bf8HqnTYRY869Rb3DDpMinUmxIe1N5NVJO5e00HwQZeHZ45MgeP6ywWcDyD1cpln9a53g== X-Received: by 2002:a1c:4b12:: with SMTP id y18-v6mr1436028wma.122.1541585926771; Wed, 07 Nov 2018 02:18:46 -0800 (PST) Received: from tiehlicka.suse.cz (ip-37-188-140-85.eurotel.cz. [37.188.140.85]) by smtp.gmail.com with ESMTPSA id w18-v6sm217527wrn.66.2018.11.07.02.18.45 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 07 Nov 2018 02:18:46 -0800 (PST) From: Michal Hocko <mhocko@kernel.org> To: <linux-mm@kvack.org> Cc: Andrew Morton <akpm@linux-foundation.org>, Oscar Salvador <OSalvador@suse.com>, Baoquan He <bhe@redhat.com>, LKML <linux-kernel@vger.kernel.org>, Michal Hocko <mhocko@suse.com> Subject: [RFC PATCH 3/5] mm, memory_hotplug: drop pointless block alignment checks from __offline_pages Date: Wed, 7 Nov 2018 11:18:28 +0100 Message-Id: <20181107101830.17405-4-mhocko@kernel.org> X-Mailer: git-send-email 2.19.1 In-Reply-To: <20181107101830.17405-1-mhocko@kernel.org> References: <20181107101830.17405-1-mhocko@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: <linux-mm.kvack.org> X-Virus-Scanned: ClamAV using ClamSMTP |
Series |
mm, memory_hotplug: improve memory offlining failures debugging
|
expand
|
diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c index 2b2b3ccbbfb5..a92b1b8f6218 100644 --- a/mm/memory_hotplug.c +++ b/mm/memory_hotplug.c @@ -1554,12 +1554,6 @@ static int __ref __offline_pages(unsigned long start_pfn, struct zone *zone; struct memory_notify arg; - /* at least, alignment against pageblock is necessary */ - if (!IS_ALIGNED(start_pfn, pageblock_nr_pages)) - return -EINVAL; - if (!IS_ALIGNED(end_pfn, pageblock_nr_pages)) - return -EINVAL; - mem_hotplug_begin(); /* This makes hotplug much easier...and readable.