From patchwork Wed Nov 7 10:18:30 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michal Hocko X-Patchwork-Id: 10672123 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 095CE15E9 for ; Wed, 7 Nov 2018 10:19:02 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id EC5A62B2FE for ; Wed, 7 Nov 2018 10:19:01 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id E0BC72B379; Wed, 7 Nov 2018 10:19:01 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.9 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 569F82B2FE for ; Wed, 7 Nov 2018 10:19:01 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0947E6B04E7; Wed, 7 Nov 2018 05:18:52 -0500 (EST) Delivered-To: linux-mm-outgoing@kvack.org Received: by kanga.kvack.org (Postfix, from userid 40) id F35F56B04E9; Wed, 7 Nov 2018 05:18:51 -0500 (EST) X-Original-To: int-list-linux-mm@kvack.org X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D89C66B04EA; Wed, 7 Nov 2018 05:18:51 -0500 (EST) X-Original-To: linux-mm@kvack.org X-Delivered-To: linux-mm@kvack.org Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by kanga.kvack.org (Postfix) with ESMTP id 75CD76B04E7 for ; Wed, 7 Nov 2018 05:18:51 -0500 (EST) Received: by mail-wm1-f69.google.com with SMTP id r200-v6so13880347wmg.1 for ; Wed, 07 Nov 2018 02:18:51 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-original-authentication-results:x-gm-message-state:from:to:cc :subject:date:message-id:in-reply-to:references:mime-version :content-transfer-encoding; bh=V5/bX0/SWP8L0SIclkIvq/xCjg7Ure75U3oy5+jt8kI=; b=fVCD0YmEEbGCnPcJMyvMu0JeVK9Ju9C1wT5TGi5GkFJLQmLKwfHMXmcnvSYfXabLzT B51TxHKD/WYahc6btAdkBMmKP/01ccxjKQDQpR5kVFi/BppKdvwIzj7yOLddG5KF6fpQ yNRTFFzWvCGO8Yg6Er20n29DnFvLA5UZakkcFdO9X1yPUbruLs6JCYV2FAGHOUM66c17 x+NsqXZNhTpnOBzl5PagS5YHxl19XMDOpHX1wrZDWD3JRkfqeCrXscmi6BryckhCQQ5x ON84T//6CBy/VV2uaHUcQJE7wydT2VQsNo+ieDBO3mnBW9JS1Fpcs6aNz3kJ91jJFZ0f p95Q== X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of mstsxfx@gmail.com designates 209.85.220.65 as permitted sender) smtp.mailfrom=mstsxfx@gmail.com; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org X-Gm-Message-State: AGRZ1gKWBs1IBY80hQSBrJRKRyhTRCsCbSkwbTNeMQ2MrkKeMj+7a/RE wapq4WHaYxQn9o6S08HyK/eKSZyyXA4+1b5u+aOKUlkoN9w/AfxLw0xbxKupQFIBsJbjWQTQwkN Hcofm3xFyP/VTVPZRZqoSHscbjqRR5MSffvQ3KQDllD6P1zUbGnR8JejlnXJwjtEChElZA0aN0S CHV7/ch7/tYlQmphWwFWSjoHqTSBzEl3uJWq2RchjQPS6pjXv+NWKxw/U3YtO6CZt42xJvkUElL 3GKCwiP+MpVO0M+K95D+TedNWOhj3zy7De8Bd0KogXPN1CoLph7j0dEkN3QiWf6b3mF3jx/xe9/ cBhoN0H6eVR+THSCHB+pdOCfoxX7vtngz8VhlEg9afTtk3Zh3PW8TZMHVqXow4cOX7W/GpSKnA= = X-Received: by 2002:a1c:8c8c:: with SMTP id o134-v6mr1425671wmd.35.1541585931009; Wed, 07 Nov 2018 02:18:51 -0800 (PST) X-Received: by 2002:a1c:8c8c:: with SMTP id o134-v6mr1425629wmd.35.1541585930096; Wed, 07 Nov 2018 02:18:50 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1541585930; cv=none; d=google.com; s=arc-20160816; b=YfKXNQu6ituo1J2FckM5ZkJPGxm95/5jwpwhJWwODC1AjbfnAMEa8Uvu+GLZnDBYYm gaRvY7Bi936P9ppWrOeNYQo6CnNtc2wxnS8KKng/vAOjqttXpEKn1mqgtLdlIQ5ghE6X D5zOdR8DicYaaBgSo6Vke5SrhXj6aco74J9tRRCmVbHQLPBpgJEWSHdA28ZDoHTIv8y9 Q4XwpNapGn9eJ5BDej7sO7GvhyPLwwWCkVi3dvHoog3rzHrQoDhGQcub70iitf4sKcGw L3RnUSrD3ljlXLUBnEFaEre8oYk54FhI+ksqBinm/4bIPd0vDj640HW60ynvBaNsxa7+ CuTw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from; bh=V5/bX0/SWP8L0SIclkIvq/xCjg7Ure75U3oy5+jt8kI=; b=XOVqm5qq+IIfRXP+pyla3i8v062BQlIgBr6a8UufcuKPhTWPzZW9mvljuJ8ueJsNGw LSPh18IlJLeoS+Do3nQnKFJ+SsEfBr7HM6fX8R9FMtziKDhvkwVSxGYHgs9AHJ46bJLk uviHJhNCSoOoSoyE3XnNN84y+oI28bMRndfCHuRL9PWIcuRIVsZuHKOTlPkesF9qrXix RkZrDND+3Yda0XhkG7ROZAX0tKCg+nIfs31kWXf5jkCqLmAynsElV5D4NUNL3+VKfsKz 1Yqkj+sbrS9yNppvXRgYI9ZNExAhshvm1W5YkrEL59Bd9UBPtqCC0kTpLBxf82OGItYK iVlA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of mstsxfx@gmail.com designates 209.85.220.65 as permitted sender) smtp.mailfrom=mstsxfx@gmail.com; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from mail-sor-f65.google.com (mail-sor-f65.google.com. [209.85.220.65]) by mx.google.com with SMTPS id e13-v6sor163387wrj.23.2018.11.07.02.18.49 for (Google Transport Security); Wed, 07 Nov 2018 02:18:50 -0800 (PST) Received-SPF: pass (google.com: domain of mstsxfx@gmail.com designates 209.85.220.65 as permitted sender) client-ip=209.85.220.65; Authentication-Results: mx.google.com; spf=pass (google.com: domain of mstsxfx@gmail.com designates 209.85.220.65 as permitted sender) smtp.mailfrom=mstsxfx@gmail.com; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org X-Google-Smtp-Source: AJdET5eHo2JX1vYp8BkfX/qztqCKji8admMiIOvP+AoZ2YzWgs+cVV3KFo5eEzErRWcJHfx1pjbacg== X-Received: by 2002:a5d:660c:: with SMTP id n12-v6mr1393687wru.19.1541585929283; Wed, 07 Nov 2018 02:18:49 -0800 (PST) Received: from tiehlicka.suse.cz (ip-37-188-140-85.eurotel.cz. [37.188.140.85]) by smtp.gmail.com with ESMTPSA id w18-v6sm217527wrn.66.2018.11.07.02.18.48 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 07 Nov 2018 02:18:48 -0800 (PST) From: Michal Hocko To: Cc: Andrew Morton , Oscar Salvador , Baoquan He , LKML , Michal Hocko Subject: [RFC PATCH 5/5] mm, memory_hotplug: be more verbose for memory offline failures Date: Wed, 7 Nov 2018 11:18:30 +0100 Message-Id: <20181107101830.17405-6-mhocko@kernel.org> X-Mailer: git-send-email 2.19.1 In-Reply-To: <20181107101830.17405-1-mhocko@kernel.org> References: <20181107101830.17405-1-mhocko@kernel.org> MIME-Version: 1.0 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: X-Virus-Scanned: ClamAV using ClamSMTP From: Michal Hocko There is only very limited information printed when the memory offlining fails: [ 1984.506184] rac1 kernel: memory offlining [mem 0x82600000000-0x8267fffffff] failed due to signal backoff This tells us that the failure is triggered by the userspace intervention but it doesn't tell us much more about the underlying reason. It might be that the page migration failes repeatedly and the userspace timeout expires and send a signal or it might be some of the earlier steps (isolation, memory notifier) takes too long. If the migration failes then it would be really helpful to see which page that and its state. The same applies to the isolation phase. If we fail to isolate a page from the allocator then knowing the state of the page would be helpful as well. Dump the page state that fails to get isolated or migrated. This will tell us more about the failure and what to focus on during debugging. Signed-off-by: Michal Hocko --- mm/memory_hotplug.c | 12 ++++++++---- mm/page_alloc.c | 1 + 2 files changed, 9 insertions(+), 4 deletions(-) diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c index 1badac89c58e..bf214beccda3 100644 --- a/mm/memory_hotplug.c +++ b/mm/memory_hotplug.c @@ -1388,10 +1388,8 @@ do_migrate_range(unsigned long start_pfn, unsigned long end_pfn) page_is_file_cache(page)); } else { -#ifdef CONFIG_DEBUG_VM - pr_alert("failed to isolate pfn %lx\n", pfn); + pr_warn("failed to isolate pfn %lx\n", pfn); dump_page(page, "isolation failed"); -#endif put_page(page); /* Because we don't have big zone->lock. we should check this again here. */ @@ -1411,8 +1409,14 @@ do_migrate_range(unsigned long start_pfn, unsigned long end_pfn) /* Allocate a new page from the nearest neighbor node */ ret = migrate_pages(&source, new_node_page, NULL, 0, MIGRATE_SYNC, MR_MEMORY_HOTPLUG); - if (ret) + if (ret) { + list_for_each_entry(page, &source, lru) { + pr_warn("migrating pfn %lx failed ", + page_to_pfn(page), ret); + dump_page(page, NULL); + } putback_movable_pages(&source); + } } out: return ret; diff --git a/mm/page_alloc.c b/mm/page_alloc.c index a919ba5cb3c8..23267767bf98 100644 --- a/mm/page_alloc.c +++ b/mm/page_alloc.c @@ -7845,6 +7845,7 @@ bool has_unmovable_pages(struct zone *zone, struct page *page, int count, return false; unmovable: WARN_ON_ONCE(zone_idx(zone) == ZONE_MOVABLE); + dump_page(pfn_to_page(pfn+iter), "has_unmovable_pages"); return true; }