From patchwork Wed Nov 14 21:16:59 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Hildenbrand X-Patchwork-Id: 10683095 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id A048414E2 for ; Wed, 14 Nov 2018 21:17:29 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 938A52B6B5 for ; Wed, 14 Nov 2018 21:17:29 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 879732BD32; Wed, 14 Nov 2018 21:17:29 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.9 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 12A2E2B6B5 for ; Wed, 14 Nov 2018 21:17:29 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 03CB16B0005; Wed, 14 Nov 2018 16:17:26 -0500 (EST) Delivered-To: linux-mm-outgoing@kvack.org Received: by kanga.kvack.org (Postfix, from userid 40) id EDB586B0006; Wed, 14 Nov 2018 16:17:25 -0500 (EST) X-Original-To: int-list-linux-mm@kvack.org X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DCABE6B0008; Wed, 14 Nov 2018 16:17:25 -0500 (EST) X-Original-To: linux-mm@kvack.org X-Delivered-To: linux-mm@kvack.org Received: from mail-qk1-f197.google.com (mail-qk1-f197.google.com [209.85.222.197]) by kanga.kvack.org (Postfix) with ESMTP id AB0F16B0005 for ; Wed, 14 Nov 2018 16:17:25 -0500 (EST) Received: by mail-qk1-f197.google.com with SMTP id h68so40836021qke.3 for ; Wed, 14 Nov 2018 13:17:25 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-original-authentication-results:x-gm-message-state:from:to:cc :subject:date:message-id:in-reply-to:references; bh=Oq7Mm7RstKCl5jwQdxJ6ybQMpWdJOGauvDFhhJ6+35E=; b=b0PuZVrZAvShnB/TrUGp/tO/3+nlw3bYksjseKWsuHDVB8RfDpicQDNq2QcGgTNTkQ BhhriQi1j5ee8k9arVaYtvT+51uJ4XA8DCdscKbAhwkzcOhmKtco/mkYV0DCxP1edlq4 5WuvjPl1sBC+EwXG4lu1dpGS2WAvoLf/oozfY2vETak1IpN5VDyH5kzyd2RK1TWITcU4 LwWA2lJAy4O9NgCobUiA1YwlU67ShGPsD/mwjim5l/qh6kCY9gCp28UPlDnbuDvLsWr0 Vp/rNEXw52W41LqJnYKVfwDVDPssw13iFZu0AklSR1wJ+WOFUVG3Z5+zatOSg4eT9at9 SoBg== X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of david@redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com X-Gm-Message-State: AGRZ1gL4jP5M3TekeXHbv4q2qa9QxKALI3fVCMGiFvluAgENsQWhUrpR taSupguSTY3Sgkk7E4NnSwyHjCqPE1FAqpR98cRDUPvRizYzfSAPWIx99QSmXLz8U2CF8/biFzf 6Kx2oc9gSdpJJGBHE330ToPoTjHY2YyaGYeBaw3wkGLlIXrCDvrf4DtGNGCDRN3CrFQ== X-Received: by 2002:a0c:d40f:: with SMTP id t15mr3589124qvh.117.1542230245413; Wed, 14 Nov 2018 13:17:25 -0800 (PST) X-Google-Smtp-Source: AJdET5fmCBAPTO8d8GYMnXiSLT+55l2ZPEOmZ/WUwpYDLWiv/StJQJMgd4pszY3p9QCZGKDbstXF X-Received: by 2002:a0c:d40f:: with SMTP id t15mr3589097qvh.117.1542230244830; Wed, 14 Nov 2018 13:17:24 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1542230244; cv=none; d=google.com; s=arc-20160816; b=GkkcCoy8jJBBXugINk3vEtIYAKm6/efcJSpAJ/L6mp2RzukuYt1d8acT7gHTzMSS+Q OiHlkTf7PkxcQ+XAvAOxREsnwqoXRvD8DvSR3YARp3ujPs4Dwf0Ir/YItA7npwRfkORo tTS6CojdxIO3/0yHvREdn3f+qjM7DwU6xyfHWcLpc0jMWkbMhPP2aNTqzjvW1c7ziGJe 2Tw/EYuTTThmHMUACI95CuUX16JC4lJ/g4xMBqKFJHZUB9EzlqSm3cCBUwylRprj7moA /xD6MBGgVv8aHAXmfcBJUw1+jbLK5fBhNXXO6osz6yVrW1l2YbQx8crc0XieRakLPL0g n6tg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=references:in-reply-to:message-id:date:subject:cc:to:from; bh=Oq7Mm7RstKCl5jwQdxJ6ybQMpWdJOGauvDFhhJ6+35E=; b=JZ49T8DqGMxHGmfJWbHdV479+cnpQ7Of75cxWF1zNRFgdkQ751yiW7jr9WU6nKnw43 rE7av5re3tlmTfDt36x8SMD5ACW762MYNhbHKOgAZqqsdbNO0qnHPAsOnRKsT2k8ryzI kC4nqklmSgf+VsayktgAEQOj5Aww7x9+RJYx5REJDobpR7FE5JTBgoxZrq8LHkqodtio wvalN/YvAeHrl2jZntVp/vrmfapMw33cIrcahGGNqN2pcmM6J8URxFtoicBMCb2W4vxM wmxDtSwE3+ooiYn7xgnftCP//UKch4CNwujhBToecgqfEI1FJae04aI2LWBpygOVmj+H 6WuQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of david@redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from mx1.redhat.com (mx1.redhat.com. [209.132.183.28]) by mx.google.com with ESMTPS id v11si1033342qvj.128.2018.11.14.13.17.24 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 14 Nov 2018 13:17:24 -0800 (PST) Received-SPF: pass (google.com: domain of david@redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; Authentication-Results: mx.google.com; spf=pass (google.com: domain of david@redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id AA7332D814; Wed, 14 Nov 2018 21:17:23 +0000 (UTC) Received: from t460s.redhat.com (ovpn-116-99.ams2.redhat.com [10.36.116.99]) by smtp.corp.redhat.com (Postfix) with ESMTP id 578C761487; Wed, 14 Nov 2018 21:17:21 +0000 (UTC) From: David Hildenbrand To: linux-mm@kvack.org Cc: linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, devel@linuxdriverproject.org, linux-fsdevel@vger.kernel.org, linux-pm@vger.kernel.org, xen-devel@lists.xenproject.org, David Hildenbrand , Andrew Morton , Matthew Wilcox , Michal Hocko , "Michael S. Tsirkin" Subject: [PATCH RFC 1/6] mm: balloon: update comment about isolation/migration/compaction Date: Wed, 14 Nov 2018 22:16:59 +0100 Message-Id: <20181114211704.6381-2-david@redhat.com> In-Reply-To: <20181114211704.6381-1-david@redhat.com> References: <20181114211704.6381-1-david@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.30]); Wed, 14 Nov 2018 21:17:23 +0000 (UTC) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: X-Virus-Scanned: ClamAV using ClamSMTP Commit b1123ea6d3b3 ("mm: balloon: use general non-lru movable page feature") reworked balloon handling to make use of the general non-lru movable page feature. The big comment block in balloon_compaction.h contains quite some outdated information. Let's fix this. Cc: Andrew Morton Cc: Matthew Wilcox Cc: Michal Hocko Cc: "Michael S. Tsirkin" Signed-off-by: David Hildenbrand --- include/linux/balloon_compaction.h | 26 +++++++++----------------- 1 file changed, 9 insertions(+), 17 deletions(-) diff --git a/include/linux/balloon_compaction.h b/include/linux/balloon_compaction.h index 53051f3d8f25..cbe50da5a59d 100644 --- a/include/linux/balloon_compaction.h +++ b/include/linux/balloon_compaction.h @@ -4,15 +4,18 @@ * * Common interface definitions for making balloon pages movable by compaction. * - * Despite being perfectly possible to perform ballooned pages migration, they - * make a special corner case to compaction scans because balloon pages are not - * enlisted at any LRU list like the other pages we do compact / migrate. + * Balloon page migration makes use of the general non-lru movable page + * feature. + * + * page->private is used to reference the responsible balloon device. + * page->mapping is used in context of non-lru page migration to reference + * the address space operations for page isolation/migration/compaction. * * As the page isolation scanning step a compaction thread does is a lockless * procedure (from a page standpoint), it might bring some racy situations while * performing balloon page compaction. In order to sort out these racy scenarios * and safely perform balloon's page compaction and migration we must, always, - * ensure following these three simple rules: + * ensure following these simple rules: * * i. when updating a balloon's page ->mapping element, strictly do it under * the following lock order, independently of the far superior @@ -21,19 +24,8 @@ * +--spin_lock_irq(&b_dev_info->pages_lock); * ... page->mapping updates here ... * - * ii. before isolating or dequeueing a balloon page from the balloon device - * pages list, the page reference counter must be raised by one and the - * extra refcount must be dropped when the page is enqueued back into - * the balloon device page list, thus a balloon page keeps its reference - * counter raised only while it is under our special handling; - * - * iii. after the lockless scan step have selected a potential balloon page for - * isolation, re-test the PageBalloon mark and the PagePrivate flag - * under the proper page lock, to ensure isolating a valid balloon page - * (not yet isolated, nor under release procedure) - * - * iv. isolation or dequeueing procedure must clear PagePrivate flag under - * page lock together with removing page from balloon device page list. + * ii. isolation or dequeueing procedure must remove the page from balloon + * device page list under b_dev_info->pages_lock. * * The functions provided by this interface are placed to help on coping with * the aforementioned balloon page corner case, as well as to ensure the simple