From patchwork Thu Nov 22 16:51:05 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Daniel Vetter X-Patchwork-Id: 10694503 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 61DCE15A7 for ; Thu, 22 Nov 2018 16:51:21 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 509032CB8C for ; Thu, 22 Nov 2018 16:51:21 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 4E7942CD5D; Thu, 22 Nov 2018 16:51:21 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id C70892CB8C for ; Thu, 22 Nov 2018 16:51:20 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E51596B2C3A; Thu, 22 Nov 2018 11:51:17 -0500 (EST) Delivered-To: linux-mm-outgoing@kvack.org Received: by kanga.kvack.org (Postfix, from userid 40) id D85BE6B2C3B; Thu, 22 Nov 2018 11:51:17 -0500 (EST) X-Original-To: int-list-linux-mm@kvack.org X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C7C156B2C3C; Thu, 22 Nov 2018 11:51:17 -0500 (EST) X-Original-To: linux-mm@kvack.org X-Delivered-To: linux-mm@kvack.org Received: from mail-ed1-f71.google.com (mail-ed1-f71.google.com [209.85.208.71]) by kanga.kvack.org (Postfix) with ESMTP id 6288F6B2C3A for ; Thu, 22 Nov 2018 11:51:17 -0500 (EST) Received: by mail-ed1-f71.google.com with SMTP id o21so1369328edq.4 for ; Thu, 22 Nov 2018 08:51:17 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:dkim-signature:from:to:cc:subject:date :message-id:in-reply-to:references:mime-version :content-transfer-encoding; bh=IgwJtKz/bAk5V2diWi6f2OFLQxM1W0dMUc8sKowBqdg=; b=alEm0j23Q1TYP/WL4bnuC5bu3AoSSesX4P7PdhvFHYCY44R7iBqn+Lxh1vY0oIPshE cDKH5sjlE1hFUk8/LT8xyu091oNeziE2EPqGejDwBIu/Q3o1RIKwntB0zqP8kk9hDSw5 IZF8VeVWAWdQcVfrz1bozYjPa85Z17jtEKB00VWZ1f2x4uS5Y6TSWbS03hW31wxaTpuo yz9dZod2pEMCWujf/DT0PEcyWqnIrXHMTITe1weONjBidXNyLtb9k83KRMnAHqnivV6l Dv3Q9LWjJDcdLH4NEyVLmUKccD8syFRCtKJRtMgnJyvZ4CqcF1EmTGH65a2DaHXIm/ME Qb+w== X-Gm-Message-State: AGRZ1gJSkn9hK9rJqxM3TRZj0l3g9WL3m+PvltuDDF9InXxjkX/RV1GJ 6ELRmhwwDTd94K3KND40FAs+03PDF0EC4GY+goLDaxNWZY2FiPqje3oc/bplTSlLFSgk3Z84UUl KTnRi1IMQFvZQd2d8t0v8jXGPNJIu9oWm0MZ6Nr/7jXbO2MI7/Co7ZD7iB5OOC8H8EocUR+fsVe fJJXqkvNv5zgq+OBtnZbmrDX0lyhczVn3rNNHo7475QqOU65HrwUOg8ysJ737xWUAnDFIk6Jlht ysxZyYpc9L0cWJRznaubtqpig2ECZySsmLBbsc+DKP99f0WVKVA8580Ve2gwt0rXQnMZc5RTWiB f1ymCPScLDNUGpJ9ICNgdwOmX4Q6MQyi7JpPBMY1LJJC82WRxE5eobbefZrDJU6DFGPvexbg80/ P X-Received: by 2002:a17:906:9613:: with SMTP id s19-v6mr8580746ejx.109.1542905476878; Thu, 22 Nov 2018 08:51:16 -0800 (PST) X-Received: by 2002:a17:906:9613:: with SMTP id s19-v6mr8580706ejx.109.1542905475857; Thu, 22 Nov 2018 08:51:15 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1542905475; cv=none; d=google.com; s=arc-20160816; b=Qq0NxLddZ0WYzuu7Eow2Frdg5Qa3DjLyTk/mwtlXRnGXhFQl6FHhlztcXsY1HAo27Q BzqyCW2X/5hw6IxVK3d0z+mcFuDh9wXUYZR6KRzdBPe9QR+BdKfheQjpF20SfwTtGxrF Tg7F0qyybu+vBt7H8s1oZkRa719uDQalOOTpN4qoSkeP7HoG8/1Yhcx/W6XR850212Z3 x3iV8abIr1oaSy1xCv9ABCOFxw8tSMGZd+fA86wH0SbpJ2b35b9GlElvTrHOm0KeotCd FbZxQNuwkuoTPMQxxqKTfOlXHsiMOy2G+I0G6406EIDUoWsXfd/wLUSQR3d1fcZsv7h8 2OQQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=IgwJtKz/bAk5V2diWi6f2OFLQxM1W0dMUc8sKowBqdg=; b=dDo3bY/BJMXNM9jKofMph4HPBPUFZyeGxErz6CAYbLu0zPsoahiTxznmf+v6xkqvWw G42kwFwdabShNSJxsGZKC4+4EZLeiCsN8Ihdl6nvdQLkyiqm5s5QerMPnzwckLzp+0ma NbI+Eqp0/QzlBYQGiZp1wRxK1/QbWJ9GEq3frdeCQaI6s1SNnAhPpv5Luwvo7BtGsm48 y0hLdMly9tGvALStHGeR+fb3zfmEvtZzFRFdME45WcnrpVe5XlSS4HTRIQotrhYkEonR cwwydtow2OJdCBIiChpwey676PqtqWLNFS4c5ti73IH5BCHVGJkGFQ5E0ipk3/g0WOWN 8Hcw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@ffwll.ch header.s=google header.b=Q4vTJ8Gd; spf=neutral (google.com: 209.85.220.65 is neither permitted nor denied by best guess record for domain of daniel.vetter@ffwll.ch) smtp.mailfrom=daniel.vetter@ffwll.ch Received: from mail-sor-f65.google.com (mail-sor-f65.google.com. [209.85.220.65]) by mx.google.com with SMTPS id z6-v6sor5056633ejq.44.2018.11.22.08.51.15 for (Google Transport Security); Thu, 22 Nov 2018 08:51:15 -0800 (PST) Received-SPF: neutral (google.com: 209.85.220.65 is neither permitted nor denied by best guess record for domain of daniel.vetter@ffwll.ch) client-ip=209.85.220.65; Authentication-Results: mx.google.com; dkim=pass header.i=@ffwll.ch header.s=google header.b=Q4vTJ8Gd; spf=neutral (google.com: 209.85.220.65 is neither permitted nor denied by best guess record for domain of daniel.vetter@ffwll.ch) smtp.mailfrom=daniel.vetter@ffwll.ch DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=IgwJtKz/bAk5V2diWi6f2OFLQxM1W0dMUc8sKowBqdg=; b=Q4vTJ8GdD4KzHoedmPOhf6u2vnzIm7VaUt5yUjAKQ6T0soQqIl+0l/0ncEcEtIvjem z05dSmCFY7Hcm/qUPGHlGjuR6FRGsyE5NkQa8lDut75Gqo5six8q3eKJyRc8XKeO13Zx +DMpwbTdLPRC1Fr/h3BezrEU62/W5kyvDGAaI= X-Google-Smtp-Source: AJdET5f7D95UNLjpN3z6CjQVNTRkjvktjeA+ZinA1S4SxGyQ/8odF3x2QRcRsfY9v4Pi6Pu0SMQitA== X-Received: by 2002:a17:906:3b11:: with SMTP id g17-v6mr8689028ejf.210.1542905475467; Thu, 22 Nov 2018 08:51:15 -0800 (PST) Received: from phenom.ffwll.local ([2a02:168:569e:0:3106:d637:d723:e855]) by smtp.gmail.com with ESMTPSA id s12sm12914780edb.43.2018.11.22.08.51.14 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 22 Nov 2018 08:51:14 -0800 (PST) From: Daniel Vetter To: LKML Cc: Linux MM , Intel Graphics Development , DRI Development , Daniel Vetter , Andrew Morton , Michal Hocko , David Rientjes , =?utf-8?q?Christian_K=C3=B6nig?= , =?utf-8?b?SsOp?= =?utf-8?b?csO0bWUgR2xpc3Nl?= , Daniel Vetter Subject: [PATCH 2/3] mm, notifier: Catch sleeping/blocking for !blockable Date: Thu, 22 Nov 2018 17:51:05 +0100 Message-Id: <20181122165106.18238-3-daniel.vetter@ffwll.ch> X-Mailer: git-send-email 2.19.1 In-Reply-To: <20181122165106.18238-1-daniel.vetter@ffwll.ch> References: <20181122165106.18238-1-daniel.vetter@ffwll.ch> MIME-Version: 1.0 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: X-Virus-Scanned: ClamAV using ClamSMTP We need to make sure implementations don't cheat and don't have a possible schedule/blocking point deeply burried where review can't catch it. I'm not sure whether this is the best way to make sure all the might_sleep() callsites trigger, and it's a bit ugly in the code flow. But it gets the job done. Cc: Andrew Morton Cc: Michal Hocko Cc: David Rientjes Cc: "Christian König" Cc: Daniel Vetter Cc: "Jérôme Glisse" Cc: linux-mm@kvack.org Signed-off-by: Daniel Vetter --- mm/mmu_notifier.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/mm/mmu_notifier.c b/mm/mmu_notifier.c index 59e102589a25..4d282cfb296e 100644 --- a/mm/mmu_notifier.c +++ b/mm/mmu_notifier.c @@ -185,7 +185,13 @@ int __mmu_notifier_invalidate_range_start(struct mm_struct *mm, id = srcu_read_lock(&srcu); hlist_for_each_entry_rcu(mn, &mm->mmu_notifier_mm->list, hlist) { if (mn->ops->invalidate_range_start) { - int _ret = mn->ops->invalidate_range_start(mn, mm, start, end, blockable); + int _ret; + + if (IS_ENABLED(CONFIG_DEBUG_ATOMIC_SLEEP) && !blockable) + preempt_disable(); + _ret = mn->ops->invalidate_range_start(mn, mm, start, end, blockable); + if (IS_ENABLED(CONFIG_DEBUG_ATOMIC_SLEEP) && !blockable) + preempt_enable(); if (_ret) { pr_info("%pS callback failed with %d in %sblockable context.\n", mn->ops->invalidate_range_start, _ret,