From patchwork Tue Nov 27 08:36:03 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Heiko Carstens X-Patchwork-Id: 10699853 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 69FE714BD for ; Tue, 27 Nov 2018 08:36:15 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 5A98228F68 for ; Tue, 27 Nov 2018 08:36:15 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 4E8152A7CD; Tue, 27 Nov 2018 08:36:15 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.9 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id D75CD28F68 for ; Tue, 27 Nov 2018 08:36:14 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8624F6B46DE; Tue, 27 Nov 2018 03:36:13 -0500 (EST) Delivered-To: linux-mm-outgoing@kvack.org Received: by kanga.kvack.org (Postfix, from userid 40) id 8105F6B46DF; Tue, 27 Nov 2018 03:36:13 -0500 (EST) X-Original-To: int-list-linux-mm@kvack.org X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 725F56B46E0; Tue, 27 Nov 2018 03:36:13 -0500 (EST) X-Original-To: linux-mm@kvack.org X-Delivered-To: linux-mm@kvack.org Received: from mail-ed1-f69.google.com (mail-ed1-f69.google.com [209.85.208.69]) by kanga.kvack.org (Postfix) with ESMTP id 19B2A6B46DE for ; Tue, 27 Nov 2018 03:36:13 -0500 (EST) Received: by mail-ed1-f69.google.com with SMTP id x15so10496014edd.2 for ; Tue, 27 Nov 2018 00:36:13 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-original-authentication-results:x-gm-message-state:from:to:cc :subject:date:message-id:content-transfer-encoding:mime-version; bh=x7TPoHtTSfYCNdXRsSmuFvu8nD7dqqQiFIVBGnOHk9A=; b=pxUkQRL2aC1ODayjjHE1QyGIYj7F4yq51kAabNldAKn1ZcotpbWIjLnxzMalFr0A5z UZI0cz2BjywbX0JpAxFwKgtuEccoat/bL0DjBb4t2EEvbvhzoLnFay6/YehTyxQ5UC/F nDG9nnUgmizMO/J6lrCu0Bv4o0ZBVuoABx1q0Wlgof3plKqf5cNxAGG3t/M2HJuzujEV NIPy5H2knNqnGTUJfckvbwfX5YqthoXxRVbcoIdMR+fcSb+iKhX1qBnfbBdtNbYAbFje GyS2VBe5kpZm8E4qFOmio5ttPM7/wt4P9NDB83DuWCqtfps3+VAhSVlVaEDOBoTdVVwy fdZQ== X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of heiko.carstens@de.ibm.com designates 148.163.158.5 as permitted sender) smtp.mailfrom=heiko.carstens@de.ibm.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=ibm.com X-Gm-Message-State: AA+aEWYBdTcaaQM8RR6ttdBZXHudCAOwQYrDpriCkyNaXReQGIlFhAUA dc8C7HR7hAQjRup4UXTGjXDDq2wZdeC7N3mYJUm6S0d+QhEISOgT+1JCHcZcL187RAtby98T0Sc NT27MOpR5brOwb2l1s+aVT63lagNtaBqZxkwI2/evnUTPcoNTTWSamAGiHle57pGuSQ== X-Received: by 2002:aa7:d749:: with SMTP id a9mr25237700eds.223.1543307772581; Tue, 27 Nov 2018 00:36:12 -0800 (PST) X-Google-Smtp-Source: AFSGD/Xq2wFsFCywKWSCCnFkXLH46INOH6PGyKKRIZ2WnCRfbiy85OqtA350FNXtl0a9bGUTN0Z4 X-Received: by 2002:aa7:d749:: with SMTP id a9mr25237641eds.223.1543307771389; Tue, 27 Nov 2018 00:36:11 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1543307771; cv=none; d=google.com; s=arc-20160816; b=RXh92OyXPmYWYRuXGmTFeRz7RflLjn82IFsWqiQ/dP97J5NmMRUjN0TdYZ201TGARf 4qFQSY6kaLfsGuVkIEScJOD+efDO6k0BaXVLMNDCURRTdRcxvBY27EZ4rocUERiPB4RM O5SFCJIekFwtkmzjX2oXcVSRopBwkh2Ej8kgwuBE+IVZlBmG0HS6dShlbLyBdX5SB/HS MC/IeOmmWX/zgm+tRYEtvT+T3q57Is6KCyDOM9GVImap4zo4hzq/n6R05DBsCjym7AAG wOx8PVAjdRquGXzIWj6j64OQ0g0TFcIPXX+bUyUrcu6J7/MQAOeqp24+noHlx//gWYoq tdcg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:content-transfer-encoding:message-id:date:subject:cc :to:from; bh=x7TPoHtTSfYCNdXRsSmuFvu8nD7dqqQiFIVBGnOHk9A=; b=zi3+5v5qslivtWkXQlncd7Z7994bY7ajWGycPZOKRkBNv1A4ZhxZb1x8BKqeKr8P3C ZC3LMx4S9+9dPvntzCj33fH4nwmKuQN6I9SaA/hV4evU4+UKC3lIkbsku9TO1J1auv1L r2eC9sk8aUTGB+K1Ji538k3fToj2XvMziA+isXM/05y3aKwy0ATqSf7yuNvhAzFUczxn dxHTojatWA6nzAUmyTNuke5k/at86gwVg5rNjKr+WKniDVE8sez0IAgkx/kmBCS1DUVS Dp9RN9uPUtg3pZrtqA/cWGEDotDrqtaSfKDeZfaGwFCrylsaphGbx+NN+OWvNNy8h/sH ooyQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of heiko.carstens@de.ibm.com designates 148.163.158.5 as permitted sender) smtp.mailfrom=heiko.carstens@de.ibm.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=ibm.com Received: from mx0a-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com. [148.163.158.5]) by mx.google.com with ESMTPS id f18si1465137edq.256.2018.11.27.00.36.10 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 27 Nov 2018 00:36:11 -0800 (PST) Received-SPF: pass (google.com: domain of heiko.carstens@de.ibm.com designates 148.163.158.5 as permitted sender) client-ip=148.163.158.5; Authentication-Results: mx.google.com; spf=pass (google.com: domain of heiko.carstens@de.ibm.com designates 148.163.158.5 as permitted sender) smtp.mailfrom=heiko.carstens@de.ibm.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=ibm.com Received: from pps.filterd (m0098421.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.22/8.16.0.22) with SMTP id wAR8YSCJ107317 for ; Tue, 27 Nov 2018 03:36:09 -0500 Received: from e06smtp07.uk.ibm.com (e06smtp07.uk.ibm.com [195.75.94.103]) by mx0a-001b2d01.pphosted.com with ESMTP id 2p117r3tfk-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Tue, 27 Nov 2018 03:36:09 -0500 Received: from localhost by e06smtp07.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 27 Nov 2018 08:36:07 -0000 Received: from b06cxnps4074.portsmouth.uk.ibm.com (9.149.109.196) by e06smtp07.uk.ibm.com (192.168.101.137) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; (version=TLSv1/SSLv3 cipher=AES256-GCM-SHA384 bits=256/256) Tue, 27 Nov 2018 08:36:06 -0000 Received: from b06wcsmtp001.portsmouth.uk.ibm.com (b06wcsmtp001.portsmouth.uk.ibm.com [9.149.105.160]) by b06cxnps4074.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id wAR8a5Ua20512848 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Tue, 27 Nov 2018 08:36:05 GMT Received: from b06wcsmtp001.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 41B37A4054; Tue, 27 Nov 2018 08:36:05 +0000 (GMT) Received: from b06wcsmtp001.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id F1BF5A405B; Tue, 27 Nov 2018 08:36:04 +0000 (GMT) Received: from tuxmaker.boeblingen.de.ibm.com (unknown [9.152.85.9]) by b06wcsmtp001.portsmouth.uk.ibm.com (Postfix) with ESMTPS; Tue, 27 Nov 2018 08:36:04 +0000 (GMT) From: Heiko Carstens To: Andrew Morton Cc: linux-kernel@vger.kernel.org, linux-s390@vger.kernel.org, linux-mm@kvack.org, Heiko Carstens , "Kirill A . Shutemov" , Martin Schwidefsky Subject: [PATCH] mm: warn only once if page table misaccounting is detected Date: Tue, 27 Nov 2018 09:36:03 +0100 X-Mailer: git-send-email 2.16.4 X-TM-AS-GCONF: 00 x-cbid: 18112708-0028-0000-0000-000003220DDC X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 18112708-0029-0000-0000-000023DE156D Message-Id: <20181127083603.39041-1-heiko.carstens@de.ibm.com> MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2018-11-27_08:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1811270077 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: X-Virus-Scanned: ClamAV using ClamSMTP Use pr_alert_once() instead of pr_alert() if page table misaccounting has been detected. If this happens once it is very likely that there will be numerous other occurrence as well, which would flood dmesg and the console with hardly any added information. Therefore print the warning only once. Cc: Kirill A. Shutemov Cc: Martin Schwidefsky Signed-off-by: Heiko Carstens Acked-by: Kirill A. Shutemov --- kernel/fork.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/kernel/fork.c b/kernel/fork.c index 07cddff89c7b..c887e9eba89f 100644 --- a/kernel/fork.c +++ b/kernel/fork.c @@ -647,8 +647,8 @@ static void check_mm(struct mm_struct *mm) } if (mm_pgtables_bytes(mm)) - pr_alert("BUG: non-zero pgtables_bytes on freeing mm: %ld\n", - mm_pgtables_bytes(mm)); + pr_alert_once("BUG: non-zero pgtables_bytes on freeing mm: %ld\n", + mm_pgtables_bytes(mm)); #if defined(CONFIG_TRANSPARENT_HUGEPAGE) && !USE_SPLIT_PMD_PTLOCKS VM_BUG_ON_MM(mm->pmd_huge_pte, mm);