From patchwork Fri Dec 14 23:02:59 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mel Gorman X-Patchwork-Id: 10731777 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id A67E913AD for ; Fri, 14 Dec 2018 23:03:23 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 599732D639 for ; Fri, 14 Dec 2018 23:03:23 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 4E1F62D63D; Fri, 14 Dec 2018 23:03:23 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.9 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id C206D2D639 for ; Fri, 14 Dec 2018 23:03:22 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2ECF08E021A; Fri, 14 Dec 2018 18:03:14 -0500 (EST) Delivered-To: linux-mm-outgoing@kvack.org Received: by kanga.kvack.org (Postfix, from userid 40) id 221C28E0218; Fri, 14 Dec 2018 18:03:14 -0500 (EST) X-Original-To: int-list-linux-mm@kvack.org X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0A6088E021B; Fri, 14 Dec 2018 18:03:14 -0500 (EST) X-Original-To: linux-mm@kvack.org X-Delivered-To: linux-mm@kvack.org Received: from mail-ed1-f69.google.com (mail-ed1-f69.google.com [209.85.208.69]) by kanga.kvack.org (Postfix) with ESMTP id 7085D8E0218 for ; Fri, 14 Dec 2018 18:03:13 -0500 (EST) Received: by mail-ed1-f69.google.com with SMTP id l45so3463095edb.1 for ; Fri, 14 Dec 2018 15:03:13 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-original-authentication-results:x-gm-message-state:from:to:cc :subject:date:message-id:in-reply-to:references; bh=vDYTnelWXCZf8RMPZjSheUW9//OOrmryct6bxpECWz4=; b=ono/rst/dxIJiDSGNCtbR2R58RD2pbmG4Z0cWM2E0FXDFkAznBAweCRRGjj+tWy68k faaspaUhd/KIi7DG7VYhlqrcpcxU8kCdBF0Eu28QmkETcIpfXZs7fw5z/Vqj6H/eXWtW nLyjoq5Etk/6l1epd+eNjBpv8CQizDGmXgWLX7WEiihCFOabUq8OuETR7u+KJ8imJ+S/ ham3hEdZ9crH+SMgspl2pMsKfqSKUut13WwZ93zUK4ynIP8QURSs6IHfItjpwzUMUUw8 qjuxUkyhMcNCCfcpI7OiwmYDNJNJPZ6QeyFVr6Frpz9KZ8uroaXa7/Q0hC5knEveMJvE PKiA== X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of mgorman@techsingularity.net designates 46.22.139.106 as permitted sender) smtp.mailfrom=mgorman@techsingularity.net X-Gm-Message-State: AA+aEWb7eGDs0JXbKTxlft9M33asVW/Tt/VjsSx/IjZvvU1ggHSxEknw qAwQ30pGuuji2YDR44m6Lm5rg8Lp79j0uTcOCmCQqMLPtGZB5mn2HdQ36lIzeEMMkU7R64t2adt 7IFvlyd9aqiko18u0xWlrfU4+3jwUiokV0Kq2ZGttnqCZnImAsC6YufUD7g/xx0b3TQ== X-Received: by 2002:a50:b487:: with SMTP id w7mr4646737edd.72.1544828592950; Fri, 14 Dec 2018 15:03:12 -0800 (PST) X-Google-Smtp-Source: AFSGD/V7XTNe3rRGdRD4qF8uAKJb0aVcA2oGaWrBdifeUHvtQyPNLWuNN0V9prrdLt4HtEwvPyNb X-Received: by 2002:a50:b487:: with SMTP id w7mr4646703edd.72.1544828592006; Fri, 14 Dec 2018 15:03:12 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1544828591; cv=none; d=google.com; s=arc-20160816; b=Vl+bhf8gjiVlq1xaZK9POjb+TGr+spI5xljBaGKMDRnR0nWfy/bVliurxzq3WfEisf XvujrGWNaEScKw7WZJE/LMt3MLtuHYq3J6v5khFydYD9+skBVKWVRLb3OtZjk3Lk7d9e bSYtqMTLrn983Pb8gnTOdAjCywHP7EKinwJYQGU3wt4ARKnxEocRAPSxNueV8IbckZdj 8Iht0WBeZXnniJRdyL/gy446O3qTDaBtB3pAu8WDAB8J7Yt2ZOvarlQ4FtilBMYB5OEH YWxCAqJLgucIFAc7lcNx65pkjGeDQb7plVbCpYY/jc19QRFSWHxMHkE73tpcuasTmOI8 xydw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=references:in-reply-to:message-id:date:subject:cc:to:from; bh=vDYTnelWXCZf8RMPZjSheUW9//OOrmryct6bxpECWz4=; b=axkNOXZinR76dZedBSP+RhfOJroHnQL5u40umDN5lleo3x3zKjQPxxAJXToGCK+ln3 byw1CDj5+lgTbluEhXXpMJ9wnMx4N4oN/6E3nEhognVfCWlrUHFPPeMgWs+6npZySocY ck67a6prg33rlVl6k3zs7f/V8lZIAI+MhQAfUwxU5Xz92K24IWxUmLtZvvuLA4Bjtf4/ x0dI4YqCrSbfPw2UORuzxhPhREl/udLC5xsljz4FOe7RqEbJVk2BkED7rMMj1bkhtIOq HKPp3vhublKtFssomq/jKXPrGzXveS8B3zWnDhGJdPXt2pHOqphCkR8ylQVeKUyffWj9 2DOw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of mgorman@techsingularity.net designates 46.22.139.106 as permitted sender) smtp.mailfrom=mgorman@techsingularity.net Received: from outbound-smtp11.blacknight.com (outbound-smtp11.blacknight.com. [46.22.139.106]) by mx.google.com with ESMTPS id p8-v6si2062488ejm.303.2018.12.14.15.03.11 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 14 Dec 2018 15:03:11 -0800 (PST) Received-SPF: pass (google.com: domain of mgorman@techsingularity.net designates 46.22.139.106 as permitted sender) client-ip=46.22.139.106; Authentication-Results: mx.google.com; spf=pass (google.com: domain of mgorman@techsingularity.net designates 46.22.139.106 as permitted sender) smtp.mailfrom=mgorman@techsingularity.net Received: from mail.blacknight.com (pemlinmail01.blacknight.ie [81.17.254.10]) by outbound-smtp11.blacknight.com (Postfix) with ESMTPS id 8F9121C205F for ; Fri, 14 Dec 2018 23:03:11 +0000 (GMT) Received: (qmail 31209 invoked from network); 14 Dec 2018 23:03:11 -0000 Received: from unknown (HELO stampy.163woodhaven.lan) (mgorman@techsingularity.net@[37.228.245.71]) by 81.17.254.9 with ESMTPA; 14 Dec 2018 23:03:11 -0000 From: Mel Gorman To: Linux-MM Cc: David Rientjes , Andrea Arcangeli , Linus Torvalds , Michal Hocko , ying.huang@intel.com, kirill@shutemov.name, Andrew Morton , Linux List Kernel Mailing , Mel Gorman Subject: [PATCH 03/14] mm, compaction: Remove last_migrated_pfn from compact_control Date: Fri, 14 Dec 2018 23:02:59 +0000 Message-Id: <20181214230310.572-4-mgorman@techsingularity.net> X-Mailer: git-send-email 2.16.4 In-Reply-To: <20181214230310.572-1-mgorman@techsingularity.net> References: <20181214230310.572-1-mgorman@techsingularity.net> X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: X-Virus-Scanned: ClamAV using ClamSMTP The last_migrated_pfn field is a bit dubious as to whether it really helps but either way, the information from it can be inferred without increasing the size of compact_control so remove the field. Signed-off-by: Mel Gorman Acked-by: Vlastimil Babka --- mm/compaction.c | 25 +++++++++---------------- mm/internal.h | 1 - 2 files changed, 9 insertions(+), 17 deletions(-) diff --git a/mm/compaction.c b/mm/compaction.c index ef29490b0f46..fb4d9f52ed56 100644 --- a/mm/compaction.c +++ b/mm/compaction.c @@ -886,15 +886,6 @@ isolate_migratepages_block(struct compact_control *cc, unsigned long low_pfn, cc->nr_migratepages++; nr_isolated++; - /* - * Record where we could have freed pages by migration and not - * yet flushed them to buddy allocator. - * - this is the lowest page that was isolated and likely be - * then freed by migration. - */ - if (!cc->last_migrated_pfn) - cc->last_migrated_pfn = low_pfn; - /* Avoid isolating too much */ if (cc->nr_migratepages == COMPACT_CLUSTER_MAX) { ++low_pfn; @@ -918,7 +909,6 @@ isolate_migratepages_block(struct compact_control *cc, unsigned long low_pfn, } putback_movable_pages(&cc->migratepages); cc->nr_migratepages = 0; - cc->last_migrated_pfn = 0; nr_isolated = 0; } @@ -1539,6 +1529,7 @@ static enum compact_result compact_zone(struct zone *zone, struct compact_contro enum compact_result ret; unsigned long start_pfn = zone->zone_start_pfn; unsigned long end_pfn = zone_end_pfn(zone); + unsigned long last_migrated_pfn; const bool sync = cc->mode != MIGRATE_ASYNC; cc->migratetype = gfpflags_to_migratetype(cc->gfp_mask); @@ -1584,7 +1575,7 @@ static enum compact_result compact_zone(struct zone *zone, struct compact_contro cc->whole_zone = true; } - cc->last_migrated_pfn = 0; + last_migrated_pfn = 0; trace_mm_compaction_begin(start_pfn, cc->migrate_pfn, cc->free_pfn, end_pfn, sync); @@ -1593,12 +1584,14 @@ static enum compact_result compact_zone(struct zone *zone, struct compact_contro while ((ret = compact_finished(zone, cc)) == COMPACT_CONTINUE) { int err; + unsigned long start_pfn = cc->migrate_pfn; switch (isolate_migratepages(zone, cc)) { case ISOLATE_ABORT: ret = COMPACT_CONTENDED; putback_movable_pages(&cc->migratepages); cc->nr_migratepages = 0; + last_migrated_pfn = 0; goto out; case ISOLATE_NONE: /* @@ -1608,6 +1601,7 @@ static enum compact_result compact_zone(struct zone *zone, struct compact_contro */ goto check_drain; case ISOLATE_SUCCESS: + last_migrated_pfn = start_pfn; ; } @@ -1639,8 +1633,7 @@ static enum compact_result compact_zone(struct zone *zone, struct compact_contro cc->migrate_pfn = block_end_pfn( cc->migrate_pfn - 1, cc->order); /* Draining pcplists is useless in this case */ - cc->last_migrated_pfn = 0; - + last_migrated_pfn = 0; } } @@ -1652,18 +1645,18 @@ static enum compact_result compact_zone(struct zone *zone, struct compact_contro * compact_finished() can detect immediately if allocation * would succeed. */ - if (cc->order > 0 && cc->last_migrated_pfn) { + if (cc->order > 0 && last_migrated_pfn) { int cpu; unsigned long current_block_start = block_start_pfn(cc->migrate_pfn, cc->order); - if (cc->last_migrated_pfn < current_block_start) { + if (last_migrated_pfn < current_block_start) { cpu = get_cpu(); lru_add_drain_cpu(cpu); drain_local_pages(zone); put_cpu(); /* No more flushing until we migrate again */ - cc->last_migrated_pfn = 0; + last_migrated_pfn = 0; } } diff --git a/mm/internal.h b/mm/internal.h index 867af5425432..f40d06d70683 100644 --- a/mm/internal.h +++ b/mm/internal.h @@ -188,7 +188,6 @@ struct compact_control { unsigned int nr_migratepages; /* Number of pages to migrate */ unsigned long free_pfn; /* isolate_freepages search base */ unsigned long migrate_pfn; /* isolate_migratepages search base */ - unsigned long last_migrated_pfn;/* Not yet flushed page being freed */ struct zone *zone; unsigned long total_migrate_scanned; unsigned long total_free_scanned;