From patchwork Wed Jan 9 11:15:06 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mel Gorman X-Patchwork-Id: 10753871 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 53C206C2 for ; Wed, 9 Jan 2019 11:15:12 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 40F7528E6C for ; Wed, 9 Jan 2019 11:15:12 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 3557128EA2; Wed, 9 Jan 2019 11:15:12 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.9 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 1995A28E77 for ; Wed, 9 Jan 2019 11:15:11 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 32A608E00A3; Wed, 9 Jan 2019 06:15:10 -0500 (EST) Delivered-To: linux-mm-outgoing@kvack.org Received: by kanga.kvack.org (Postfix, from userid 40) id 2B2CA8E0038; Wed, 9 Jan 2019 06:15:10 -0500 (EST) X-Original-To: int-list-linux-mm@kvack.org X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 17AC08E00A3; Wed, 9 Jan 2019 06:15:10 -0500 (EST) X-Original-To: linux-mm@kvack.org X-Delivered-To: linux-mm@kvack.org Received: from mail-ed1-f71.google.com (mail-ed1-f71.google.com [209.85.208.71]) by kanga.kvack.org (Postfix) with ESMTP id AF5938E0038 for ; Wed, 9 Jan 2019 06:15:09 -0500 (EST) Received: by mail-ed1-f71.google.com with SMTP id e12so2816961edd.16 for ; Wed, 09 Jan 2019 03:15:09 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-original-authentication-results:x-gm-message-state:date:from:to :cc:subject:message-id:references:mime-version:content-disposition :in-reply-to:user-agent; bh=lL2onbSHpAtC8+kdmtpaJYHWdjBVx7IzPkNwNZy/W7I=; b=XqdrcFQKqE0swSkU+siSI47V+dHzna2THVnC7AWO9syFLv/iokmFjgPiomyMzzlg/F 4WBI5szufi+22IhMWBfc1EVMZnJlX+yw8Yuj3z0/ukhOY/M40QU5DkG6phOAqFvUGlnk U3JGbfwPdRqUNFoXNEgM5LqncJQ8ftssS09T2DO+KEp4o18RpWAhOUELS86ovHaA+mJ3 WBBpFyodNSmmtHiIZ9YeziDofV1NJ5NkDu156CXs/RKWOG19b1IUqJ6rGB3XZdL7OEBM VEl9wJX8BimBvfosaLV1attow3bZzegshR5ARuX7vn6i698Zpvu8XlqKnXQawnlWJPzf MUjw== X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of mgorman@techsingularity.net designates 81.17.249.194 as permitted sender) smtp.mailfrom=mgorman@techsingularity.net X-Gm-Message-State: AJcUukf4r6gflKYYhVc9eAf3i6uOcIiaC6NxzIiwHdtcBfmrHXYMay4v 4Xw9aQg+1IPSt7AZF1bPOy010O4nT0P1p8H6jhuV3CASjFiUF8Siqrn4Sop/04g8ElPqeyFTqor iiJ3a6EcUJFhbXU7eGWeSY4A4b6ase+C0UTIxmF3hbL9zZamG3NBEyQAA0qu0juzc4A== X-Received: by 2002:a50:94f4:: with SMTP id t49mr5678129eda.24.1547032509178; Wed, 09 Jan 2019 03:15:09 -0800 (PST) X-Google-Smtp-Source: ALg8bN4gRq0x7j7sVcxwPCVD3MTxKPnJZuernX/QfXo2kTDoWviHgTsyDoaP6NE7sKVW1rijPmz5 X-Received: by 2002:a50:94f4:: with SMTP id t49mr5678083eda.24.1547032508261; Wed, 09 Jan 2019 03:15:08 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1547032508; cv=none; d=google.com; s=arc-20160816; b=afW/T1whMXIn6KJs+H8uIGgO81fmXWLdoFOfZ4bNIGYE21SORv9UXsv1RA2wZhMxEa ZRfvBAY+FaPtwkFJ4qKdPiB6f1ZPis8bNgnV4Bvz4/yTqdWX6qU6Ntl1hJF1i1sML2Ek cILaPJ3WBW2+9/lN8P7si9cYHGVuhKaKNEwdT69nr6aspV0nN0WdLO33c4b4km2QH+S/ fca4n/y/lZx9dcuqnw5UsKA64CnYXojWdpIpTJ+BSw4LGVZHwc8VnVs67dPVZ+ZG5wZz Ib10jpFroe+amVUSIy5j3juph+hl9ySotACG/GQGUF2S+DrmhTKtZ6xyesIvp8QyCYAU mL3A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date; bh=lL2onbSHpAtC8+kdmtpaJYHWdjBVx7IzPkNwNZy/W7I=; b=gzNzcdHXUBqy7acxLmPfRL7PWONyB4w1mD0hart9piMBry2CJM4jusz0R+CX5R9TWx V+OQDpefEukTqkRrq5dJR9JOcHE8zhs9t4La0OSYUV/CT9cUHH8Mwb7VPxmQMcWvQlKM GeXnWppcuG9kt+MZjeBrM6/HgseYF4fSixn7i4al98eYhTc9MRTSI7Ij+A92DCXxsVC8 Qbyp7SUk+CfecC40LNo1n4nt5lgYzXA2vzuWgoN5aVdLLafQKZIZ2rqhUMQIS5DiC53o vQlB9fHuunQXtEe53VJpeaJ5RE4C4v+SzLNroANXW/KnQ4YsOb4MuYPZdKIEijKWJ/Zg 5s3g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of mgorman@techsingularity.net designates 81.17.249.194 as permitted sender) smtp.mailfrom=mgorman@techsingularity.net Received: from outbound-smtp26.blacknight.com (outbound-smtp26.blacknight.com. [81.17.249.194]) by mx.google.com with ESMTPS id g6si324256eds.222.2019.01.09.03.15.08 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 09 Jan 2019 03:15:08 -0800 (PST) Received-SPF: pass (google.com: domain of mgorman@techsingularity.net designates 81.17.249.194 as permitted sender) client-ip=81.17.249.194; Authentication-Results: mx.google.com; spf=pass (google.com: domain of mgorman@techsingularity.net designates 81.17.249.194 as permitted sender) smtp.mailfrom=mgorman@techsingularity.net Received: from mail.blacknight.com (pemlinmail03.blacknight.ie [81.17.254.16]) by outbound-smtp26.blacknight.com (Postfix) with ESMTPS id EF5CBB8A07 for ; Wed, 9 Jan 2019 11:15:07 +0000 (GMT) Received: (qmail 8796 invoked from network); 9 Jan 2019 11:15:07 -0000 Received: from unknown (HELO techsingularity.net) (mgorman@techsingularity.net@[37.228.229.96]) by 81.17.254.9 with ESMTPSA (AES256-SHA encrypted, authenticated); 9 Jan 2019 11:15:07 -0000 Date: Wed, 9 Jan 2019 11:15:06 +0000 From: Mel Gorman To: Andrew Morton Cc: David Rientjes , Andrea Arcangeli , Vlastimil Babka , ying.huang@intel.com, kirill@shutemov.name, YueHaibing , Linux-MM , Linux List Kernel Mailing Subject: [PATCH] mm, compaction: Finish pageblock scanning on contention -fix Message-ID: <20190109111506.GV31517@techsingularity.net> References: <20190104125011.16071-1-mgorman@techsingularity.net> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190104125011.16071-1-mgorman@techsingularity.net> User-Agent: Mutt/1.10.1 (2018-07-13) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: X-Virus-Scanned: ClamAV using ClamSMTP From: YueHaibing Fixes gcc '-Wunused-but-set-variable' warning: mm/compaction.c: In function 'compact_zone': mm/compaction.c:2063:22: warning: variable 'c' set but not used [-Wunused-but-set-variable] mm/compaction.c:2063:19: warning: variable 'b' set but not used [-Wunused-but-set-variable] mm/compaction.c:2063:16: warning: variable 'a' set but not used [-Wunused-but-set-variable] This never used since 94d5992baaa5 ("mm, compaction: finish pageblock scanning on contention"). This is a fix to the mmotm patch broken-out/mm-compaction-finish-pageblock-scanning-on-contention.patch Signed-off-by: YueHaibing Signed-off-by: Mel Gorman --- mm/compaction.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/mm/compaction.c b/mm/compaction.c index 51da4691092b..ca8da58ce1cd 100644 --- a/mm/compaction.c +++ b/mm/compaction.c @@ -1963,7 +1963,6 @@ static enum compact_result compact_zone(struct compact_control *cc) unsigned long end_pfn = zone_end_pfn(cc->zone); unsigned long last_migrated_pfn; const bool sync = cc->mode != MIGRATE_ASYNC; - unsigned long a, b, c; cc->migratetype = gfpflags_to_migratetype(cc->gfp_mask); ret = compaction_suitable(cc->zone, cc->order, cc->alloc_flags, @@ -2009,10 +2008,6 @@ static enum compact_result compact_zone(struct compact_control *cc) cc->whole_zone = true; } - a = cc->migrate_pfn; - b = cc->free_pfn; - c = (cc->free_pfn - cc->migrate_pfn) / pageblock_nr_pages; - last_migrated_pfn = 0; trace_mm_compaction_begin(start_pfn, cc->migrate_pfn,