From patchwork Mon Jan 21 08:17:51 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ming Lei X-Patchwork-Id: 10773149 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id D37C814E5 for ; Mon, 21 Jan 2019 08:19:38 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id C411B29EB5 for ; Mon, 21 Jan 2019 08:19:38 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id B6F2C29EB8; Mon, 21 Jan 2019 08:19:38 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.9 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 65F1929EB5 for ; Mon, 21 Jan 2019 08:19:37 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 959168E002E; Mon, 21 Jan 2019 03:19:36 -0500 (EST) Delivered-To: linux-mm-outgoing@kvack.org Received: by kanga.kvack.org (Postfix, from userid 40) id 8E22D8E0025; Mon, 21 Jan 2019 03:19:36 -0500 (EST) X-Original-To: int-list-linux-mm@kvack.org X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7A9558E002E; Mon, 21 Jan 2019 03:19:36 -0500 (EST) X-Original-To: linux-mm@kvack.org X-Delivered-To: linux-mm@kvack.org Received: from mail-qt1-f199.google.com (mail-qt1-f199.google.com [209.85.160.199]) by kanga.kvack.org (Postfix) with ESMTP id 4AA428E0025 for ; Mon, 21 Jan 2019 03:19:36 -0500 (EST) Received: by mail-qt1-f199.google.com with SMTP id z6so20164316qtj.21 for ; Mon, 21 Jan 2019 00:19:36 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-original-authentication-results:x-gm-message-state:from:to:cc :subject:date:message-id:in-reply-to:references; bh=Koc+x6ZPCcpLbp0ogoXEke8ZDu3+j/1e8qVxbzGR/dQ=; b=Q2YXeXh4V5f72Ncixsujqktsg2Ab6DDk37fwlaYaJpmBBm0JShj2GW/cuFzGDg1v6O DCmvOYtuwcJE52okyCvqrE/CNHvm8TzxtVGOPBgggR9MoruttjHTTvdhzdKefWboQuJI Z0VDDhIz0N85L1L74dHTIISUcrB6nTeQtSmC930BobBziRwWAV9vsuwPSykWQxXDhMdv xcodIYATq0afD/gzFNkNEYkAwdsELtrxtMrP1s6G9RkvAc+8zBhwymbC6A6qytAKH89b b8m7hjTJRpAgyMt0zE5n3GN3aIf6eZ/ylUY+RgysgmQYvBuPf6m8eN1IwQv9ccQZI/Wo UW2Q== X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of ming.lei@redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=ming.lei@redhat.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com X-Gm-Message-State: AJcUuke4i8u1APcB258+KgF+sEzaH8rkSu542WjUaf2meDE+5/VnOk/T uvP+HE/GV9TFOFLXNNTv9eNmwY8lOEGpcAcQ4OwiBSbhnCfWVFXs1/HHYT80o+yLWInPC1bmeBw jyJfowy6A5l1V3H8t4qryyYsyZguXjSKNwfVD7uno3mj/Q+SOHGqGQR9/Hio34TeWcg== X-Received: by 2002:ad4:5004:: with SMTP id s4mr24912542qvo.109.1548058776071; Mon, 21 Jan 2019 00:19:36 -0800 (PST) X-Google-Smtp-Source: ALg8bN7oRJk8CV+KzYWNYU4h2UMiqCX8X33jDfbZZ376mLpN/aWjk6wWQ+b91pCQpLDq4Bz1AFR4 X-Received: by 2002:ad4:5004:: with SMTP id s4mr24912513qvo.109.1548058775411; Mon, 21 Jan 2019 00:19:35 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1548058775; cv=none; d=google.com; s=arc-20160816; b=VIDl8uDsBxxufDQsdWJ61EiTMyZykheGEDjDsKoJT/u+q+gRwYu05BbAF1zA1cpyun T1a0YwbjUTuhlt4w5jO/oaoluTDUor/DaLiXKY++u8Gkr4Kd6PmCmuAKX9cEQxVzN/Bt nsRbZFHhJUVY7v0q4zFUa3gUU+2nTd9bYvDJQoUShO6TUyxeFLZjLlzEgR/E5vAxfPvn SDmnfBxN5ZjZEXc9TmjlRpvy3sAgrc6M1N/lSaujFWdTkgXZ9pg/GoTOxmTl9GbqfDiD ZXYcGz2C0fGiYCBu+wbwlBEd0xlGJuXvx7PD+B0iLif6yVxA7DfAMeZ/O0ykKpduZOKF cElA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=references:in-reply-to:message-id:date:subject:cc:to:from; bh=Koc+x6ZPCcpLbp0ogoXEke8ZDu3+j/1e8qVxbzGR/dQ=; b=jR34eLr8BEf+b6yFRzDCuDXeTHf8RIMZi/hyoMcc+CDp6IxgBXrgKpEU0W3q0Z7XAV hnBoXNK3enpCEEbu9BPSC0AGcH9wsoJy+WhmVqq0txxZ3EFfcoVCOpioUM7w5BxPjEii Hf4lZROAfGi0JLtOkqFJUbFCKZf2r6Ii9+dE7SoH4tMxzvJWyvu1dvmRln7bCwsv1VtJ 7SlPoHLno8gTXRqD+SPKPmcYI3KbITs+yoa8CssvH1FXDtaHGnFQ66ryR6i1ILzSQwWL E4nu89Fsn20eZhAdOnDOlvDVfcidOBIBgc0sN31aD8scBl1xIJ8Fn9ooq/RF1uQ8QDIs /vsw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of ming.lei@redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=ming.lei@redhat.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from mx1.redhat.com (mx1.redhat.com. [209.132.183.28]) by mx.google.com with ESMTPS id q4si642804qkj.161.2019.01.21.00.19.35 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 21 Jan 2019 00:19:35 -0800 (PST) Received-SPF: pass (google.com: domain of ming.lei@redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; Authentication-Results: mx.google.com; spf=pass (google.com: domain of ming.lei@redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=ming.lei@redhat.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 652018535D; Mon, 21 Jan 2019 08:19:34 +0000 (UTC) Received: from localhost (ovpn-8-22.pek2.redhat.com [10.72.8.22]) by smtp.corp.redhat.com (Postfix) with ESMTP id 8540719C7D; Mon, 21 Jan 2019 08:19:19 +0000 (UTC) From: Ming Lei To: Jens Axboe Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Theodore Ts'o , Omar Sandoval , Sagi Grimberg , Dave Chinner , Kent Overstreet , Mike Snitzer , dm-devel@redhat.com, Alexander Viro , linux-fsdevel@vger.kernel.org, linux-raid@vger.kernel.org, David Sterba , linux-btrfs@vger.kernel.org, "Darrick J . Wong" , linux-xfs@vger.kernel.org, Gao Xiang , Christoph Hellwig , linux-ext4@vger.kernel.org, Coly Li , linux-bcache@vger.kernel.org, Boaz Harrosh , Bob Peterson , cluster-devel@redhat.com, Ming Lei Subject: [PATCH V14 04/18] block: introduce multi-page bvec helpers Date: Mon, 21 Jan 2019 16:17:51 +0800 Message-Id: <20190121081805.32727-5-ming.lei@redhat.com> In-Reply-To: <20190121081805.32727-1-ming.lei@redhat.com> References: <20190121081805.32727-1-ming.lei@redhat.com> X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.25]); Mon, 21 Jan 2019 08:19:34 +0000 (UTC) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: X-Virus-Scanned: ClamAV using ClamSMTP This patch introduces helpers of 'mp_bvec_iter_*' for multi-page bvec support. The introduced helpers treate one bvec as real multi-page segment, which may include more than one pages. The existed helpers of bvec_iter_* are interfaces for supporting current bvec iterator which is thought as single-page by drivers, fs, dm and etc. These introduced helpers will build single-page bvec in flight, so this way won't break current bio/bvec users, which needn't any change. Follows some multi-page bvec background: - bvecs stored in bio->bi_io_vec is always multi-page style - bvec(struct bio_vec) represents one physically contiguous I/O buffer, now the buffer may include more than one page after multi-page bvec is supported, and all these pages represented by one bvec is physically contiguous. Before multi-page bvec support, at most one page is included in one bvec, we call it single-page bvec. - .bv_page of the bvec points to the 1st page in the multi-page bvec - .bv_offset of the bvec is the offset of the buffer in the bvec The effect on the current drivers/filesystem/dm/bcache/...: - almost everyone supposes that one bvec only includes one single page, so we keep the sp interface not changed, for example, bio_for_each_segment() still returns single-page bvec - bio_for_each_segment_all() will return single-page bvec too - during iterating, iterator variable(struct bvec_iter) is always updated in multi-page bvec style, and bvec_iter_advance() is kept not changed - returned(copied) single-page bvec is built in flight by bvec helpers from the stored multi-page bvec Reviewed-by: Christoph Hellwig Reviewed-by: Omar Sandoval Signed-off-by: Ming Lei --- include/linux/bvec.h | 30 +++++++++++++++++++++++++++--- 1 file changed, 27 insertions(+), 3 deletions(-) diff --git a/include/linux/bvec.h b/include/linux/bvec.h index ba0ae40e77c9..0ae729b1c9fe 100644 --- a/include/linux/bvec.h +++ b/include/linux/bvec.h @@ -23,6 +23,7 @@ #include #include #include +#include /* * was unsigned short, but we might as well be ready for > 64kB I/O pages @@ -50,16 +51,39 @@ struct bvec_iter { */ #define __bvec_iter_bvec(bvec, iter) (&(bvec)[(iter).bi_idx]) -#define bvec_iter_page(bvec, iter) \ +/* multi-page (mp_bvec) helpers */ +#define mp_bvec_iter_page(bvec, iter) \ (__bvec_iter_bvec((bvec), (iter))->bv_page) -#define bvec_iter_len(bvec, iter) \ +#define mp_bvec_iter_len(bvec, iter) \ min((iter).bi_size, \ __bvec_iter_bvec((bvec), (iter))->bv_len - (iter).bi_bvec_done) -#define bvec_iter_offset(bvec, iter) \ +#define mp_bvec_iter_offset(bvec, iter) \ (__bvec_iter_bvec((bvec), (iter))->bv_offset + (iter).bi_bvec_done) +#define mp_bvec_iter_page_idx(bvec, iter) \ + (mp_bvec_iter_offset((bvec), (iter)) / PAGE_SIZE) + +#define mp_bvec_iter_bvec(bvec, iter) \ +((struct bio_vec) { \ + .bv_page = mp_bvec_iter_page((bvec), (iter)), \ + .bv_len = mp_bvec_iter_len((bvec), (iter)), \ + .bv_offset = mp_bvec_iter_offset((bvec), (iter)), \ +}) + +/* For building single-page bvec in flight */ + #define bvec_iter_offset(bvec, iter) \ + (mp_bvec_iter_offset((bvec), (iter)) % PAGE_SIZE) + +#define bvec_iter_len(bvec, iter) \ + min_t(unsigned, mp_bvec_iter_len((bvec), (iter)), \ + PAGE_SIZE - bvec_iter_offset((bvec), (iter))) + +#define bvec_iter_page(bvec, iter) \ + nth_page(mp_bvec_iter_page((bvec), (iter)), \ + mp_bvec_iter_page_idx((bvec), (iter))) + #define bvec_iter_bvec(bvec, iter) \ ((struct bio_vec) { \ .bv_page = bvec_iter_page((bvec), (iter)), \