From patchwork Tue Jan 29 18:48:43 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: James Morse X-Patchwork-Id: 10786909 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 67CFC91E for ; Tue, 29 Jan 2019 18:50:04 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 581B62D1D2 for ; Tue, 29 Jan 2019 18:50:04 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 4C0DA2D1A7; Tue, 29 Jan 2019 18:50:04 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.9 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_NONE autolearn=unavailable version=3.3.1 Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id EE73B2D1A7 for ; Tue, 29 Jan 2019 18:50:03 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B9D3D8E0008; Tue, 29 Jan 2019 13:50:01 -0500 (EST) Delivered-To: linux-mm-outgoing@kvack.org Received: by kanga.kvack.org (Postfix, from userid 40) id B4BA58E0003; Tue, 29 Jan 2019 13:50:01 -0500 (EST) X-Original-To: int-list-linux-mm@kvack.org X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A11D18E0008; Tue, 29 Jan 2019 13:50:01 -0500 (EST) X-Original-To: linux-mm@kvack.org X-Delivered-To: linux-mm@kvack.org Received: from mail-ed1-f72.google.com (mail-ed1-f72.google.com [209.85.208.72]) by kanga.kvack.org (Postfix) with ESMTP id 5CDC78E0003 for ; Tue, 29 Jan 2019 13:50:01 -0500 (EST) Received: by mail-ed1-f72.google.com with SMTP id y35so8312950edb.5 for ; Tue, 29 Jan 2019 10:50:01 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-original-authentication-results:x-gm-message-state:from:to:cc :subject:date:message-id:in-reply-to:references:mime-version :content-transfer-encoding; bh=k7wnSh0/AWdeE9IE2N0pFqQz9uaZdVz3WI19ff9zm4Y=; b=FJuJhWZoUUSO09RJr7MPslNi45iVntgw2H9GvtYi/CU7i8wORXIhvbi+UwZQ5F98Yq vMx7ktK6CLPqDEAuKlQGn0vmck38ddcowuRTuHAAwAFyc1nv2HxPe3hT9YWBwwKD2xmq CkdKoToVmcPAt+QhPS6Y4gB4fB0jPj5GT91/jDZev0exbCx4Vr37wqM1kFFhESDkSpZM CyvgaEW54X5VcAoBuITyAHOaSVPq+7FQCMsV59f3THSNBlGUAvNo+ATaPAuskN+A63MF uricGFaPzzsn5n+rEgxulKAEkSq5g286xW2/vaY9RtjRotc1uPDu6Iyfh7fmieq4dxhT lt3w== X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of james.morse@arm.com designates 217.140.101.70 as permitted sender) smtp.mailfrom=james.morse@arm.com X-Gm-Message-State: AJcUukeEKq4T1mTSAM27zkGYSbdz+pF5KaeSSZySmoDfA8wmAvGrAaCK rxxb0pKrBu5LkxjDhvvmpt1STxEco1h12b+ObxyjyW+VCaRnveDc111ifIY5bvyqT8tVicX8j48 MLFnbRbmjlOCM5LnrQdpr14marJi5exvhT+OhQpvxcb+EQH6N5c1VGi7I7elESDZ81A== X-Received: by 2002:aa7:dd0f:: with SMTP id i15mr25423213edv.29.1548787800875; Tue, 29 Jan 2019 10:50:00 -0800 (PST) X-Google-Smtp-Source: ALg8bN5D/cc8Pvfobcng/yVBMiKgAPkUgKyyyYppoPx1g0GomMPjvQGYUJFwK2V5777bi8duKdXr X-Received: by 2002:aa7:dd0f:: with SMTP id i15mr25423178edv.29.1548787800094; Tue, 29 Jan 2019 10:50:00 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1548787800; cv=none; d=google.com; s=arc-20160816; b=GjGlk4f426yTjjEvibDoiHD0/D7QqZr656Wf4Nxs6PmLQ35yJ9q553rFHYLZ8VL9q4 HCpjisgnNSNvVeXVFx5kctCguAKYEtiZmLk0SF+Ds5Qv6S+aAVt3dqsb9z32gvNOg7dG 8HUlVbva8c4q9rh1lB3M0Yyd3Btk9LKX97SOqXVyC9lLGdxE18CHR8eMByTa+K7wa+xL VFvp3JbIO/hfhJTXW6DDjA8z37tPi2/wpwKGc4+0fv+8aecN2GylaXK4+poxG8SVcQT6 qpeqBnacYPwaWaKH84mY1qBaqdL3BzKrDixtWVfuV0vAYLOvMzv3N9dHVMqb+9StpQXD h+5w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from; bh=k7wnSh0/AWdeE9IE2N0pFqQz9uaZdVz3WI19ff9zm4Y=; b=EHfQlshV/aIZQrTZIuoQk0vEqc/YATmIqIr9HGFLxGlQvb95WzP4TMRMQhlpuwQkUa 5CNm5Rcmbq14Qf3AlgBBW4S+igJ5XseBmMPKPDsStB0mknEWmaZBdV+EHUxEYqjf8tNj DAYnT5UjLNVGn8fm3fopO33M3i1xvl40dR12jgl87X1b9EDqbaDiDYP2JucNzXE8I7eN 9enCYWqpGg20T79XIf2FHYEJ+bj0WqyUfMZT1Uih/BcXADQ1bBkjRT5BWc9wd6PO/QYc Wf4riXEOPCLBtINRIlJaztI3VXiJ3aa31Njt40fQAmZflvMHbKXnL5DfjbMpzXPkP/u+ COmA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of james.morse@arm.com designates 217.140.101.70 as permitted sender) smtp.mailfrom=james.morse@arm.com Received: from foss.arm.com (usa-sjc-mx-foss1.foss.arm.com. [217.140.101.70]) by mx.google.com with ESMTP id m22si3009302edj.434.2019.01.29.10.49.59 for ; Tue, 29 Jan 2019 10:50:00 -0800 (PST) Received-SPF: pass (google.com: domain of james.morse@arm.com designates 217.140.101.70 as permitted sender) client-ip=217.140.101.70; Authentication-Results: mx.google.com; spf=pass (google.com: domain of james.morse@arm.com designates 217.140.101.70 as permitted sender) smtp.mailfrom=james.morse@arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 1E30E1596; Tue, 29 Jan 2019 10:49:59 -0800 (PST) Received: from eglon.cambridge.arm.com (eglon.cambridge.arm.com [10.1.196.105]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 711903F557; Tue, 29 Jan 2019 10:49:56 -0800 (PST) From: James Morse To: linux-acpi@vger.kernel.org Cc: kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org, linux-mm@kvack.org, Borislav Petkov , Marc Zyngier , Christoffer Dall , Will Deacon , Catalin Marinas , Naoya Horiguchi , Rafael Wysocki , Len Brown , Tony Luck , Dongjiu Geng , Xie XiuQi , james.morse@arm.com Subject: [PATCH v8 07/26] ACPI / APEI: Remove spurious GHES_TO_CLEAR check Date: Tue, 29 Jan 2019 18:48:43 +0000 Message-Id: <20190129184902.102850-8-james.morse@arm.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190129184902.102850-1-james.morse@arm.com> References: <20190129184902.102850-1-james.morse@arm.com> MIME-Version: 1.0 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: X-Virus-Scanned: ClamAV using ClamSMTP ghes_notify_nmi() checks ghes->flags for GHES_TO_CLEAR before going on to __process_error(). This is pointless as ghes_read_estatus() will always set this flag if it returns success, which was checked earlier in the loop. Remove it. Signed-off-by: James Morse Reviewed-by: Borislav Petkov --- drivers/acpi/apei/ghes.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/acpi/apei/ghes.c b/drivers/acpi/apei/ghes.c index a34f79153b1a..c20e1d0947b1 100644 --- a/drivers/acpi/apei/ghes.c +++ b/drivers/acpi/apei/ghes.c @@ -940,9 +940,6 @@ static int ghes_notify_nmi(unsigned int cmd, struct pt_regs *regs) __ghes_panic(ghes, buf_paddr); } - if (!(ghes->flags & GHES_TO_CLEAR)) - continue; - __process_error(ghes); ghes_clear_estatus(ghes, buf_paddr); }