From patchwork Wed Apr 3 04:21:15 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Tobin C. Harding" X-Patchwork-Id: 10882743 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 9EAC91575 for ; Wed, 3 Apr 2019 04:23:02 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 86862287A6 for ; Wed, 3 Apr 2019 04:23:02 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 79D1E289BF; Wed, 3 Apr 2019 04:23:02 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.9 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id C8D54287A6 for ; Wed, 3 Apr 2019 04:23:01 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C38EC6B0272; Wed, 3 Apr 2019 00:23:00 -0400 (EDT) Delivered-To: linux-mm-outgoing@kvack.org Received: by kanga.kvack.org (Postfix, from userid 40) id C12346B0274; Wed, 3 Apr 2019 00:23:00 -0400 (EDT) X-Original-To: int-list-linux-mm@kvack.org X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AD8F86B0275; Wed, 3 Apr 2019 00:23:00 -0400 (EDT) X-Original-To: linux-mm@kvack.org X-Delivered-To: linux-mm@kvack.org Received: from mail-qt1-f200.google.com (mail-qt1-f200.google.com [209.85.160.200]) by kanga.kvack.org (Postfix) with ESMTP id 8CE346B0272 for ; Wed, 3 Apr 2019 00:23:00 -0400 (EDT) Received: by mail-qt1-f200.google.com with SMTP id v18so15706383qtk.5 for ; Tue, 02 Apr 2019 21:23:00 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:dkim-signature:from:to:cc:subject:date :message-id:in-reply-to:references:mime-version :content-transfer-encoding; bh=bxV5jBaXvA/LKL0qOR0ZLSK5IIfdrfWAd0nyjsopfiM=; b=LueBaAUI1iE6FSybqpbGnejtYEdauhGZARUzXb2j6OoTGJ5+P6poKaWG1FgIjNy+5t DJQAImHV2kHEgJyZm9IGMsZ6E29BMwm+Br6eRpvCVvJuZLpludW/owPq+egVfm5Goqc9 TOdGmZndOdwsSCulaX19JwzlE6Q8HszH3EAK8VyIiN5KzTm1hRVFh5EAh5sUxH+kXJLp ExIm1Y/WC3jdbc2/1ua78yJHSLc9B7CacUA45fO2lCb/MKQF7PokHFtH+U/y52hn4Amm PTcOWwecV1UkoamojKozIl1SSSLZbIS/GE1I1fJTn835EiGo0TgunjuDCNoHY2IF/n9w Ow/A== X-Gm-Message-State: APjAAAUqjoqUglO5NCvznIRA1WBFmEUYPGb55bdi4qReJnPxCfMLMwBI Q5jmc8A70GMVKsxTcsiwOqwTzhL17d833XAKzvBNmedsus6GiyeTI1k1L4vCARwGDPlzHSdiI/U Y0lcCIVFf/YE7hVDlOBbKsXfTf81zPNqxB1NBiWPrCqct/Q4b/rch0r7rCdTTF48= X-Received: by 2002:a0c:e587:: with SMTP id t7mr37965219qvm.114.1554265380319; Tue, 02 Apr 2019 21:23:00 -0700 (PDT) X-Google-Smtp-Source: APXvYqzoPrXPc1LRgN/bxCcXBhvShRz0TvCdJn+K5iARaPh1LfsG9lcJGtaJeo2rRuqR6I00BhPv X-Received: by 2002:a0c:e587:: with SMTP id t7mr37965175qvm.114.1554265379057; Tue, 02 Apr 2019 21:22:59 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1554265379; cv=none; d=google.com; s=arc-20160816; b=tjK8ROP8lzXRgPDs/8JG0vtu1+qBo0nvnmr38g1NJKsF0J5oR4ysOyoW+xBTAmZLXt r/tvz1XyvsJiwhr//uLXOz3r1oMVNiYaGlaM5RVSHhC5n0Iy3UH275lZDbwPQuut9H4y Ds0JLWaUCcTmEB2qys8BBoOFCPB4HhLbIXcdOHCFOG/uDxHCaxLktjimYb6JJ+mV719g 5K/S82ZvBz6Y7XyC6ZskFh5oCQ2GzGkgOUTH9QDZ5pvxrwYrSZpG3ej7UFDDaS9/wgTu sWliAiBGxOJTQmEz+/f5xTYW/graA6lNwr/bjTehbgd9LPW4fjzadsldyxnARwhjDTZY NU1Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=bxV5jBaXvA/LKL0qOR0ZLSK5IIfdrfWAd0nyjsopfiM=; b=Av8ReY6h+lNYDEdG+wqljtjaDHy3bcaMkdmyfuQHZerfAm+kSEdOVMsb9R88Kcf11q pjeBHw3hhFVdWb2kga++cKbdjR+E0uzcsU4+m4ebpWTvj6FE69i7EQdf23mZzUCV8nu0 EYkHehj48GkimcRhhrFuOGTFjp2UYRJpy5JmWskyZmAfK8CGajL1bHPt9h9Pg1uPgW/0 5r/diwWPmdRlfG3/kPPXXBAyxKBzmWoHSCqwzK6EV8SKeSZLnddSbRNL96sDk9x1wkxz sTN26FQkzGGb2pFZ2OadjAdjiPHfj/hVKSlXMiLu/giyQdsg9tvs3PPw2u5e0lTkQSXh s2Ug== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@messagingengine.com header.s=fm2 header.b="V/Y3w93P"; spf=softfail (google.com: domain of transitioning tobin@kernel.org does not designate 66.111.4.28 as permitted sender) smtp.mailfrom=tobin@kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com. [66.111.4.28]) by mx.google.com with ESMTPS id i12si2734380qtr.73.2019.04.02.21.22.58 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 02 Apr 2019 21:22:59 -0700 (PDT) Received-SPF: softfail (google.com: domain of transitioning tobin@kernel.org does not designate 66.111.4.28 as permitted sender) client-ip=66.111.4.28; Authentication-Results: mx.google.com; dkim=pass header.i=@messagingengine.com header.s=fm2 header.b="V/Y3w93P"; spf=softfail (google.com: domain of transitioning tobin@kernel.org does not designate 66.111.4.28 as permitted sender) smtp.mailfrom=tobin@kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id AE48921B24; Wed, 3 Apr 2019 00:22:58 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute3.internal (MEProxy); Wed, 03 Apr 2019 00:22:58 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:date:from :in-reply-to:message-id:mime-version:references:subject:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; bh=bxV5jBaXvA/LKL0qOR0ZLSK5IIfdrfWAd0nyjsopfiM=; b=V/Y3w93P eDWWJ0zDKkgrTdnG9yUUrsY+karzjq+Fn9idovC3n7/bivCQ7R1bsVM2c5YGscG8 sR2mhr+En1765Mq5xj+9KQKGLCVvAOGhwa15dx6UudoCxQHsXMVVuFZP9u8Ur/Cg LN7WzigSvztiJ4vcOGkHnTyf2WFc8d0DGepG8WyyPxmN5Eiz2pPVh3dFmdbibVL6 6oapkwkiWiJzBt64IaSFbbr/wyJFPg2DqNMe9yE09bSc+nUCgRO8E5Bjq2kCcaIf H+CSus/Gw9OONyrpzMtxWCC6If1SeD25wsJ7SFu0lZzXvl6aAmSE7Jqb3XQAGmdN zUjMb6akz8gRCw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduuddrtddugdektdculddtuddrgedutddrtddtmd cutefuodetggdotefrodftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdp uffrtefokffrpgfnqfghnecuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivg hnthhsucdlqddutddtmdenucfjughrpefhvffufffkofgjfhgggfestdekredtredttden ucfhrhhomhepfdfvohgsihhnucevrdcujfgrrhguihhnghdfuceothhosghinheskhgvrh hnvghlrdhorhhgqeenucfkphepuddvgedrudeiledrvdejrddvtdeknecurfgrrhgrmhep mhgrihhlfhhrohhmpehtohgsihhnsehkvghrnhgvlhdrohhrghenucevlhhushhtvghruf hiiigvpedu X-ME-Proxy: Received: from eros.localdomain (124-169-27-208.dyn.iinet.net.au [124.169.27.208]) by mail.messagingengine.com (Postfix) with ESMTPA id D33C210380; Wed, 3 Apr 2019 00:22:51 -0400 (EDT) From: "Tobin C. Harding" To: Andrew Morton Cc: "Tobin C. Harding" , Roman Gushchin , Alexander Viro , Christoph Hellwig , Pekka Enberg , David Rientjes , Joonsoo Kim , Christopher Lameter , Matthew Wilcox , Miklos Szeredi , Andreas Dilger , Waiman Long , Tycho Andersen , "Theodore Ts'o" , Andi Kleen , David Chinner , Nick Piggin , Rik van Riel , Hugh Dickins , linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [RFC PATCH v2 02/14] tools/vm/slabinfo: Add support for -C and -M options Date: Wed, 3 Apr 2019 15:21:15 +1100 Message-Id: <20190403042127.18755-3-tobin@kernel.org> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190403042127.18755-1-tobin@kernel.org> References: <20190403042127.18755-1-tobin@kernel.org> MIME-Version: 1.0 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: X-Virus-Scanned: ClamAV using ClamSMTP -C lists caches that use a ctor. -M lists caches that support object migration. Add command line options to show caches with a constructor and caches that are movable (i.e. have migrate function). Co-developed-by: Christoph Lameter Signed-off-by: Tobin C. Harding --- tools/vm/slabinfo.c | 40 ++++++++++++++++++++++++++++++++++++---- 1 file changed, 36 insertions(+), 4 deletions(-) diff --git a/tools/vm/slabinfo.c b/tools/vm/slabinfo.c index 73818f1b2ef8..cbfc56c44c2f 100644 --- a/tools/vm/slabinfo.c +++ b/tools/vm/slabinfo.c @@ -33,6 +33,7 @@ struct slabinfo { unsigned int hwcache_align, object_size, objs_per_slab; unsigned int sanity_checks, slab_size, store_user, trace; int order, poison, reclaim_account, red_zone; + int movable, ctor; unsigned long partial, objects, slabs, objects_partial, objects_total; unsigned long alloc_fastpath, alloc_slowpath; unsigned long free_fastpath, free_slowpath; @@ -67,6 +68,8 @@ int show_report; int show_alias; int show_slab; int skip_zero = 1; +int show_movable; +int show_ctor; int show_numa; int show_track; int show_first_alias; @@ -109,11 +112,13 @@ static void fatal(const char *x, ...) static void usage(void) { - printf("slabinfo 4/15/2011. (c) 2007 sgi/(c) 2011 Linux Foundation.\n\n" - "slabinfo [-aADefhilnosrStTvz1LXBU] [N=K] [-dafzput] [slab-regexp]\n" + printf("slabinfo 4/15/2017. (c) 2007 sgi/(c) 2011 Linux Foundation/(c) 2017 Jump Trading LLC.\n\n" + "slabinfo [-aACDefhilMnosrStTvz1LXBU] [N=K] [-dafzput] [slab-regexp]\n" + "-a|--aliases Show aliases\n" "-A|--activity Most active slabs first\n" "-B|--Bytes Show size in bytes\n" + "-C|--ctor Show slabs with ctors\n" "-D|--display-active Switch line format to activity\n" "-e|--empty Show empty slabs\n" "-f|--first-alias Show first alias\n" @@ -121,6 +126,7 @@ static void usage(void) "-i|--inverted Inverted list\n" "-l|--slabs Show slabs\n" "-L|--Loss Sort by loss\n" + "-M|--movable Show caches that support movable objects\n" "-n|--numa Show NUMA information\n" "-N|--lines=K Show the first K slabs\n" "-o|--ops Show kmem_cache_ops\n" @@ -588,6 +594,12 @@ static void slabcache(struct slabinfo *s) if (show_empty && s->slabs) return; + if (show_ctor && !s->ctor) + return; + + if (show_movable && !s->movable) + return; + if (sort_loss == 0) store_size(size_str, slab_size(s)); else @@ -602,6 +614,10 @@ static void slabcache(struct slabinfo *s) *p++ = '*'; if (s->cache_dma) *p++ = 'd'; + if (s->ctor) + *p++ = 'C'; + if (s->movable) + *p++ = 'M'; if (s->hwcache_align) *p++ = 'A'; if (s->poison) @@ -636,7 +652,8 @@ static void slabcache(struct slabinfo *s) printf("%-21s %8ld %7d %15s %14s %4d %1d %3ld %3ld %s\n", s->name, s->objects, s->object_size, size_str, dist_str, s->objs_per_slab, s->order, - s->slabs ? (s->partial * 100) / s->slabs : 100, + s->slabs ? (s->partial * 100) / + (s->slabs * s->objs_per_slab) : 100, s->slabs ? (s->objects * s->object_size * 100) / (s->slabs * (page_size << s->order)) : 100, flags); @@ -1256,6 +1273,13 @@ static void read_slab_dir(void) slab->alloc_node_mismatch = get_obj("alloc_node_mismatch"); slab->deactivate_bypass = get_obj("deactivate_bypass"); chdir(".."); + if (read_slab_obj(slab, "ops")) { + if (strstr(buffer, "ctor :")) + slab->ctor = 1; + if (strstr(buffer, "migrate :")) + slab->movable = 1; + } + if (slab->name[0] == ':') alias_targets++; slab++; @@ -1332,6 +1356,8 @@ static void xtotals(void) } struct option opts[] = { + { "ctor", no_argument, NULL, 'C' }, + { "movable", no_argument, NULL, 'M' }, { "aliases", no_argument, NULL, 'a' }, { "activity", no_argument, NULL, 'A' }, { "debug", optional_argument, NULL, 'd' }, @@ -1367,7 +1393,7 @@ int main(int argc, char *argv[]) page_size = getpagesize(); - while ((c = getopt_long(argc, argv, "aAd::Defhil1noprstvzTSN:LXBU", + while ((c = getopt_long(argc, argv, "aACd::Defhil1MnoprstvzTSN:LXBU", opts, NULL)) != -1) switch (c) { case '1': @@ -1376,6 +1402,9 @@ int main(int argc, char *argv[]) case 'a': show_alias = 1; break; + case 'C': + show_ctor = 1; + break; case 'A': sort_active = 1; break; @@ -1399,6 +1428,9 @@ int main(int argc, char *argv[]) case 'i': show_inverted = 1; break; + case 'M': + show_movable = 1; + break; case 'n': show_numa = 1; break;