From patchwork Thu May 30 16:33:36 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Colin King X-Patchwork-Id: 10969053 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 4018C76 for ; Thu, 30 May 2019 16:33:41 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 304B528774 for ; Thu, 30 May 2019 16:33:41 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 2480328BF4; Thu, 30 May 2019 16:33:41 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.9 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id B1FD728774 for ; Thu, 30 May 2019 16:33:40 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 582836B026F; Thu, 30 May 2019 12:33:39 -0400 (EDT) Delivered-To: linux-mm-outgoing@kvack.org Received: by kanga.kvack.org (Postfix, from userid 40) id 532116B0271; Thu, 30 May 2019 12:33:39 -0400 (EDT) X-Original-To: int-list-linux-mm@kvack.org X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 422516B0274; Thu, 30 May 2019 12:33:39 -0400 (EDT) X-Original-To: linux-mm@kvack.org X-Delivered-To: linux-mm@kvack.org Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by kanga.kvack.org (Postfix) with ESMTP id 09D4E6B026F for ; Thu, 30 May 2019 12:33:39 -0400 (EDT) Received: by mail-wr1-f71.google.com with SMTP id u11so2714043wri.19 for ; Thu, 30 May 2019 09:33:38 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-original-authentication-results:x-gm-message-state:from:to:cc :subject:date:message-id:mime-version:content-transfer-encoding; bh=RSR4Y6uOXU6ci8DfFnO8AOJl33fqkg0nWOTwVJa4CRg=; b=RoLZS6+bd1VEskTkKoV9swCjikRqc2NTZWrFg+VVaeWECPGUmhplWPRxYueFhtxX4P r3Pib7q/76qNLBNqVOFzeFyTvF7OJSCcdRBxsccNxtSYMzHeSAh3CtMtE/7ZhN0Rduc6 tmAg4ZFKkttwgTApvuyBBTWvDczHa9TyXIzqnP9uDtcw6PZ1bDoT9nyFMH8SzTedUHIm iekri2Vm5Tfn07yQ9dE+L1QZAxbuFHqe7Q9YVEXinstRYqYaPJPbTSkFxKERO/tsD1yZ Mn3iJS+q1cOpfk9UAWQK7vu/YwGHAUwqSutqxXY+08eacdwa3BV6HbVe/B+V5BNadi5l Ju6Q== X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of colin.king@canonical.com designates 91.189.89.112 as permitted sender) smtp.mailfrom=colin.king@canonical.com; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=canonical.com X-Gm-Message-State: APjAAAXBDNXQkgapxvGoJD80yOo4V2+sXlJ6oVN3ivSquoEibdk9DFDa atJyNomK2DtRYgHvD8XsdiuNViluBPDnycgaPWCJEYhb2aFmy4IMwU4fX291FEPTyr76c9xfoo3 ZhYxLC/QJoHMS/gwyfslmoee8/nvP1YcpzIzLUpr5KFZx/xUJLclsSTsxc8jph/XQBA== X-Received: by 2002:adf:e705:: with SMTP id c5mr3322303wrm.270.1559234018385; Thu, 30 May 2019 09:33:38 -0700 (PDT) X-Google-Smtp-Source: APXvYqzWjDTjzC8REXpc40q05w5R0iie4zBTsNq/VIhexnE2jzW+oC/UDRUMLusuWfeYU6FIQ0DF X-Received: by 2002:adf:e705:: with SMTP id c5mr3322258wrm.270.1559234017477; Thu, 30 May 2019 09:33:37 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1559234017; cv=none; d=google.com; s=arc-20160816; b=0LDpug2khoutzvt4d1w993b4gEnx5a0uzlFGKQSh1nA7zYOa/xHTohueX76C32nnRI 2QlbYaEJLbk+RZ7+qbPlMRkI0LvIgwd9XA3lRl+5vAoIIWNELj33lVzuHtxWqF0Vy1fL FoMKpiUNWBFd61/tangTfZ/ie48/X2ISGzVVG4+z+1TZOUSAWJEYEW9lcRnu7WYFJJNI B5q4vkv/P6f5scycSy9dRq75uuGOjElLjFGqkTcpAQmVWhR/mPfoQ1L9jfvZrKZzjdvm /U14lDkEPEY0DBaiixw7ioxedGuyvqslkoNXdHrYPWq86qzV/7WO15qBcSnWEuBSVrdz 3/1g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from; bh=RSR4Y6uOXU6ci8DfFnO8AOJl33fqkg0nWOTwVJa4CRg=; b=XRiov6J2drE5mpEpQTg/z+SnfmaP679tfYLq4NZtyEVhDavPRhHw8byUQr/WLoxGu6 m/E/qo+wgAOpcknUzOpgX9MiusnOfdQRPBTwL1DJ3ZLMCEAWyK3XeBiKgreLppkdRyif 1tnTO9YTKirkpFfQOinkEaM0EWXH6oSioDh/Snqfnb2lGHmMLkaea8ovxmDPSLOmtyOa lcVHP2vbw8gw0lyf3VFXe4a4YsBgrW67I/lXbjtd+epmTfcyBQnqY6u201Vlz5aB0pDG 10/HuVvUpmFBlJmvuxZFOqxZWdJVm/FhbnKKKVKc3+XjqJOCRZC7d1p10/TFIw2KvJ/j xoyQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of colin.king@canonical.com designates 91.189.89.112 as permitted sender) smtp.mailfrom=colin.king@canonical.com; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=canonical.com Received: from youngberry.canonical.com (youngberry.canonical.com. [91.189.89.112]) by mx.google.com with ESMTPS id r1si2192208wrq.390.2019.05.30.09.33.37 for (version=TLS1 cipher=AES128-SHA bits=128/128); Thu, 30 May 2019 09:33:37 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of colin.king@canonical.com designates 91.189.89.112 as permitted sender) client-ip=91.189.89.112; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of colin.king@canonical.com designates 91.189.89.112 as permitted sender) smtp.mailfrom=colin.king@canonical.com; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=canonical.com Received: from 1.general.cking.uk.vpn ([10.172.193.212] helo=localhost) by youngberry.canonical.com with esmtpsa (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.76) (envelope-from ) id 1hWNzk-0003HE-Ds; Thu, 30 May 2019 16:33:36 +0000 From: Colin King To: Andrew Morton , Vitaly Wool , linux-mm@kvack.org Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH][next] z3fold: remove redundant assignment to bud Date: Thu, 30 May 2019 17:33:36 +0100 Message-Id: <20190530163336.5148-1-colin.king@canonical.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: X-Virus-Scanned: ClamAV using ClamSMTP From: Colin Ian King The variable bud is initialized with the value 'LAST' which is never read and bud is reassigned later on the return from the call to the function handle_to_buddy. This initialization is redundant and can be removed. Addresses-Coverity: ("Unused value") Signed-off-by: Colin Ian King --- mm/z3fold.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mm/z3fold.c b/mm/z3fold.c index 2bc3dbde6255..0a62bc293de4 100644 --- a/mm/z3fold.c +++ b/mm/z3fold.c @@ -1176,7 +1176,7 @@ static void z3fold_free(struct z3fold_pool *pool, unsigned long handle) { struct z3fold_header *zhdr; struct page *page; - enum buddy bud = LAST; /* initialize to !HEADLESS */ + enum buddy bud; zhdr = get_z3fold_header(handle);