From patchwork Tue Sep 3 20:05:03 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Joel Fernandes X-Patchwork-Id: 11128685 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id A17661398 for ; Tue, 3 Sep 2019 20:05:18 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 5B9B2207E0 for ; Tue, 3 Sep 2019 20:05:18 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=joelfernandes.org header.i=@joelfernandes.org header.b="Bc9wK/zb" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5B9B2207E0 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=joelfernandes.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 838976B0005; Tue, 3 Sep 2019 16:05:17 -0400 (EDT) Delivered-To: linux-mm-outgoing@kvack.org Received: by kanga.kvack.org (Postfix, from userid 40) id 7C1BB6B0006; Tue, 3 Sep 2019 16:05:17 -0400 (EDT) X-Original-To: int-list-linux-mm@kvack.org X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 68A106B0007; Tue, 3 Sep 2019 16:05:17 -0400 (EDT) X-Original-To: linux-mm@kvack.org X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0026.hostedemail.com [216.40.44.26]) by kanga.kvack.org (Postfix) with ESMTP id 3F7E26B0005 for ; Tue, 3 Sep 2019 16:05:17 -0400 (EDT) Received: from smtpin18.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with SMTP id DFFB9180AD805 for ; Tue, 3 Sep 2019 20:05:16 +0000 (UTC) X-FDA: 75894688632.18.hand28_10eba4d543602 X-Spam-Summary: 2,0,0,beb257d687f17a93,d41d8cd98f00b204,joel@joelfernandes.org,:linux-kernel@vger.kernel.org:joel@joelfernandes.org:timmurray@google.com:carmenjackson@google.com:mayankgupta@google.com:dancol@google.com:rostedt@goodmis.org:minchan@kernel.org:akpm@linux-foundation.org:kernel-team@android.com:aneesh.kumar@linux.ibm.com:dan.j.williams@intel.com:jglisse@redhat.com::willy@infradead.org:mhocko@suse.cz:rcampbell@nvidia.com:vbabka@suse.cz,RULES_HIT:41:355:379:541:800:960:973:988:989:1260:1311:1314:1345:1431:1434:1437:1515:1535:1544:1711:1730:1747:1777:1792:2393:2559:2562:2897:3138:3139:3140:3141:3142:3355:3865:3866:3867:3868:3870:3871:3872:3874:4118:4250:4321:4605:5007:6119:6120:6261:6653:6742:7875:7901:7903:8603:8957:10004:11026:11232:11473:11658:11914:12043:12291:12296:12297:12438:12517:12519:12555:12895:13221:13229:13846:13894:14181:14394:14721:14877:21080:21433:21444:21450:21451:21627:30034:30054:30070,0,RBL:209.85.210.196:@joelfernandes.org:.lbl8.mailshell.net-62 .14.0.10 X-HE-Tag: hand28_10eba4d543602 X-Filterd-Recvd-Size: 7117 Received: from mail-pf1-f196.google.com (mail-pf1-f196.google.com [209.85.210.196]) by imf19.hostedemail.com (Postfix) with ESMTP for ; Tue, 3 Sep 2019 20:05:16 +0000 (UTC) Received: by mail-pf1-f196.google.com with SMTP id q21so6517385pfn.11 for ; Tue, 03 Sep 2019 13:05:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=joelfernandes.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=29Qri/KXgUDgYfdOZ88fjJJOMZcARQYfy1B4reZQb8c=; b=Bc9wK/zblLGMuThMFStgTMR+Yuk5YZw/2OmzZKkNBCmEcFehCD/s4K1pbKKLrFQA05 mPmHzEIztfOvQcEOIKXnzaWKwPLSifbtOQKvCSKx1ILGYfhNrkkFERSz53zkUM9YgF5j 2Qzq8rXeRv4y/MaRj50LsMtZJS/kv+gom5Ifo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=29Qri/KXgUDgYfdOZ88fjJJOMZcARQYfy1B4reZQb8c=; b=Txc2O7dVxqBu0TOeZyVVAsan8SGrTna7deI7xGYsXip7TPCk5EWtPwSll099UpNdAD dj0QHljqPxUgndTf3vnF86a9Rsmn69W+WGd9FsX/LnBbsDBO0+RHnomKFN5TMUBRbmRc 3ObFnDt1G3qHEjW8ujECrv8LqdWYOcsrFW3yPtLy1UEoPWc7dv0bOkEX1eOQAkTMnBkC pGcCShp5G1Lgt9gkx1vkeabEpEaVbrKHRRN4xLUhpiC8dwJ5kImKvTEtHIdN2wu6GSJA bPCLTkM37aPDXZJ+1ARulsdD1zWwY6BuoBz0rgj/CGR9/Esmr2KS0hIhkArYgXMBBYM5 4YsA== X-Gm-Message-State: APjAAAWpsan0aXHNt2EJ6Mxgz0s5HvfrCX4qIrttdN748BqBgz/nEcMr LHtnWiUxRvHvjcav9SHcYhUL5g== X-Google-Smtp-Source: APXvYqzWwyyPykUJ8+f6u/buSmFd9exUPGkAK1eD0pBWdCTcvskP3nkPl9BvPjdTnUwebYQ7ayLfuA== X-Received: by 2002:a17:90a:d990:: with SMTP id d16mr1009540pjv.55.1567541114848; Tue, 03 Sep 2019 13:05:14 -0700 (PDT) Received: from joelaf.cam.corp.google.com ([2620:15c:6:12:9c46:e0da:efbf:69cc]) by smtp.gmail.com with ESMTPSA id k36sm16606308pgl.42.2019.09.03.13.05.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 Sep 2019 13:05:14 -0700 (PDT) From: "Joel Fernandes (Google)" To: linux-kernel@vger.kernel.org Cc: "Joel Fernandes (Google)" , Tim Murray , carmenjackson@google.com, mayankgupta@google.com, dancol@google.com, rostedt@goodmis.org, minchan@kernel.org, akpm@linux-foundation.org, kernel-team@android.com, "Aneesh Kumar K.V" , Dan Williams , "Jerome Glisse" , linux-mm@kvack.org, Matthew Wilcox , Michal Hocko , Ralph Campbell , Vlastimil Babka Subject: [PATCH] mm: emit tracepoint when RSS changes by threshold Date: Tue, 3 Sep 2019 16:05:03 -0400 Message-Id: <20190903200503.147973-1-joel@joelfernandes.org> X-Mailer: git-send-email 2.23.0.187.g17f5b7556c-goog MIME-Version: 1.0 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Useful to track how RSS is changing per TGID. Several Android teams have been using this patch in various kernel trees for half a year now. Many reported to me it is really useful. Initial patch developed by Tim Murray. Changes I made from original patch: o Prevent any additional space consumed by mm_struct. o Keep overhead low by checking if tracing is enabled. o Add some noise reduction and lower overhead by emitting only on threshold changes. Co-developed-by: Tim Murray Signed-off-by: Tim Murray Signed-off-by: Joel Fernandes (Google) --- Cc: carmenjackson@google.com Cc: mayankgupta@google.com Cc: dancol@google.com Cc: rostedt@goodmis.org Cc: minchan@kernel.org Cc: akpm@linux-foundation.org Cc: kernel-team@android.com include/linux/mm.h | 14 +++++++++++--- include/trace/events/kmem.h | 21 +++++++++++++++++++++ mm/memory.c | 20 ++++++++++++++++++++ 3 files changed, 52 insertions(+), 3 deletions(-) diff --git a/include/linux/mm.h b/include/linux/mm.h index 0334ca97c584..823aaf759bdb 100644 --- a/include/linux/mm.h +++ b/include/linux/mm.h @@ -1671,19 +1671,27 @@ static inline unsigned long get_mm_counter(struct mm_struct *mm, int member) return (unsigned long)val; } +void mm_trace_rss_stat(int member, long count, long value); + static inline void add_mm_counter(struct mm_struct *mm, int member, long value) { - atomic_long_add(value, &mm->rss_stat.count[member]); + long count = atomic_long_add_return(value, &mm->rss_stat.count[member]); + + mm_trace_rss_stat(member, count, value); } static inline void inc_mm_counter(struct mm_struct *mm, int member) { - atomic_long_inc(&mm->rss_stat.count[member]); + long count = atomic_long_inc_return(&mm->rss_stat.count[member]); + + mm_trace_rss_stat(member, count, 1); } static inline void dec_mm_counter(struct mm_struct *mm, int member) { - atomic_long_dec(&mm->rss_stat.count[member]); + long count = atomic_long_dec_return(&mm->rss_stat.count[member]); + + mm_trace_rss_stat(member, count, -1); } /* Optimized variant when page is already known not to be PageAnon */ diff --git a/include/trace/events/kmem.h b/include/trace/events/kmem.h index eb57e3037deb..8b88e04fafbf 100644 --- a/include/trace/events/kmem.h +++ b/include/trace/events/kmem.h @@ -315,6 +315,27 @@ TRACE_EVENT(mm_page_alloc_extfrag, __entry->change_ownership) ); +TRACE_EVENT(rss_stat, + + TP_PROTO(int member, + long count), + + TP_ARGS(member, count), + + TP_STRUCT__entry( + __field(int, member) + __field(long, size) + ), + + TP_fast_assign( + __entry->member = member; + __entry->size = (count << PAGE_SHIFT); + ), + + TP_printk("member=%d size=%ldB", + __entry->member, + __entry->size) + ); #endif /* _TRACE_KMEM_H */ /* This part must be outside protection */ diff --git a/mm/memory.c b/mm/memory.c index e2bb51b6242e..9d81322c24a3 100644 --- a/mm/memory.c +++ b/mm/memory.c @@ -72,6 +72,8 @@ #include #include +#include + #include #include #include @@ -140,6 +142,24 @@ static int __init init_zero_pfn(void) } core_initcall(init_zero_pfn); +/* + * This threshold is the boundary in the value space, that the counter has to + * advance before we trace it. Should be a power of 2. It is to reduce unwanted + * trace overhead. The counter is in units of number of pages. + */ +#define TRACE_MM_COUNTER_THRESHOLD 128 + +void mm_trace_rss_stat(int member, long count, long value) +{ + long thresh_mask = ~(TRACE_MM_COUNTER_THRESHOLD - 1); + + if (!trace_rss_stat_enabled()) + return; + + /* Threshold roll-over, trace it */ + if ((count & thresh_mask) != ((count - value) & thresh_mask)) + trace_rss_stat(member, count); +} #if defined(SPLIT_RSS_COUNTING)