From patchwork Thu Oct 10 13:40:57 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: =?utf-8?q?Thomas_Hellstr=C3=B6m_=28Intel=29?= X-Patchwork-Id: 11183637 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 0D8BA112B for ; Thu, 10 Oct 2019 13:41:33 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id CED2A2067B for ; Thu, 10 Oct 2019 13:41:32 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=shipmail.org header.i=@shipmail.org header.b="XJ9AzqJr" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CED2A2067B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=shipmail.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id C8D346B0007; Thu, 10 Oct 2019 09:41:26 -0400 (EDT) Delivered-To: linux-mm-outgoing@kvack.org Received: by kanga.kvack.org (Postfix, from userid 40) id C3C6E8E0003; Thu, 10 Oct 2019 09:41:26 -0400 (EDT) X-Original-To: int-list-linux-mm@kvack.org X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AB9FB6B000C; Thu, 10 Oct 2019 09:41:26 -0400 (EDT) X-Original-To: linux-mm@kvack.org X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0061.hostedemail.com [216.40.44.61]) by kanga.kvack.org (Postfix) with ESMTP id 70E0A6B0007 for ; Thu, 10 Oct 2019 09:41:26 -0400 (EDT) Received: from smtpin06.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with SMTP id 02D87180AD804 for ; Thu, 10 Oct 2019 13:41:26 +0000 (UTC) X-FDA: 76027986972.06.front45_80d9047c9993d X-Spam-Summary: 2,0,0,3895400030604bb2,d41d8cd98f00b204,thomas_os@shipmail.org,:linux-kernel@vger.kernel.org::torvalds@linux-foundation.org:kirill@shutemov.name:thellstrom@vmware.com,RULES_HIT:41:355:379:541:800:960:973:988:989:1260:1261:1311:1314:1345:1359:1437:1515:1534:1542:1676:1711:1730:1747:1777:1792:2393:2559:2562:2898:3138:3139:3140:3141:3142:3353:3865:3867:3868:3870:3871:3872:3873:3874:4321:4398:4605:5007:6120:6261:6653:7576:10004:11026:11473:11658:11914:12043:12048:12296:12297:12517:12519:12555:12679:12895:12986:13255:13894:14096:14181:14721:21080:21212:21451:21627:21939:30003:30012:30051:30054:30070,0,RBL:79.136.2.41:@shipmail.org:.lbl8.mailshell.net-62.2.203.100 64.100.201.201,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fp,MSBL:0,DNSBL:neutral,Custom_rules:0:0:0,LFtime:24,LUA_SUMMARY:none X-HE-Tag: front45_80d9047c9993d X-Filterd-Recvd-Size: 4535 Received: from pio-pvt-msa2.bahnhof.se (pio-pvt-msa2.bahnhof.se [79.136.2.41]) by imf35.hostedemail.com (Postfix) with ESMTP for ; Thu, 10 Oct 2019 13:41:25 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by pio-pvt-msa2.bahnhof.se (Postfix) with ESMTP id A5BEB3F32B; Thu, 10 Oct 2019 15:41:18 +0200 (CEST) Authentication-Results: pio-pvt-msa2.bahnhof.se; dkim=pass (1024-bit key; unprotected) header.d=shipmail.org header.i=@shipmail.org header.b=XJ9AzqJr; dkim-atps=neutral X-Virus-Scanned: Debian amavisd-new at bahnhof.se X-Spam-Flag: NO X-Spam-Score: -2.099 X-Spam-Level: X-Spam-Status: No, score=-2.099 tagged_above=-999 required=6.31 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no Received: from pio-pvt-msa2.bahnhof.se ([127.0.0.1]) by localhost (pio-pvt-msa2.bahnhof.se [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id PvCIW3Nwcj92; Thu, 10 Oct 2019 15:41:17 +0200 (CEST) Received: from mail1.shipmail.org (h-205-35.A357.priv.bahnhof.se [155.4.205.35]) (Authenticated sender: mb878879) by pio-pvt-msa2.bahnhof.se (Postfix) with ESMTPA id 9D2A63F260; Thu, 10 Oct 2019 15:41:17 +0200 (CEST) Received: from localhost.localdomain.localdomain (h-205-35.A357.priv.bahnhof.se [155.4.205.35]) by mail1.shipmail.org (Postfix) with ESMTPSA id 658F43610CE; Thu, 10 Oct 2019 15:41:17 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=shipmail.org; s=mail; t=1570714877; bh=I43d2BTecvoJPXAN1AxjOTn1uEK1Ks5L6V9rF+kVywU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=XJ9AzqJrkAVMR4RNVKFniF4BTgPqdLa+jiit+c4NumrcPH91KNui0QgSnvzaT0h1b Enxl+sJfziYIHP/L28Sv0vj8uxgmRM2AahsWxj9JoVctrzhjNVkJE+FO9HLi2E7dhY lXbUSY8Vh8b7YI3Shl123a996WCXuLCV5pRMl4V0= From: =?utf-8?q?Thomas_Hellstr=C3=B6m_=28VMware=29?= To: linux-kernel@vger.kernel.org, linux-mm@kvack.org, torvalds@linux-foundation.org, kirill@shutemov.name Cc: Thomas Hellstrom Subject: [RFC PATCH 3/4] mm: pagewalk: Disallow user positive callback return values and use them for walk control Date: Thu, 10 Oct 2019 15:40:57 +0200 Message-Id: <20191010134058.11949-4-thomas_os@shipmail.org> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20191010134058.11949-1-thomas_os@shipmail.org> References: <20191010134058.11949-1-thomas_os@shipmail.org> MIME-Version: 1.0 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000001, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: From: Linus Torvalds When we have both a pmd_entry() and a pte_entry() callback, in some siutaions it is desirable not to traverse the pte level. Reserve positive callback return values for walk control and define a return value PAGE_WALK_CONTINUE that means skip lower level traversal and continue the walk. Co-developed-by: Thomas Hellstrom Signed-off-by: Thomas Hellstrom --- include/linux/pagewalk.h | 6 ++++++ mm/pagewalk.c | 9 ++++++--- 2 files changed, 12 insertions(+), 3 deletions(-) diff --git a/include/linux/pagewalk.h b/include/linux/pagewalk.h index 6ec82e92c87f..d9e5d1927315 100644 --- a/include/linux/pagewalk.h +++ b/include/linux/pagewalk.h @@ -4,6 +4,12 @@ #include +/* + * pmd_entry() Return code meaning skip to next entry. + * Don't look for lower levels + */ +#define PAGE_WALK_CONTINUE 1 + struct mm_walk; /** diff --git a/mm/pagewalk.c b/mm/pagewalk.c index ea0b9e606ad1..d2483d432fda 100644 --- a/mm/pagewalk.c +++ b/mm/pagewalk.c @@ -52,8 +52,12 @@ static int walk_pmd_range(pud_t *pud, unsigned long addr, unsigned long end, */ if (ops->pmd_entry) err = ops->pmd_entry(pmd, addr, next, walk); - if (err) + if (err < 0) break; + if (err == PAGE_WALK_CONTINUE) { + err = 0; + continue; + } /* * Check this here so we only break down trans_huge @@ -291,8 +295,7 @@ static int __walk_page_range(unsigned long start, unsigned long end, * * - 0 : succeeded to handle the current entry, and if you don't reach the * end address yet, continue to walk. - * - >0 : succeeded to handle the current entry, and return to the caller - * with caller specific value. + * - >0 : Reserved for walk control. Use only PAGE_WALK_XX values. * - <0 : failed to handle the current entry, and return to the caller * with error code. *