diff mbox series

[rc] mm/mmu_notifiers: use the right return code for WARN_ON

Message ID 20191025175502.GA31127@ziepe.ca (mailing list archive)
State New, archived
Headers show
Series [rc] mm/mmu_notifiers: use the right return code for WARN_ON | expand

Commit Message

Jason Gunthorpe Oct. 25, 2019, 5:55 p.m. UTC 
The return code from the op callback is actually in _ret, while the
WARN_ON was checking ret which causes it to misfire.

Fixes: 8402ce61bec2 ("mm/mmu_notifiers: check if mmu notifier callbacks are allowed to fail")
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
Signed-off-by: Jason Gunthorpe <jgg@mellanox.com>
---
 mm/mmu_notifier.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Andrew, could you forward this to Linus in the -rc stream? This is a
new regression in v5.4-rc1, thanks
diff mbox series

Patch

diff --git a/mm/mmu_notifier.c b/mm/mmu_notifier.c
index 7fde88695f35d6..9a889e456168bc 100644
--- a/mm/mmu_notifier.c
+++ b/mm/mmu_notifier.c
@@ -180,7 +180,7 @@  int __mmu_notifier_invalidate_range_start(struct mmu_notifier_range *range)
 					mn->ops->invalidate_range_start, _ret,
 					!mmu_notifier_range_blockable(range) ? "non-" : "");
 				WARN_ON(mmu_notifier_range_blockable(range) ||
-					ret != -EAGAIN);
+					_ret != -EAGAIN);
 				ret = _ret;
 			}
 		}