[06/17] mm/mmu_notifiers: use the right return code for WARN_ON

Commit Message

Andrew Morton Nov. 6, 2019, 5:16 a.m. UTC

From: Jason Gunthorpe <[e-mail]>
Subject: mm/mmu_notifiers: use the right return code for WARN_ON

The return code from the op callback is actually in _ret, while the
WARN_ON was checking ret which causes it to misfire.

Link: http://lkml.kernel.org/r/[e-mail]
Fixes: 8402ce61bec2 ("mm/mmu_notifiers: check if mmu notifier callbacks are allowed to fail")
Signed-off-by: Jason Gunthorpe <[e-mail]>
Reviewed-by: Andrew Morton <[e-mail]>
Cc: Daniel Vetter <[e-mail]>
Signed-off-by: Andrew Morton <[e-mail]>
---

 mm/mmu_notifier.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Patch

--- a/mm/mmu_notifier.c~mm-mmu_notifiers-use-the-right-return-code-for-warn_on
+++ a/mm/mmu_notifier.c
@@ -180,7 +180,7 @@  int __mmu_notifier_invalidate_range_star
 					mn->ops->invalidate_range_start, _ret,
 					!mmu_notifier_range_blockable(range) ? "non-" : "");
 				WARN_ON(mmu_notifier_range_blockable(range) ||
-					ret != -EAGAIN);
+					_ret != -EAGAIN);
 				ret = _ret;
 			}
 		}