| Message ID | 20191111225559.19657-1-rcampbell@nvidia.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [v2] mm/debug: __dump_page() prints an extra line | expand |
On Mon, Nov 11, 2019 at 02:55:59PM -0800, Ralph Campbell wrote: > When dumping struct page information, __dump_page() prints the page type > with a trailing blank followed by the page flags on a separate line: > > anon > flags: 0x100000000090034(uptodate|lru|active|head|swapbacked) > > Fix this by using pr_cont() instead of pr_warn() to get a single line: > > anon flags: 0x100000000090034(uptodate|lru|active|head|swapbacked) > > Signed-off-by: Ralph Campbell <rcampbell@nvidia.com> Reviewed-by: Jérôme Glisse <jglisse@redhat.com> > --- > > v1 -> v2: > Oops, fix the subject line. > > mm/debug.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/debug.c b/mm/debug.c > index 8345bb6e4769..752c78721ea0 100644 > --- a/mm/debug.c > +++ b/mm/debug.c > @@ -87,7 +87,7 @@ void __dump_page(struct page *page, const char *reason) > } > BUILD_BUG_ON(ARRAY_SIZE(pageflag_names) != __NR_PAGEFLAGS + 1); > > - pr_warn("flags: %#lx(%pGp)\n", page->flags, &page->flags); > + pr_cont("flags: %#lx(%pGp)\n", page->flags, &page->flags); > > hex_only: > print_hex_dump(KERN_WARNING, "raw: ", DUMP_PREFIX_NONE, 32, > -- > 2.20.1 > >
diff --git a/mm/debug.c b/mm/debug.c index 8345bb6e4769..752c78721ea0 100644 --- a/mm/debug.c +++ b/mm/debug.c @@ -87,7 +87,7 @@ void __dump_page(struct page *page, const char *reason) } BUILD_BUG_ON(ARRAY_SIZE(pageflag_names) != __NR_PAGEFLAGS + 1); - pr_warn("flags: %#lx(%pGp)\n", page->flags, &page->flags); + pr_cont("flags: %#lx(%pGp)\n", page->flags, &page->flags); hex_only: print_hex_dump(KERN_WARNING, "raw: ", DUMP_PREFIX_NONE, 32,
When dumping struct page information, __dump_page() prints the page type with a trailing blank followed by the page flags on a separate line: anon flags: 0x100000000090034(uptodate|lru|active|head|swapbacked) Fix this by using pr_cont() instead of pr_warn() to get a single line: anon flags: 0x100000000090034(uptodate|lru|active|head|swapbacked) Signed-off-by: Ralph Campbell <rcampbell@nvidia.com> --- v1 -> v2: Oops, fix the subject line. mm/debug.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)