From patchwork Sun Dec 1 01:50:46 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrew Morton X-Patchwork-Id: 11268239 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 4719A921 for ; Sun, 1 Dec 2019 01:50:50 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 133AA2086A for ; Sun, 1 Dec 2019 01:50:50 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="N+CZlBWK" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 133AA2086A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id DC2E86B0294; Sat, 30 Nov 2019 20:50:48 -0500 (EST) Delivered-To: linux-mm-outgoing@kvack.org Received: by kanga.kvack.org (Postfix, from userid 40) id D73426B0296; Sat, 30 Nov 2019 20:50:48 -0500 (EST) X-Original-To: int-list-linux-mm@kvack.org X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C88DD6B0297; Sat, 30 Nov 2019 20:50:48 -0500 (EST) X-Original-To: linux-mm@kvack.org X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0184.hostedemail.com [216.40.44.184]) by kanga.kvack.org (Postfix) with ESMTP id AF04A6B0294 for ; Sat, 30 Nov 2019 20:50:48 -0500 (EST) Received: from smtpin25.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with SMTP id 658E8180AD817 for ; Sun, 1 Dec 2019 01:50:48 +0000 (UTC) X-FDA: 76214893776.25.elbow50_701eec72f300 X-Spam-Summary: 2,0,0,b1ac14644b531569,d41d8cd98f00b204,akpm@linux-foundation.org,:akpm@linux-foundation.org:hch@infradead.org::mgorman@techsingularity.net:mm-commits@vger.kernel.org:osalvador@suse.de:richardw.yang@linux.intel.com:torvalds@linux-foundation.org:vbabka@suse.cz:willy@infradead.org,RULES_HIT:41:355:379:800:960:967:968:973:988:989:1260:1263:1345:1381:1431:1437:1534:1541:1711:1730:1747:1777:1792:2198:2199:2393:2525:2559:2563:2682:2685:2859:2902:2933:2937:2939:2942:2945:2947:2951:2954:3022:3138:3139:3140:3141:3142:3352:3865:3866:3867:3870:3871:3874:3934:3936:3938:3941:3944:3947:3950:3953:3956:3959:4321:5007:6261:6653:7576:8599:9025:9545:9592:10004:10913:11026:11658:11914:12043:12048:12296:12297:12517:12519:12555:12679:12783:12986:13069:13161:13229:13311:13357:14096:14181:14384:14721:14849:21063:21080:21451:21611:21627:21939:30054,0,RBL:error,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fp,MSBL:0,DNSBL:neutral,Custom_rules:0:0:0,LFti me:3,LUA X-HE-Tag: elbow50_701eec72f300 X-Filterd-Recvd-Size: 2867 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf35.hostedemail.com (Postfix) with ESMTP for ; Sun, 1 Dec 2019 01:50:48 +0000 (UTC) Received: from localhost.localdomain (c-73-231-172-41.hsd1.ca.comcast.net [73.231.172.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 1F2C8208E4; Sun, 1 Dec 2019 01:50:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1575165047; bh=WYPcX9zTkbpFT93PVsZfKpohbxeZdoKh1Ucj0kHGlvA=; h=Date:From:To:Subject:From; b=N+CZlBWKmkfy9mHUdkbC7p2qnGffNN/qbOy2dK3uzyUXlecyL1IBRdoT4PxSzp8O8 WMJBGzLU4djZn/hzibgxdm9SUIgPbWwdURu+bB4t7zwcKuVwzjVFakzCdeE010w7SW 4Nr1o1IZCTSWvFYoiu7l9rTbQizeyR7IcJbrtkpA= Date: Sat, 30 Nov 2019 17:50:46 -0800 From: akpm@linux-foundation.org To: akpm@linux-foundation.org, hch@infradead.org, linux-mm@kvack.org, mgorman@techsingularity.net, mm-commits@vger.kernel.org, osalvador@suse.de, richardw.yang@linux.intel.com, torvalds@linux-foundation.org, vbabka@suse.cz, willy@infradead.org Subject: [patch 031/158] mm/mmap.c: __vma_unlink_prev() is not necessary now Message-ID: <20191201015046.7koFRsYYb%akpm@linux-foundation.org> User-Agent: s-nail v14.8.16 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: From: Wei Yang Subject: mm/mmap.c: __vma_unlink_prev() is not necessary now The third parameter of __vma_unlink_common() could differentiate these two types. __vma_unlink_prev() is not necessary now. Link: http://lkml.kernel.org/r/20191006012636.31521-2-richardw.yang@linux.intel.com Signed-off-by: Wei Yang Cc: Christoph Hellwig Cc: Matthew Wilcox (Oracle) Cc: Mel Gorman Cc: Oscar Salvador Cc: Vlastimil Babka Signed-off-by: Andrew Morton --- mm/mmap.c | 9 +-------- 1 file changed, 1 insertion(+), 8 deletions(-) --- a/mm/mmap.c~mm-mmapc-__vma_unlink_prev-is-not-necessary-now +++ a/mm/mmap.c @@ -702,13 +702,6 @@ static __always_inline void __vma_unlink vmacache_invalidate(mm); } -static inline void __vma_unlink_prev(struct mm_struct *mm, - struct vm_area_struct *vma, - struct vm_area_struct *prev) -{ - __vma_unlink_common(mm, vma, vma); -} - /* * We cannot adjust vm_start, vm_end, vm_pgoff fields of a vma that * is already present in an i_mmap tree without adjusting the tree. @@ -881,7 +874,7 @@ again: * us to remove next before dropping the locks. */ if (remove_next != 3) - __vma_unlink_prev(mm, next, vma); + __vma_unlink_common(mm, next, next); else /* * vma is not before next if they've been