| Message ID | 20200303202054.gsosv7fsx2ma3cic@linutronix.de (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [1/2] =?UTF-8?q?mm/compaction:=20Really=20limit=20compact?= =?UTF-8?q?=5Funevictable=5Fallowed=20to=200=E2=80=A61?= | expand |
On 3/3/20 9:20 PM, Sebastian Andrzej Siewior wrote: > The proc file `compact_unevictable_allowed' should allow 0 and 1 only, > the `extra*' attribues have been set properly but without > proc_dointvec_minmax() as the `proc_handler' the limit will not be > enforced. > > Use proc_dointvec_minmax() as the `proc_handler' to enfoce the valid > specified range. > > Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de> Acked-by: Vlastimil Babka <vbabka@suse.cz> > --- > kernel/sysctl.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/kernel/sysctl.c b/kernel/sysctl.c > index ad5b88a53c5a8..982203101f961 100644 > --- a/kernel/sysctl.c > +++ b/kernel/sysctl.c > @@ -1484,7 +1484,7 @@ static struct ctl_table vm_table[] = { > .data = &sysctl_compact_unevictable_allowed, > .maxlen = sizeof(int), > .mode = 0644, > - .proc_handler = proc_dointvec, > + .proc_handler = proc_dointvec_minmax, > .extra1 = SYSCTL_ZERO, > .extra2 = SYSCTL_ONE, > }, >
diff --git a/kernel/sysctl.c b/kernel/sysctl.c index ad5b88a53c5a8..982203101f961 100644 --- a/kernel/sysctl.c +++ b/kernel/sysctl.c @@ -1484,7 +1484,7 @@ static struct ctl_table vm_table[] = { .data = &sysctl_compact_unevictable_allowed, .maxlen = sizeof(int), .mode = 0644, - .proc_handler = proc_dointvec, + .proc_handler = proc_dointvec_minmax, .extra1 = SYSCTL_ZERO, .extra2 = SYSCTL_ONE, },
The proc file `compact_unevictable_allowed' should allow 0 and 1 only, the `extra*' attribues have been set properly but without proc_dointvec_minmax() as the `proc_handler' the limit will not be enforced. Use proc_dointvec_minmax() as the `proc_handler' to enfoce the valid specified range. Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de> --- kernel/sysctl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)