From patchwork Mon Mar 30 02:32:38 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Joel Fernandes X-Patchwork-Id: 11464479 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 98A641392 for ; Mon, 30 Mar 2020 02:33:53 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 5B5892078B for ; Mon, 30 Mar 2020 02:33:53 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=joelfernandes.org header.i=@joelfernandes.org header.b="eAqEJ2hy" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5B5892078B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=joelfernandes.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 6F49E6B0072; Sun, 29 Mar 2020 22:33:40 -0400 (EDT) Delivered-To: linux-mm-outgoing@kvack.org Received: by kanga.kvack.org (Postfix, from userid 40) id 6A7B76B0073; Sun, 29 Mar 2020 22:33:40 -0400 (EDT) X-Original-To: int-list-linux-mm@kvack.org X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 51F176B0074; Sun, 29 Mar 2020 22:33:40 -0400 (EDT) X-Original-To: linux-mm@kvack.org X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0224.hostedemail.com [216.40.44.224]) by kanga.kvack.org (Postfix) with ESMTP id 3A0966B0072 for ; Sun, 29 Mar 2020 22:33:40 -0400 (EDT) Received: from smtpin30.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 474834DB3 for ; Mon, 30 Mar 2020 02:33:40 +0000 (UTC) X-FDA: 76650457800.30.boys02_5a3841d45f743 X-Spam-Summary: 2,0,0,5fcc62a14da95d71,d41d8cd98f00b204,joel@joelfernandes.org,,RULES_HIT:41:355:379:541:800:960:966:973:988:989:1260:1311:1314:1345:1359:1437:1515:1534:1541:1711:1730:1747:1777:1792:2196:2199:2393:2559:2562:2914:3138:3139:3140:3141:3142:3352:3865:3868:3870:3872:4321:4385:5007:6261:6653:6742:10004:11026:11658:11914:12043:12296:12297:12517:12519:12555:12895:13069:13311:13357:13894:14096:14384:14394:14721:21080:21444:21627:21740:30054,0,RBL:209.85.222.193:@joelfernandes.org:.lbl8.mailshell.net-66.100.201.201 62.2.0.100,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fp,MSBL:0,DNSBL:neutral,Custom_rules:0:0:0,LFtime:24,LUA_SUMMARY:none X-HE-Tag: boys02_5a3841d45f743 X-Filterd-Recvd-Size: 4223 Received: from mail-qk1-f193.google.com (mail-qk1-f193.google.com [209.85.222.193]) by imf17.hostedemail.com (Postfix) with ESMTP for ; Mon, 30 Mar 2020 02:33:39 +0000 (UTC) Received: by mail-qk1-f193.google.com with SMTP id d11so17543938qko.3 for ; Sun, 29 Mar 2020 19:33:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=joelfernandes.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=VhRXFX915ZZjf6qHI5PrZD8T8+tPOI/Cg2isptxenk4=; b=eAqEJ2hyTMW80nl2AFCJp8deCuE81RBBTLR7Vl6BziuMKTXwko1qIyEOcelWccQQkl O5/4QbRDcxFSa30uXFamCDL0znuq14BuHKIBCF9g0pIf/GCsLfXA1UF2HikN7r+Yka5t f1hMLlRKNr/Ngcmd9WJd2kkyL8wzZaz0204+w= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=VhRXFX915ZZjf6qHI5PrZD8T8+tPOI/Cg2isptxenk4=; b=mJOXlwxvKT/wc41QgcTw+6LDZzN54+UTzHzNfLwRpdq1l+u2e+MqPlKyuWAUmWaYgz 6z9QrJ/dQAKgGa7Zw9A8A2d945xvEryDN5FCezX5vmTTDT3Hpx0xF/grXjbpBhmErNdD 93+Q3oi6FEdG02stzl6OQ4Qykk+MsH46xk49cVfReaR2SsXXd70A4NmJVA8j0n/+AznC nWvTUV1FDo+r/wdI6xkXG4Eq/Gb9LDYi/zKx/iK/n0f2N8Ju92Morjf86YKg+4d4cB8W 7JeQh3pC0vRNb/7TVv89TbS9dRKYavaFOFF//umE3Z4Sq6LqsqXOf8Xv+WRyyRcnnBzQ 9Jmg== X-Gm-Message-State: ANhLgQ1lNeTk7ghuOyBq0y30KRRo1V8jsihielvNkmu8aUwLoRBDnqzY 2wxRav8tDx02nry+86+GCmLEQw== X-Google-Smtp-Source: ADFU+vvqvHDIo+I+fVPksGXLy4Vwf61hpGLUBlvFZuL8EfaZx88zhM/5jOyQn340v+Wi0oZQiZ1hBw== X-Received: by 2002:a37:87c7:: with SMTP id j190mr9957429qkd.66.1585535619052; Sun, 29 Mar 2020 19:33:39 -0700 (PDT) Received: from joelaf.cam.corp.google.com ([2620:15c:6:12:9c46:e0da:efbf:69cc]) by smtp.gmail.com with ESMTPSA id q15sm10030625qtj.83.2020.03.29.19.33.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 29 Mar 2020 19:33:38 -0700 (PDT) From: "Joel Fernandes (Google)" To: linux-kernel@vger.kernel.org Cc: "Joel Fernandes (Google)" , Andrew Morton , Ingo Molnar , Josh Triplett , Lai Jiangshan , linux-mm@kvack.org, Mathieu Desnoyers , "Paul E. McKenney" , "Rafael J. Wysocki" , rcu@vger.kernel.org, Steven Rostedt , "Uladzislau Rezki (Sony)" Subject: [PATCH 08/18] rcu/tree: Clarify emergency path comment better Date: Sun, 29 Mar 2020 22:32:38 -0400 Message-Id: <20200330023248.164994-9-joel@joelfernandes.org> X-Mailer: git-send-email 2.26.0.rc2.310.g2932bb562d-goog In-Reply-To: <20200330023248.164994-1-joel@joelfernandes.org> References: <20200330023248.164994-1-joel@joelfernandes.org> MIME-Version: 1.0 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Clarify emergency path comment better in kfree_rcu(). Signed-off-by: Joel Fernandes (Google) --- kernel/rcu/tree.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/kernel/rcu/tree.c b/kernel/rcu/tree.c index 95d1f5e20d5ec..8dfa4b32e4d00 100644 --- a/kernel/rcu/tree.c +++ b/kernel/rcu/tree.c @@ -2924,9 +2924,10 @@ static void kfree_rcu_work(struct work_struct *work) } /* - * vmalloc() pointers end up here also emergency case. It can - * happen under low memory condition when an allocation gets - * failed, so the "bulk" path can not be temporary maintained. + * We can end up here either with 1) vmalloc() pointers or 2) were low + * on memory and could not allocate a bulk array. It can happen under + * low memory condition when an allocation gets failed, so the "bulk" + * path can not be temporarly used. */ for (; head; head = next) { unsigned long offset = (unsigned long)head->func;