From patchwork Tue Apr 28 20:58:42 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Uladzislau Rezki X-Patchwork-Id: 11515557 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 007801392 for ; Tue, 28 Apr 2020 20:59:37 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id C1CCD21744 for ; Tue, 28 Apr 2020 20:59:36 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="OomEXmvE" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C1CCD21744 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 4C8DC8E0001; Tue, 28 Apr 2020 16:59:34 -0400 (EDT) Delivered-To: linux-mm-outgoing@kvack.org Received: by kanga.kvack.org (Postfix, from userid 40) id 371438E0009; Tue, 28 Apr 2020 16:59:34 -0400 (EDT) X-Original-To: int-list-linux-mm@kvack.org X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2155E8E0001; Tue, 28 Apr 2020 16:59:34 -0400 (EDT) X-Original-To: linux-mm@kvack.org X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0083.hostedemail.com [216.40.44.83]) by kanga.kvack.org (Postfix) with ESMTP id 038828E0007 for ; Tue, 28 Apr 2020 16:59:33 -0400 (EDT) Received: from smtpin06.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 81DC12493 for ; Tue, 28 Apr 2020 20:59:33 +0000 (UTC) X-FDA: 76758479826.06.train47_5367c011b3055 X-Spam-Summary: 2,0,0,1dbae68d9f68a32f,d41d8cd98f00b204,urezki@gmail.com,,RULES_HIT:41:355:379:541:800:960:966:973:988:989:1260:1311:1314:1345:1359:1437:1515:1535:1542:1711:1730:1747:1777:1792:2194:2196:2199:2200:2393:2559:2562:3138:3139:3140:3141:3142:3354:3865:3866:3867:3870:3871:3872:4250:4321:4385:5007:6117:6119:6261:6653:7514:7576:7903:8660:9040:9413:10004:11026:11473:11658:11914:12043:12294:12296:12297:12438:12517:12519:12555:12895:13148:13230:13894:14181:14394:14687:14721:21080:21444:21451:21627:21666:21740:21990:30012:30054,0,RBL:209.85.208.193:@gmail.com:.lbl8.mailshell.net-66.100.201.100 62.18.0.100,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fp,MSBL:0,DNSBL:neutral,Custom_rules:0:0:0,LFtime:24,LUA_SUMMARY:none X-HE-Tag: train47_5367c011b3055 X-Filterd-Recvd-Size: 5954 Received: from mail-lj1-f193.google.com (mail-lj1-f193.google.com [209.85.208.193]) by imf45.hostedemail.com (Postfix) with ESMTP for ; Tue, 28 Apr 2020 20:59:33 +0000 (UTC) Received: by mail-lj1-f193.google.com with SMTP id g4so256193ljl.2 for ; Tue, 28 Apr 2020 13:59:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=tNVlKJMZgR8fQGfjNMGlZb0HEXGPqeGS+UCAapReQEQ=; b=OomEXmvEimxM1FQU4RZxUQQ6SUm/0rWP04XnM3tyK2N2EVh5hEe+B/wMbpSMFBO2a9 zfvlE9oG69hOjkwDFfbhn04b0dqQhaPQy92gtamKdDddFXpGJDjR9LDP+4SvN088uTqd NN6OYVKWiMckLURyeMjSjqHjcvw0JBhne90WJ384rFV9oE0z5/6+C/NnQNc1krfDkLA7 DJxLLSbGJOr+kvsKBrxkNkuec+OX1hgRGUPxQbLAUysbTLkm0JAI2Uyu/sWJAuIKOWgd F8mQ4JZhQa2Fqd1JAKFuF9bJC8vT4eyTlM9tV9lfACk02DBS0Ayjt9+uDFljqVo1Ne2T BJsw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=tNVlKJMZgR8fQGfjNMGlZb0HEXGPqeGS+UCAapReQEQ=; b=a+HfEm+DFQGJRhiF/g8R910xzCnztSUeckZeMghlwRdGiF2ObHELs1iI2QgpHwpnZD h1DJqzj+uIqF6clKCg/eW9wCq65wqc2UaZpE8YVwIej+VjDNrDS9iQZyjBGfkfJdme1K ADeemJ4J/LHNBJ2Z2wyCKcP1igEqCBmtJSUo9VabZLEhtaZRePuNgqezFISQ+8/47RV3 kbjPqpBDZdCy9JHBIgnyztvxfJnmeuBH5a3DCX5QBoIpPa//zGWxVStHav1ZHPvKaoEP aFceaACg5IMGU9bm8NuCdXyAxGBQt5qzF+oDA6KM7+ZeHzdt1vB75PPRq8VwtAMXdeET C/RA== X-Gm-Message-State: AGi0PuamoaWSRztO0lXiB2FSiDTSpboM42N5ZHGnMV5KrwP2kydqE84c CCbwfEdXH65bjRYSK0D08WU= X-Google-Smtp-Source: APiQypLM6AK8jKHmA2nJzuwDkDwYvmAhNNN+CNoOBiRU/u2OgnsIOG3G2+TrSv7A9npS7PRZThXzUA== X-Received: by 2002:a19:f614:: with SMTP id x20mr20240048lfe.84.1588107571728; Tue, 28 Apr 2020 13:59:31 -0700 (PDT) Received: from pc638.lan (h5ef52e31.seluork.dyn.perspektivbredband.net. [94.245.46.49]) by smtp.gmail.com with ESMTPSA id z21sm295483ljh.42.2020.04.28.13.59.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 Apr 2020 13:59:31 -0700 (PDT) From: "Uladzislau Rezki (Sony)" To: LKML , linux-mm@kvack.org Cc: Andrew Morton , "Paul E . McKenney" , "Theodore Y . Ts'o" , Matthew Wilcox , Joel Fernandes , RCU , Uladzislau Rezki , Oleksiy Avramchenko Subject: [PATCH 03/24] rcu/tree: Use consistent style for comments Date: Tue, 28 Apr 2020 22:58:42 +0200 Message-Id: <20200428205903.61704-4-urezki@gmail.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200428205903.61704-1-urezki@gmail.com> References: <20200428205903.61704-1-urezki@gmail.com> MIME-Version: 1.0 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: From: "Joel Fernandes (Google)" Simple clean up of comments in kfree_rcu() code to keep it consistent with majority of commenting styles. Reviewed-by: Uladzislau Rezki Signed-off-by: Joel Fernandes (Google) Signed-off-by: Uladzislau Rezki (Sony) --- kernel/rcu/tree.c | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/kernel/rcu/tree.c b/kernel/rcu/tree.c index cd61649e1b00..1487af8e11e8 100644 --- a/kernel/rcu/tree.c +++ b/kernel/rcu/tree.c @@ -3043,15 +3043,15 @@ static inline bool queue_kfree_rcu_work(struct kfree_rcu_cpu *krcp) static inline void kfree_rcu_drain_unlock(struct kfree_rcu_cpu *krcp, unsigned long flags) { - // Attempt to start a new batch. + /* Attempt to start a new batch. */ krcp->monitor_todo = false; if (queue_kfree_rcu_work(krcp)) { - // Success! Our job is done here. + /* Success! Our job is done here. */ raw_spin_unlock_irqrestore(&krcp->lock, flags); return; } - // Previous RCU batch still in progress, try again later. + /* Previous RCU batch still in progress, try again later. */ krcp->monitor_todo = true; schedule_delayed_work(&krcp->monitor_work, KFREE_DRAIN_JIFFIES); raw_spin_unlock_irqrestore(&krcp->lock, flags); @@ -3151,14 +3151,14 @@ void kfree_call_rcu(struct rcu_head *head, rcu_callback_t func) unsigned long flags; struct kfree_rcu_cpu *krcp; - local_irq_save(flags); // For safely calling this_cpu_ptr(). + local_irq_save(flags); /* For safely calling this_cpu_ptr(). */ krcp = this_cpu_ptr(&krc); if (krcp->initialized) raw_spin_lock(&krcp->lock); - // Queue the object but don't yet schedule the batch. + /* Queue the object but don't yet schedule the batch. */ if (debug_rcu_head_queue(head)) { - // Probable double kfree_rcu(), just leak. + /* Probable double kfree_rcu(), just leak. */ WARN_ONCE(1, "%s(): Double-freed call. rcu_head %p\n", __func__, head); goto unlock_return; @@ -3176,7 +3176,7 @@ void kfree_call_rcu(struct rcu_head *head, rcu_callback_t func) WRITE_ONCE(krcp->count, krcp->count + 1); - // Set timer to drain after KFREE_DRAIN_JIFFIES. + /* Set timer to drain after KFREE_DRAIN_JIFFIES. */ if (rcu_scheduler_active == RCU_SCHEDULER_RUNNING && !krcp->monitor_todo) { krcp->monitor_todo = true; @@ -3722,7 +3722,7 @@ int rcutree_offline_cpu(unsigned int cpu) rcutree_affinity_setting(cpu, cpu); - // nohz_full CPUs need the tick for stop-machine to work quickly + /* nohz_full CPUs need the tick for stop-machine to work quickly */ tick_dep_set(TICK_DEP_BIT_RCU); return 0; }