From patchwork Tue Apr 28 20:58:45 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Uladzislau Rezki X-Patchwork-Id: 11515565 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id CD59F1392 for ; Tue, 28 Apr 2020 20:59:43 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 903C6214D8 for ; Tue, 28 Apr 2020 20:59:43 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Jpurp9Cl" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 903C6214D8 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id BAE9B8E000B; Tue, 28 Apr 2020 16:59:37 -0400 (EDT) Delivered-To: linux-mm-outgoing@kvack.org Received: by kanga.kvack.org (Postfix, from userid 40) id B86518E0007; Tue, 28 Apr 2020 16:59:37 -0400 (EDT) X-Original-To: int-list-linux-mm@kvack.org X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A75AC8E000B; Tue, 28 Apr 2020 16:59:37 -0400 (EDT) X-Original-To: linux-mm@kvack.org X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0138.hostedemail.com [216.40.44.138]) by kanga.kvack.org (Postfix) with ESMTP id 8416F8E0007 for ; Tue, 28 Apr 2020 16:59:37 -0400 (EDT) Received: from smtpin26.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 4ADB0180AD802 for ; Tue, 28 Apr 2020 20:59:37 +0000 (UTC) X-FDA: 76758479994.26.cow40_53f342d92bd3d X-Spam-Summary: 10,1,0,419e0e95b1d4ef4f,d41d8cd98f00b204,urezki@gmail.com,,RULES_HIT:41:355:379:404:541:800:960:965:966:973:988:989:1260:1311:1314:1345:1359:1437:1515:1535:1541:1711:1730:1747:1777:1792:2196:2199:2393:2559:2562:2693:2907:3138:3139:3140:3141:3142:3353:3865:3866:3867:3868:3870:3871:3872:3874:4321:4385:4390:4395:5007:6261:6653:7514:7875:8603:9413:9592:10004:11026:11473:11658:11914:12043:12297:12517:12519:12555:12895:12986:13069:13311:13357:13894:14181:14384:14394:14687:14721:21080:21444:21451:21627:21666:21740:30034:30054,0,RBL:209.85.208.195:@gmail.com:.lbl8.mailshell.net-66.100.201.100 62.18.0.100,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fp,MSBL:0,DNSBL:neutral,Custom_rules:0:0:0,LFtime:28,LUA_SUMMARY:none X-HE-Tag: cow40_53f342d92bd3d X-Filterd-Recvd-Size: 5071 Received: from mail-lj1-f195.google.com (mail-lj1-f195.google.com [209.85.208.195]) by imf39.hostedemail.com (Postfix) with ESMTP for ; Tue, 28 Apr 2020 20:59:36 +0000 (UTC) Received: by mail-lj1-f195.google.com with SMTP id b2so244670ljp.4 for ; Tue, 28 Apr 2020 13:59:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=0CB7l/SclT28khEWhDaoUOOzb7zLYSSjDTiXz+d76vU=; b=Jpurp9ClV4jnTD0F9m48AGNqTXz1ipQrAnggVWpZFOF++j+brs2BKKdSPUbdX6aZOP BB8HYRVyTSPw91F6rc83G9mQtUbt8i+VsniMWASdZeP4lB0eHTKd1GAxaIoFracSoQ3+ F7NRMfQvoTQaOkMDbTk7RM6frPn7zX6fgnxmlX95hAJhKHI6P8XvSJz0jdrT954quNlp dc7nYW9b2hFclqqafaD225XwkP8oDazc0+OJhcOqqA2m1CoVJpFVKvB9+/mbSIQC6RmP 1sCltiRVjQyIl+DaJZ13b39p5EgL7BpUtO0Iexqfelc4wWFL2kl9G74dBy8g1jpDUACO T3lw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=0CB7l/SclT28khEWhDaoUOOzb7zLYSSjDTiXz+d76vU=; b=qKJa/bm3Pold+kk3Qxc9afyucPdbENTyrXp9NfcQLrJ6/sIfBJK9eskWbwgTZ41aGX yCyHEaoshteA0NgCr6vTU1DbfWdG9qq1v7px7cEnMlo3SH9jL20mGIDAHKXRTfRBFmvP LKhUUO8hsqgyEse+HAMT5O2pbhcXNPbeCD3qZZ2eDdISLpH++2PxNLM4jdwQp0rswZMi sQUwOYgYcA7ycPin1iomV4Vp3M7xBn81lC4Fo7NL2d3xYMGPulRTqmd3IDkhiNySD2hw AzzJv6tnMj/TM6KMtVQpCn/CU1uEjFXG/TEKrEHDjhH4unCq3GXtG8aZBXICtdWL58BT n1qw== X-Gm-Message-State: AGi0PubG3Pol3WO7WDOswn+wqFCs7SbNAfCHuFygk9sz3Uh/cqzA68L2 l7hWldhJLT+GVj8eqVCpiAo= X-Google-Smtp-Source: APiQypLcBZKomWi/mld0ygXkGSXRF8+JLRFoqb07LLbjRoBNCtmRtZtFo7Ra7QnQjLvb3s+93krp6g== X-Received: by 2002:a2e:571a:: with SMTP id l26mr18387002ljb.12.1588107575418; Tue, 28 Apr 2020 13:59:35 -0700 (PDT) Received: from pc638.lan (h5ef52e31.seluork.dyn.perspektivbredband.net. [94.245.46.49]) by smtp.gmail.com with ESMTPSA id z21sm295483ljh.42.2020.04.28.13.59.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 Apr 2020 13:59:34 -0700 (PDT) From: "Uladzislau Rezki (Sony)" To: LKML , linux-mm@kvack.org Cc: Andrew Morton , "Paul E . McKenney" , "Theodore Y . Ts'o" , Matthew Wilcox , Joel Fernandes , RCU , Uladzislau Rezki , Oleksiy Avramchenko , Boqun Feng Subject: [PATCH 06/24] rcu/tree: Simplify KFREE_BULK_MAX_ENTR macro Date: Tue, 28 Apr 2020 22:58:45 +0200 Message-Id: <20200428205903.61704-7-urezki@gmail.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200428205903.61704-1-urezki@gmail.com> References: <20200428205903.61704-1-urezki@gmail.com> MIME-Version: 1.0 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: We can simplify KFREE_BULK_MAX_ENTR macro and get rid of magic numbers which were used to make the structure to be exactly one page. Suggested-by: Boqun Feng Reviewed-by: Joel Fernandes (Google) Signed-off-by: Uladzislau Rezki (Sony) Signed-off-by: Joel Fernandes (Google) --- kernel/rcu/tree.c | 17 +++++++++-------- 1 file changed, 9 insertions(+), 8 deletions(-) diff --git a/kernel/rcu/tree.c b/kernel/rcu/tree.c index 767aed49d7fd..eebd7f627794 100644 --- a/kernel/rcu/tree.c +++ b/kernel/rcu/tree.c @@ -2848,13 +2848,6 @@ EXPORT_SYMBOL_GPL(call_rcu); #define KFREE_DRAIN_JIFFIES (HZ / 50) #define KFREE_N_BATCHES 2 -/* - * This macro defines how many entries the "records" array - * will contain. It is based on the fact that the size of - * kfree_rcu_bulk_data structure becomes exactly one page. - */ -#define KFREE_BULK_MAX_ENTR ((PAGE_SIZE / sizeof(void *)) - 3) - /** * struct kfree_rcu_bulk_data - single block to store kfree_rcu() pointers * @nr_records: Number of active pointers in the array @@ -2863,10 +2856,18 @@ EXPORT_SYMBOL_GPL(call_rcu); */ struct kfree_rcu_bulk_data { unsigned long nr_records; - void *records[KFREE_BULK_MAX_ENTR]; struct kfree_rcu_bulk_data *next; + void *records[]; }; +/* + * This macro defines how many entries the "records" array + * will contain. It is based on the fact that the size of + * kfree_rcu_bulk_data structure becomes exactly one page. + */ +#define KFREE_BULK_MAX_ENTR \ + ((PAGE_SIZE - sizeof(struct kfree_rcu_bulk_data)) / sizeof(void *)) + /** * struct kfree_rcu_cpu_work - single batch of kfree_rcu() requests * @rcu_work: Let queue_rcu_work() invoke workqueue handler after grace period