From patchwork Sat May 2 13:59:10 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yafang Shao X-Patchwork-Id: 11523919 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 66E781864 for ; Sat, 2 May 2020 13:59:54 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 2501D2173E for ; Sat, 2 May 2020 13:59:54 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="hja7iStb" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2501D2173E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 3F7B08E0007; Sat, 2 May 2020 09:59:53 -0400 (EDT) Delivered-To: linux-mm-outgoing@kvack.org Received: by kanga.kvack.org (Postfix, from userid 40) id 3AA108E0001; Sat, 2 May 2020 09:59:53 -0400 (EDT) X-Original-To: int-list-linux-mm@kvack.org X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 24A428E0007; Sat, 2 May 2020 09:59:53 -0400 (EDT) X-Original-To: linux-mm@kvack.org X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0170.hostedemail.com [216.40.44.170]) by kanga.kvack.org (Postfix) with ESMTP id 0DB078E0001 for ; Sat, 2 May 2020 09:59:53 -0400 (EDT) Received: from smtpin11.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id BAD56180AD806 for ; Sat, 2 May 2020 13:59:52 +0000 (UTC) X-FDA: 76771937424.11.stage52_906a3cf5b5506 X-Spam-Summary: 2,0,0,f2a9e928c630e32f,d41d8cd98f00b204,laoar.shao@gmail.com,,RULES_HIT:2:41:69:355:379:541:800:960:973:988:989:1260:1345:1359:1437:1535:1605:1730:1747:1777:1792:2198:2199:2393:2553:2559:2562:2731:2897:2898:3138:3139:3140:3141:3142:3865:3866:3867:3868:3870:3871:3872:3874:4049:4120:4321:4605:5007:6261:6653:7514:7576:7903:9040:9413:9592:10004:11026:11232:11473:11658:11914:12043:12291:12295:12296:12297:12438:12517:12519:12555:12679:12683:12895:12986:13255:14096:14394:14687:21063:21080:21444:21451:21627:21666:21795:21966:21990:30041:30045:30051:30054:30064:30070:30090,0,RBL:209.85.215.195:@gmail.com:.lbl8.mailshell.net-66.100.201.100 62.18.0.100,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fp,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:24,LUA_SUMMARY:none X-HE-Tag: stage52_906a3cf5b5506 X-Filterd-Recvd-Size: 9469 Received: from mail-pg1-f195.google.com (mail-pg1-f195.google.com [209.85.215.195]) by imf46.hostedemail.com (Postfix) with ESMTP for ; Sat, 2 May 2020 13:59:52 +0000 (UTC) Received: by mail-pg1-f195.google.com with SMTP id t11so6000339pgg.2 for ; Sat, 02 May 2020 06:59:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=LCKJNoB/rGVMGmC+SzniM4qEJsOIw7HOm82kp06/+hc=; b=hja7iStbKXi49+l11DsfZvaq4zg2UwBGOpNePYOzfKIz82Bsc+XyPnk3oljStpYRGd 5iRDik1j08BNsaCtc/6kR/8CQ1zHEshR3Jth8i4hOsS18p94S6iund4MQAbjw2q5pV3h jkg0bWwPPZDSpQbBKO9XotARsIc55t2mcjpcZ8HyHu6n5E6N8Wk08bep4Z7EvHzLcUgk qI15Z/7jQDwFse1PG2iSe75znaAd3HUaNcaba4FuVjRQG0WrYq8HO5jCrvdVOYH7ybtf JK7k4D69qI4c9skDc8M7vEDh2BKm/wRCJnqBmYKc/lr045l68B9Almsu6FKjT/TYjXmU aG7A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=LCKJNoB/rGVMGmC+SzniM4qEJsOIw7HOm82kp06/+hc=; b=hWB0qWRQVZoNZa0dt9JYNOlfS7Y7j4SfgvJrSQhse70EDKMERt3TW+HXmqMCElMoBU l8rDB9JvVFqLqb6uG5rRAhH0gC2hiepUniprbtscVfkyVKQFLw3GXGAtWkrRKAuVl2Ru OcaYhwII7Vk4tW27WgVGyQFDC6yMK9yWunXQXN7zvZeMi/oanwZ2ok8MRiwSY37NNxZ0 dI9DTlUyMX4MS9CRvDITA/mUVKaYKFXhymlgI4oCddp1BApUjOyPK3zgqoewz1H5p202 lmU73gglwQwIMCU+5CJS8WZj6yLuwgQKSPxgSx44Af+mWBLXK9GuWhlEKNyhRLtjtBu3 JXLA== X-Gm-Message-State: AGi0PubFlftwaMTKjeQ/3dtJx+QpCdvE4MmEMSisp3J0+NhY9LX3GJkL SKf97CWrFIy7ETNIXrdXXM4= X-Google-Smtp-Source: APiQypKjk2KKcxFL37txfpfDi1dz/Q8KOqDoZh1/ES7e/Dt2xMPh9ebmEPQb9bK0LykkHjKhEm4aqg== X-Received: by 2002:a62:7d8c:: with SMTP id y134mr9449946pfc.231.1588427991404; Sat, 02 May 2020 06:59:51 -0700 (PDT) Received: from localhost.localdomain ([203.100.54.194]) by smtp.gmail.com with ESMTPSA id i11sm4145708pgi.1.2020.05.02.06.59.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 02 May 2020 06:59:50 -0700 (PDT) From: Yafang Shao To: akpm@linux-foundation.org Cc: mhocko@kernel.org, hannes@cmpxchg.org, chris@chrisdown.name, guro@fb.com, linux-mm@kvack.org, Yafang Shao Subject: [PATCH v2 2/2] mm, memcg: Decouple e{low,min} state mutations from protection checks Date: Sat, 2 May 2020 09:59:10 -0400 Message-Id: <20200502135910.7255-3-laoar.shao@gmail.com> X-Mailer: git-send-email 2.18.1 In-Reply-To: <20200502135910.7255-1-laoar.shao@gmail.com> References: <20200502135910.7255-1-laoar.shao@gmail.com> X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: From: Chris Down From: Chris Down mem_cgroup_protected currently is both used to set effective low and min and return a mem_cgroup_protection based on the result. As a user, this can be a little unexpected: it appears to be a simple predicate function, if not for the big warning in the comment above about the order in which it must be executed. This change makes it so that we separate the state mutations from the actual protection checks, which makes it more obvious where we need to be careful mutating internal state, and where we are simply checking and don't need to worry about that. Signed-off-by: Chris Down Suggested-by: Johannes Weiner Acked-by: Johannes Weiner Acked-by: Michal Hocko Cc: Roman Gushchin Signed-off-by: Yafang Shao --- include/linux/memcontrol.h | 43 ++++++++++++++++++++++++++++---------- mm/memcontrol.c | 28 +++++++------------------ mm/vmscan.c | 17 ++++----------- 3 files changed, 43 insertions(+), 45 deletions(-) diff --git a/include/linux/memcontrol.h b/include/linux/memcontrol.h index c07548ce26cb..7a2c56fc220c 100644 --- a/include/linux/memcontrol.h +++ b/include/linux/memcontrol.h @@ -50,12 +50,6 @@ enum memcg_memory_event { MEMCG_NR_MEMORY_EVENTS, }; -enum mem_cgroup_protection { - MEMCG_PROT_NONE, - MEMCG_PROT_LOW, - MEMCG_PROT_MIN, -}; - struct mem_cgroup_reclaim_cookie { pg_data_t *pgdat; unsigned int generation; @@ -394,8 +388,26 @@ static inline unsigned long mem_cgroup_protection(struct mem_cgroup *root, READ_ONCE(memcg->memory.elow)); } -enum mem_cgroup_protection mem_cgroup_protected(struct mem_cgroup *root, - struct mem_cgroup *memcg); +void mem_cgroup_calculate_protection(struct mem_cgroup *root, + struct mem_cgroup *memcg); + +static inline bool mem_cgroup_below_low(struct mem_cgroup *memcg) +{ + if (mem_cgroup_disabled()) + return false; + + return READ_ONCE(memcg->memory.elow) >= + page_counter_read(&memcg->memory); +} + +static inline bool mem_cgroup_below_min(struct mem_cgroup *memcg) +{ + if (mem_cgroup_disabled()) + return false; + + return READ_ONCE(memcg->memory.emin) >= + page_counter_read(&memcg->memory); +} int mem_cgroup_try_charge(struct page *page, struct mm_struct *mm, gfp_t gfp_mask, struct mem_cgroup **memcgp, @@ -879,10 +891,19 @@ static inline unsigned long mem_cgroup_protection(struct mem_cgroup *root, return 0; } -static inline enum mem_cgroup_protection mem_cgroup_protected( - struct mem_cgroup *root, struct mem_cgroup *memcg) +static inline void mem_cgroup_calculate_protection(struct mem_cgroup *root, + struct mem_cgroup *memcg) +{ +} + +static inline bool mem_cgroup_below_low(struct mem_cgroup *memcg) { - return MEMCG_PROT_NONE; + return false; +} + +static inline bool mem_cgroup_below_min(struct mem_cgroup *memcg) +{ + return false; } static inline int mem_cgroup_try_charge(struct page *page, struct mm_struct *mm, diff --git a/mm/memcontrol.c b/mm/memcontrol.c index 1206682edc1a..474815acaf93 100644 --- a/mm/memcontrol.c +++ b/mm/memcontrol.c @@ -6370,21 +6370,15 @@ static unsigned long effective_protection(unsigned long usage, * * WARNING: This function is not stateless! It can only be used as part * of a top-down tree iteration, not for isolated queries. - * - * Returns one of the following: - * MEMCG_PROT_NONE: cgroup memory is not protected - * MEMCG_PROT_LOW: cgroup memory is protected as long there is - * an unprotected supply of reclaimable memory from other cgroups. - * MEMCG_PROT_MIN: cgroup memory is protected */ -enum mem_cgroup_protection mem_cgroup_protected(struct mem_cgroup *root, - struct mem_cgroup *memcg) +void mem_cgroup_calculate_protection(struct mem_cgroup *root, + struct mem_cgroup *memcg) { unsigned long usage, parent_usage; struct mem_cgroup *parent; if (mem_cgroup_disabled()) - return MEMCG_PROT_NONE; + return; if (!root) root = root_mem_cgroup; @@ -6397,21 +6391,21 @@ enum mem_cgroup_protection mem_cgroup_protected(struct mem_cgroup *root, * that special casing. */ if (memcg == root) - return MEMCG_PROT_NONE; + return; usage = page_counter_read(&memcg->memory); if (!usage) - return MEMCG_PROT_NONE; + return; parent = parent_mem_cgroup(memcg); /* No parent means a non-hierarchical mode on v1 memcg */ if (!parent) - return MEMCG_PROT_NONE; + return; if (parent == root) { memcg->memory.emin = READ_ONCE(memcg->memory.min); memcg->memory.elow = memcg->memory.low; - goto out; + return; } parent_usage = page_counter_read(&parent->memory); @@ -6424,14 +6418,6 @@ enum mem_cgroup_protection mem_cgroup_protected(struct mem_cgroup *root, WRITE_ONCE(memcg->memory.elow, effective_protection(usage, parent_usage, memcg->memory.low, READ_ONCE(parent->memory.elow), atomic_long_read(&parent->memory.children_low_usage))); - -out: - if (usage <= memcg->memory.emin) - return MEMCG_PROT_MIN; - else if (usage <= memcg->memory.elow) - return MEMCG_PROT_LOW; - else - return MEMCG_PROT_NONE; } /** diff --git a/mm/vmscan.c b/mm/vmscan.c index 4d3027ac131c..c71660e2c304 100644 --- a/mm/vmscan.c +++ b/mm/vmscan.c @@ -2635,14 +2635,15 @@ static void shrink_node_memcgs(pg_data_t *pgdat, struct scan_control *sc) unsigned long reclaimed; unsigned long scanned; - switch (mem_cgroup_protected(target_memcg, memcg)) { - case MEMCG_PROT_MIN: + mem_cgroup_calculate_protection(target_memcg, memcg); + + if (mem_cgroup_below_min(memcg)) { /* * Hard protection. * If there is no reclaimable memory, OOM. */ continue; - case MEMCG_PROT_LOW: + } else if (mem_cgroup_below_low(memcg)) { /* * Soft protection. * Respect the protection only as long as @@ -2654,16 +2655,6 @@ static void shrink_node_memcgs(pg_data_t *pgdat, struct scan_control *sc) continue; } memcg_memory_event(memcg, MEMCG_LOW); - break; - case MEMCG_PROT_NONE: - /* - * All protection thresholds breached. We may - * still choose to vary the scan pressure - * applied based on by how much the cgroup in - * question has exceeded its protection - * thresholds (see get_scan_count). - */ - break; } reclaimed = sc->nr_reclaimed;