diff mbox series

[v2,1/1] mm/page_io.c: remove an unnecessary goto in generic_swapfile_activate()

Message ID 20200508120640.1852-2-thunder.leizhen@huawei.com (mailing list archive)
State New, archived
Headers show
Series mm/page_io.c: remove an unnecessary goto in generic_swapfile_activate() | expand

Commit Message

Leizhen (ThunderTown) May 8, 2020, 12:06 p.m. UTC 
This "goto" doesn't reduce any code, but bother the readers.

Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
Reviewed-by: David Hildenbrand <david@redhat.com>
---
 mm/page_io.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
diff mbox series

Patch

diff --git a/mm/page_io.c b/mm/page_io.c
index 76965be1d40e..19d429abb2cc 100644
--- a/mm/page_io.c
+++ b/mm/page_io.c
@@ -237,8 +237,7 @@  int generic_swapfile_activate(struct swap_info_struct *sis,
 	return ret;
 bad_bmap:
 	pr_err("swapon: swapfile has holes\n");
-	ret = -EINVAL;
-	goto out;
+	return -EINVAL;
 }
 
 /*