From patchwork Tue Jul 7 03:11:56 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Song Bao Hua (Barry Song)" X-Patchwork-Id: 11647473 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 172C61398 for ; Tue, 7 Jul 2020 03:14:06 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id D46762070C for ; Tue, 7 Jul 2020 03:14:05 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D46762070C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=hisilicon.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id D7C256B0005; Mon, 6 Jul 2020 23:14:04 -0400 (EDT) Delivered-To: linux-mm-outgoing@kvack.org Received: by kanga.kvack.org (Postfix, from userid 40) id D2D6F6B0008; Mon, 6 Jul 2020 23:14:04 -0400 (EDT) X-Original-To: int-list-linux-mm@kvack.org X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C43586B000A; Mon, 6 Jul 2020 23:14:04 -0400 (EDT) X-Original-To: linux-mm@kvack.org X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0134.hostedemail.com [216.40.44.134]) by kanga.kvack.org (Postfix) with ESMTP id AEFCB6B0005 for ; Mon, 6 Jul 2020 23:14:04 -0400 (EDT) Received: from smtpin18.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 503AB8248047 for ; Tue, 7 Jul 2020 03:14:04 +0000 (UTC) X-FDA: 77009810808.18.sack30_1f0561026eb1 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin18.hostedemail.com (Postfix) with ESMTP id 25553100EDBC1 for ; Tue, 7 Jul 2020 03:14:04 +0000 (UTC) X-Spam-Summary: 1,0,0,3c12246412f556e1,d41d8cd98f00b204,song.bao.hua@hisilicon.com,,RULES_HIT:41:355:379:541:582:800:960:973:988:989:1152:1260:1261:1277:1311:1313:1314:1345:1437:1515:1516:1518:1534:1541:1711:1730:1747:1777:1792:2194:2199:2393:2559:2562:3138:3139:3140:3141:3142:3352:3867:3871:4250:4321:5007:6261:10004:10400:11026:11658:11914:12043:12297:12438:12555:12679:12895:13069:13311:13357:13894:14093:14097:14181:14394:14721:21080:21451:21627:21990:30054:30064:30070,0,RBL:45.249.212.32:@hisilicon.com:.lbl8.mailshell.net-64.100.201.201 62.2.2.100;04yrzygseq6kobykksm69eu5k8c9yop3gqey3kzt3zoqao9rszt77zn6jjpiyze.mn5yefhr4g7n8j4bsf878je4yankceyoj63xa3ye5db9dqrxgpsyt7rw5w9surg.n-lbl8.mailshell.net-223.238.255.100,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fp,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:24,LUA_SUMMARY:none X-HE-Tag: sack30_1f0561026eb1 X-Filterd-Recvd-Size: 2788 Received: from huawei.com (szxga06-in.huawei.com [45.249.212.32]) by imf31.hostedemail.com (Postfix) with ESMTP for ; Tue, 7 Jul 2020 03:14:03 +0000 (UTC) Received: from DGGEMS413-HUB.china.huawei.com (unknown [172.30.72.59]) by Forcepoint Email with ESMTP id 05D4362912129E933CDC; Tue, 7 Jul 2020 11:13:57 +0800 (CST) Received: from SWX921481.china.huawei.com (10.126.201.228) by DGGEMS413-HUB.china.huawei.com (10.3.19.213) with Microsoft SMTP Server id 14.3.487.0; Tue, 7 Jul 2020 11:13:48 +0800 From: Barry Song To: CC: , , , Barry Song , "Roman Gushchin" , Mike Kravetz , "Jonathan Cameron" Subject: [PATCH v2] mm/hugetlb: avoid hardcoding while checking if cma is enable Date: Tue, 7 Jul 2020 15:11:56 +1200 Message-ID: <20200707031156.29932-1-song.bao.hua@hisilicon.com> X-Mailer: git-send-email 2.21.0.windows.1 MIME-Version: 1.0 X-Originating-IP: [10.126.201.228] X-CFilter-Loop: Reflected X-Rspamd-Queue-Id: 25553100EDBC1 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam05 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: hugetlb_cma[0] can be NULL due to various reasons, for example, node0 has no memory. so NULL hugetlb_cma[0] doesn't necessarily mean cma is not enabled. gigantic pages might have been reserved on other nodes. Fixes: cf11e85fc08c ("mm: hugetlb: optionally allocate gigantic hugepages using cma") Cc: Roman Gushchin Cc: Mike Kravetz Cc: Jonathan Cameron Signed-off-by: Barry Song Acked-by: Roman Gushchin after that. --- -v2: add hugetlb_cma_enabled() helper to improve readability according to Roman mm/hugetlb.c | 16 +++++++++++++++- 1 file changed, 15 insertions(+), 1 deletion(-) diff --git a/mm/hugetlb.c b/mm/hugetlb.c index 57ece74e3aae..d5e98ed86bb9 100644 --- a/mm/hugetlb.c +++ b/mm/hugetlb.c @@ -2546,6 +2546,20 @@ static void __init gather_bootmem_prealloc(void) } } +bool __init hugetlb_cma_enabled(void) +{ + if (IS_ENABLED(CONFIG_CMA)) { + int node; + + for_each_online_node(node) { + if (hugetlb_cma[node]) + return true; + } + } + + return false; +} + static void __init hugetlb_hstate_alloc_pages(struct hstate *h) { unsigned long i; @@ -2571,7 +2585,7 @@ static void __init hugetlb_hstate_alloc_pages(struct hstate *h) for (i = 0; i < h->max_huge_pages; ++i) { if (hstate_is_gigantic(h)) { - if (IS_ENABLED(CONFIG_CMA) && hugetlb_cma[0]) { + if (hugetlb_cma_enabled()) { pr_warn_once("HugeTLB: hugetlb_cma is enabled, skip boot time allocation\n"); break; }