Message ID | 20200918194817.48921-4-urezki@gmail.com (mailing list archive) |
---|---|
State | New, archived |
Headers | show
Return-Path: <SRS0=yEt/=C3=kvack.org=owner-linux-mm@kernel.org> Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 9FD21746 for <patchwork-linux-mm@patchwork.kernel.org>; Fri, 18 Sep 2020 19:48:46 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 5D97B22208 for <patchwork-linux-mm@patchwork.kernel.org>; Fri, 18 Sep 2020 19:48:46 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="bS8wqurD" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5D97B22208 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id AE36D900006; Fri, 18 Sep 2020 15:48:42 -0400 (EDT) Delivered-To: linux-mm-outgoing@kvack.org Received: by kanga.kvack.org (Postfix, from userid 40) id A93A2900004; Fri, 18 Sep 2020 15:48:42 -0400 (EDT) X-Original-To: int-list-linux-mm@kvack.org X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 98252900006; Fri, 18 Sep 2020 15:48:42 -0400 (EDT) X-Original-To: linux-mm@kvack.org X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0048.hostedemail.com [216.40.44.48]) by kanga.kvack.org (Postfix) with ESMTP id 85608900004 for <linux-mm@kvack.org>; Fri, 18 Sep 2020 15:48:42 -0400 (EDT) Received: from smtpin09.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 531A98249980 for <linux-mm@kvack.org>; Fri, 18 Sep 2020 19:48:42 +0000 (UTC) X-FDA: 77277219684.09.copy74_5814f4c2712d Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin09.hostedemail.com (Postfix) with ESMTP id 382EB180AD806 for <linux-mm@kvack.org>; Fri, 18 Sep 2020 19:48:42 +0000 (UTC) X-Spam-Summary: 1,0,0,606714cb93ccbc5e,d41d8cd98f00b204,urezki@gmail.com,,RULES_HIT:41:355:379:541:800:960:966:973:988:989:1260:1311:1314:1345:1359:1437:1515:1534:1541:1711:1730:1747:1777:1792:2196:2199:2393:2559:2562:2693:3138:3139:3140:3141:3142:3352:3865:3866:3867:3868:3870:3871:3872:3874:4321:4385:5007:6261:6653:7514:7903:9010:9413:10004:11026:11473:11658:11914:12043:12048:12114:12297:12438:12517:12519:12555:12895:12986:13069:13311:13357:13894:14181:14384:14394:14687:14721:21080:21094:21323:21444:21451:21627:21666:21740:21990:30034:30054,0,RBL:209.85.208.196:@gmail.com:.lbl8.mailshell.net-66.100.201.100 62.18.84.100;04yrrs9oz6wbtp4h9766qsks5nh8kocgmca3qjd3isjsaiuram1j3wpk13szhc1.crj4axse1f5k1sd9x9i7h5usjogx5q875bapj346dd15b8ym7w4xsf49r1dn9sp.6-lbl8.mailshell.net-223.238.255.100,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fp,MSBL:0,DNSBL:neutral,Custom_rules:0:0:0,LFtime:24,LUA_SUMMARY:none X-HE-Tag: copy74_5814f4c2712d X-Filterd-Recvd-Size: 4808 Received: from mail-lj1-f196.google.com (mail-lj1-f196.google.com [209.85.208.196]) by imf15.hostedemail.com (Postfix) with ESMTP for <linux-mm@kvack.org>; Fri, 18 Sep 2020 19:48:41 +0000 (UTC) Received: by mail-lj1-f196.google.com with SMTP id a22so5983399ljp.13 for <linux-mm@kvack.org>; Fri, 18 Sep 2020 12:48:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=pihU19ZyV1tR9rxjJBUfTFPiShIHT6wFJWQRUBqDuSU=; b=bS8wqurDjQBWPYzxoQcs/RTFMBIpDOsIN5r0Vh5wX+3vYkIyVlIjt5XSIMtOJstZVK wb5EiRTsmWoA0Cp8WZy/jSjGkQR2T6ZuFRH3hci0DFMhtnD06XU2yZICKtAEn5vg/hpd KV0eJycW4/86TauW7eoyQ/E0dz+UDN5qU4WOpJWlS2yLKFi/bDBT41Pc1qzrlDzkKvDB OeZDVLMLFzjzLZ6QzDVdRIkQ+hIk1N2s3SUEwFL47OvxQ4+WZ1kmaqriNQlipgbfuCZo kCOVW9IhZ6C/HiDlwve9rHe/GOCZdKrMrh9qjgyKuVs3P/uxNZIC9xHjIzYdnZfq/yyK JuvA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=pihU19ZyV1tR9rxjJBUfTFPiShIHT6wFJWQRUBqDuSU=; b=g9J60Q0aYuCBIUxDANEa+piKc6FldpaD/pXxjwNPPCO7od43bEKtx6ge85kCjCXebl T2trZ1KR5N1dr0hxm54TJcZAJLa9qES06P+dAa3e2x6ukWeW43aG4F9Fe7FDegfALWnh 2E0/jwtl2q6wnyfLql/PvZzxjCPfesBHRSEPtWAHfmXnxA8+1UBEl6BoriEmKA2q906X XGII+GSW7bKG1rRNQTX71pgwIdixrw39Cnf4U1p6e9ZtjAo82DnhkMANUcV4Cfuj1XD1 tZhczGdGDLGGewZrjIOSY2Rrp8mc1nTAe8rSq6G4ISHvkgiKTswud0FA/jLGKElbW/0I f83Q== X-Gm-Message-State: AOAM531jNRKmkoI8B+gGLqrO4jgL0ZzVZgLCUQyldDJ3tQ/fz26d4uOd hVFrg4fGe/+uJziWtaB0Zus= X-Google-Smtp-Source: ABdhPJwbBuxfhOpviYZGwvbN5A+9fD5A8wr8vfAimfJY/Xc6BHGV8kJjoXIMhF++dXqMjZqyGvocnw== X-Received: by 2002:a2e:911:: with SMTP id 17mr13543936ljj.207.1600458520502; Fri, 18 Sep 2020 12:48:40 -0700 (PDT) Received: from pc638.lan (h5ef52e31.seluork.dyn.perspektivbredband.net. [94.245.46.49]) by smtp.gmail.com with ESMTPSA id a17sm766769lfd.148.2020.09.18.12.48.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 18 Sep 2020 12:48:40 -0700 (PDT) From: "Uladzislau Rezki (Sony)" <urezki@gmail.com> To: LKML <linux-kernel@vger.kernel.org>, RCU <rcu@vger.kernel.org>, linux-mm@kvack.org, Andrew Morton <akpm@linux-foundation.org>, "Paul E . McKenney" <paulmck@kernel.org> Cc: Peter Zijlstra <peterz@infradead.org>, Michal Hocko <mhocko@suse.com>, Vlastimil Babka <vbabka@suse.cz>, Thomas Gleixner <tglx@linutronix.de>, "Theodore Y . Ts'o" <tytso@mit.edu>, Joel Fernandes <joel@joelfernandes.org>, Sebastian Andrzej Siewior <bigeasy@linutronix.de>, Uladzislau Rezki <urezki@gmail.com>, Oleksiy Avramchenko <oleksiy.avramchenko@sonymobile.com> Subject: [PATCH 3/4] rcu/tree: use __rcu_alloc_page_lockless() func. Date: Fri, 18 Sep 2020 21:48:16 +0200 Message-Id: <20200918194817.48921-4-urezki@gmail.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200918194817.48921-1-urezki@gmail.com> References: <20200918194817.48921-1-urezki@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: <linux-mm.kvack.org> |
Series | kvfree_rcu() and _LOCK_NESTING/_PREEMPT_RT | expand |
diff --git a/kernel/rcu/tree.c b/kernel/rcu/tree.c index 4bfc46a1e9d1..d51209343029 100644 --- a/kernel/rcu/tree.c +++ b/kernel/rcu/tree.c @@ -3401,6 +3401,10 @@ kvfree_call_rcu_add_ptr_to_bulk(struct kfree_rcu_cpu *krcp, void *ptr) if (!krcp->bkvhead[idx] || krcp->bkvhead[idx]->nr_records == KVFREE_BULK_MAX_ENTR) { bnode = get_cached_bnode(krcp); + if (!bnode) + bnode = (struct kvfree_rcu_bulk_data *) + __rcu_alloc_page_lockless(); + /* Switch to emergency path. */ if (!bnode) return false;
Use a newly introduced __rcu_alloc_page_lockless() function directly in the k[v]free_rcu() path, a new pointer array can be obtained by demand, what reduces a memory footprint, does it without any delays and in time. Please note, we still keep the worker approach introduced earlier, because the lock-less page allocation uses a per-cpu-list cache that can be depleted, what is absolutely a normal behaviour. If so, the worker we have, by requesting a new page will also initiate an internal process that prefetches specified number of elements from the buddy allocator populating the "pcplist" by new fresh pages. A number of pre-fetched elements can be controlled via sysfs attribute. Please see the /proc/sys/vm/percpu_pagelist_fraction. Signed-off-by: Uladzislau Rezki (Sony) <urezki@gmail.com> --- kernel/rcu/tree.c | 4 ++++ 1 file changed, 4 insertions(+)