From patchwork Sat Oct 3 00:21:41 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: John Hubbard X-Patchwork-Id: 11814799 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id A2066112C for ; Sat, 3 Oct 2020 00:21:49 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 64F4220665 for ; Sat, 3 Oct 2020 00:21:49 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=nvidia.com header.i=@nvidia.com header.b="pW53dv/u" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 64F4220665 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=nvidia.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 9D1EF6B006E; Fri, 2 Oct 2020 20:21:46 -0400 (EDT) Delivered-To: linux-mm-outgoing@kvack.org Received: by kanga.kvack.org (Postfix, from userid 40) id 7EBD16B0071; Fri, 2 Oct 2020 20:21:46 -0400 (EDT) X-Original-To: int-list-linux-mm@kvack.org X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6B2C16B0072; Fri, 2 Oct 2020 20:21:46 -0400 (EDT) X-Original-To: linux-mm@kvack.org X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0209.hostedemail.com [216.40.44.209]) by kanga.kvack.org (Postfix) with ESMTP id 32E3F6B006E for ; Fri, 2 Oct 2020 20:21:46 -0400 (EDT) Received: from smtpin27.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id C1AEE8249980 for ; Sat, 3 Oct 2020 00:21:45 +0000 (UTC) X-FDA: 77328710970.27.party99_5a01e7e271a8 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin27.hostedemail.com (Postfix) with ESMTP id A66083D668 for ; Sat, 3 Oct 2020 00:21:45 +0000 (UTC) X-Spam-Summary: 1,0,0,,d41d8cd98f00b204,jhubbard@nvidia.com,,RULES_HIT:30054:30056:30064:30070,0,RBL:216.228.121.65:@nvidia.com:.lbl8.mailshell.net-64.10.201.10 62.18.0.100;04ygyn3omprc3cs8ng1tyh7kug5eryc5zahmbsfqrcz4ze7fonrdzzagwnejiod.mq4x8r8qub8kzsxm3ajiymw7a4om7pena7p58r5uha3k5wug3nqgx3bp11tnix4.w-lbl8.mailshell.net-223.238.255.100,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:ft,MSBL:0,DNSBL:neutral,Custom_rules:0:0:0,LFtime:32,LUA_SUMMARY:none X-HE-Tag: party99_5a01e7e271a8 X-Filterd-Recvd-Size: 3842 Received: from hqnvemgate26.nvidia.com (hqnvemgate26.nvidia.com [216.228.121.65]) by imf41.hostedemail.com (Postfix) with ESMTP for ; Sat, 3 Oct 2020 00:21:44 +0000 (UTC) Received: from hqmail.nvidia.com (Not Verified[216.228.121.13]) by hqnvemgate26.nvidia.com (using TLS: TLSv1.2, AES256-SHA) id ; Fri, 02 Oct 2020 17:21:30 -0700 Received: from HQMAIL105.nvidia.com (172.20.187.12) by HQMAIL105.nvidia.com (172.20.187.12) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Sat, 3 Oct 2020 00:21:43 +0000 Received: from sandstorm.nvidia.com (10.124.1.5) by mail.nvidia.com (172.20.187.12) with Microsoft SMTP Server id 15.0.1473.3 via Frontend Transport; Sat, 3 Oct 2020 00:21:43 +0000 From: John Hubbard To: Stephen Rothwell , Andrew Morton CC: Linux Next , LKML , , John Hubbard Subject: [PATCH v3 1/2] selftests/vm: fix an improper dependency upon executable script permissions Date: Fri, 2 Oct 2020 17:21:41 -0700 Message-ID: <20201003002142.32671-2-jhubbard@nvidia.com> X-Mailer: git-send-email 2.28.0 In-Reply-To: <20201003002142.32671-1-jhubbard@nvidia.com> References: <20201003002142.32671-1-jhubbard@nvidia.com> MIME-Version: 1.0 X-NVConfidentiality: public DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1601684490; bh=WuyiYWjWPWYyIxLJ4cAt9mzxpJiZtrYrsXWo+nyO5Dw=; h=From:To:CC:Subject:Date:Message-ID:X-Mailer:In-Reply-To: References:MIME-Version:X-NVConfidentiality: Content-Transfer-Encoding:Content-Type; b=pW53dv/u8yw4i/CUrfXGZr76nPQNAoVZAaigSWV8j48+P9aJDTxYtG0RUrQxB6u+b /+6v2EGqxGcGYdkRap4cxnhbeqdPqkfoolwDqKrOIqTdM0h+e5kxZRo0w7joB3RyE2 ygIWyz0B4scLOf4Ybb3chRKxbrqRFwPs7DoHum3Y0C0QGXG4ZwEyK+BNxXAq6bWfUJ LZWS92LEYouNXJrAOP7eFuPUDuGSTsrua/QhT3iHOu2LHrd7oDy0E6JRl0oiDrIO1y AsG5Z3k62zP1H0LpMuMAUnnmHzuiUQFqwhoID2BlsbdG11QMStWZKRxnfeHe5d1y5o cUXeToPlXaRgg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: commit 30fb9454ab23 ("selftests/vm: hmm-tests: remove the libhugetlbfs dependency") created the new check_config.sh file without the execute bit set. This is a problem because that same commit caused the Makefile to invoke it "./check_config.sh", so now "make" is failing in that directory. Scripts are not supposed to depend on the executable bit being set, because patch(1) doesn't set it, and using patch to install a kernel is supported. Therefore, this fix involves two parts: 1) Invoke the new script via /bin/sh, to fix the problem, and 2) As an nice touch, make check_config.sh executable as well. Fixes: commit 30fb9454ab23 ("selftests/vm: hmm-tests: remove the libhugetlbfs dependency") Signed-off-by: John Hubbard --- tools/testing/selftests/vm/Makefile | 2 +- tools/testing/selftests/vm/check_config.sh | 0 2 files changed, 1 insertion(+), 1 deletion(-) mode change 100644 => 100755 tools/testing/selftests/vm/check_config.sh diff --git a/tools/testing/selftests/vm/Makefile b/tools/testing/selftests/vm/Makefile index 019cbb7f3cf8..a9332a7cf33f 100644 --- a/tools/testing/selftests/vm/Makefile +++ b/tools/testing/selftests/vm/Makefile @@ -138,7 +138,7 @@ $(OUTPUT)/hmm-tests: local_config.h $(OUTPUT)/hmm-tests: LDLIBS += $(HMM_EXTRA_LIBS) local_config.mk local_config.h: check_config.sh - ./check_config.sh $(CC) + /bin/sh ./check_config.sh $(CC) EXTRA_CLEAN += local_config.mk local_config.h diff --git a/tools/testing/selftests/vm/check_config.sh b/tools/testing/selftests/vm/check_config.sh old mode 100644 new mode 100755