From patchwork Tue Nov 24 05:39:43 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Suren Baghdasaryan X-Patchwork-Id: 11927183 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.6 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_INVALID,DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AB514C63777 for ; Tue, 24 Nov 2020 05:39:55 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 28484206FB for ; Tue, 24 Nov 2020 05:39:55 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=google.com header.i=@google.com header.b="YpxnqpYi" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 28484206FB Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 7CAED6B0078; Tue, 24 Nov 2020 00:39:54 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 727E56B007B; Tue, 24 Nov 2020 00:39:54 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5CF1A6B007D; Tue, 24 Nov 2020 00:39:54 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0126.hostedemail.com [216.40.44.126]) by kanga.kvack.org (Postfix) with ESMTP id 16A266B0078 for ; Tue, 24 Nov 2020 00:39:54 -0500 (EST) Received: from smtpin23.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id AF1A11EE6 for ; Tue, 24 Nov 2020 05:39:53 +0000 (UTC) X-FDA: 77518210266.23.north47_2513cde2736b Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin23.hostedemail.com (Postfix) with ESMTP id 8F88E37604 for ; Tue, 24 Nov 2020 05:39:53 +0000 (UTC) X-HE-Tag: north47_2513cde2736b X-Filterd-Recvd-Size: 6058 Received: from mail-yb1-f202.google.com (mail-yb1-f202.google.com [209.85.219.202]) by imf16.hostedemail.com (Postfix) with ESMTP for ; Tue, 24 Nov 2020 05:39:52 +0000 (UTC) Received: by mail-yb1-f202.google.com with SMTP id i184so25877127ybg.7 for ; Mon, 23 Nov 2020 21:39:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=sender:date:in-reply-to:message-id:mime-version:references:subject :from:to:cc; bh=num0SQsxDIMRNuuSRBGQ+NlMxj/jOeSqEtVQ3GNIWyo=; b=YpxnqpYi239SbpxtHV+Vxz7w+h0AiAQYV1GookO796eyPdkf+79Unh1sSkTeYIGYlZ fYGtsTS/V0+StBRMMtQWYykHOSsxU8EHFJJMuz5OQum15tUzmoU4mIhQhDqV2nBEyqKs XK/KIZ2+zwBhcA+EzWiaCrqZe2Nb2x65s/Lfy+6uoLbUsHLsF3davJSBrpklz4sSUv4W /SQPXg6/uMywGKgpV3mVypJfITIHuhBrto6iRSwkpTUClCyA2efXPf7U0yXt3j1K5YKW p7TYHvw5CfC6xs5MJRByYXxoD6L1RnaBXJHLv7SbZb1BSqe2QO2ZMHreLbFH0hCJmgun cHmQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:in-reply-to:message-id:mime-version :references:subject:from:to:cc; bh=num0SQsxDIMRNuuSRBGQ+NlMxj/jOeSqEtVQ3GNIWyo=; b=cvZXrneUAOou5fzaCQZgemUzGE4SozcmoA/isVN8Rr2Qe91Z5Z7Il59mtp7FqX2jPq H6TKPm9bM97d2KPgy+e+prNx/i+nBjh7F9UBrfkaQgaLklkhfNh3QjKYkUxgGuRDHyHE flFHJnrA9Nh+HMQelrGVZ0iYj3X23iD7kuCJhhHPLJMN7jaYbQOnZ2/703Clz6wJPpoT QPEEynB/2Tol/dkA8iyunZvckXFfN50GVEecTkWjwzXq/HcGBqarWP29qcasE1lyQqM0 fqJy6tq5AEaa8KEd1I4TKrbCNIzTWkrXCDpV0JQGxSWjsS0CQaqWBLbBpzIzBpr757ZZ bBFw== X-Gm-Message-State: AOAM530DH/hfE4jWpm3M8RIkQzqwgDiyAuh6tuSmfJneIrXUHm9KCoo/ azbrt7952xInlhihcNQzCgOS2iJkjSA= X-Google-Smtp-Source: ABdhPJxzVVmlhMNlsCBIR68sN2RXwHt8UgDh7S4/lf5Z8gJWx8kRvBvH4P+J8Q+9qwpwIDF0oHGRYNLQQ5A= X-Received: from surenb1.mtv.corp.google.com ([2620:15c:211:200:f693:9fff:fef4:2055]) (user=surenb job=sendgmr) by 2002:a25:cc0c:: with SMTP id l12mr5070405ybf.90.1606196392342; Mon, 23 Nov 2020 21:39:52 -0800 (PST) Date: Mon, 23 Nov 2020 21:39:43 -0800 In-Reply-To: <20201124053943.1684874-1-surenb@google.com> Message-Id: <20201124053943.1684874-3-surenb@google.com> Mime-Version: 1.0 References: <20201124053943.1684874-1-surenb@google.com> X-Mailer: git-send-email 2.29.2.454.gaff20da3a2-goog Subject: [PATCH 2/2] mm/madvise: add process_madvise MADV_DONTNEER support From: Suren Baghdasaryan To: surenb@google.com Cc: akpm@linux-foundation.org, mhocko@kernel.org, mhocko@suse.com, rientjes@google.com, willy@infradead.org, hannes@cmpxchg.org, guro@fb.com, riel@surriel.com, minchan@kernel.org, christian@brauner.io, oleg@redhat.com, timmurray@google.com, linux-api@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, kernel-team@android.com X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: In modern systems it's not unusual to have a system component monitoring memory conditions of the system and tasked with keeping system memory pressure under control. One way to accomplish that is to kill non-essential processes to free up memory for more important ones. Examples of this are Facebook's OOM killer daemon called oomd and Android's low memory killer daemon called lmkd. For such system component it's important to be able to free memory quickly and efficiently. Unfortunately the time process takes to free up its memory after receiving a SIGKILL might vary based on the state of the process (uninterruptible sleep), size and OPP level of the core the process is running. In such situation it is desirable to be able to free up the memory of the process being killed in a more controlled way. Enable MADV_DONTNEED to be used with process_madvise when applied to a dying process to reclaim its memory. This would allow userspace system components like oomd and lmkd to free memory of the target process in a more predictable way. Signed-off-by: Suren Baghdasaryan --- mm/madvise.c | 34 ++++++++++++++++++++++++++++++++++ 1 file changed, 34 insertions(+) diff --git a/mm/madvise.c b/mm/madvise.c index 1aa074a46524..11306534369e 100644 --- a/mm/madvise.c +++ b/mm/madvise.c @@ -29,6 +29,7 @@ #include #include #include +#include #include @@ -995,6 +996,18 @@ process_madvise_behavior_valid(int behavior) switch (behavior) { case MADV_COLD: case MADV_PAGEOUT: + case MADV_DONTNEED: + return true; + default: + return false; + } +} + +static bool madvise_destructive(int behavior) +{ + switch (behavior) { + case MADV_DONTNEED: + case MADV_FREE: return true; default: return false; @@ -1006,6 +1019,10 @@ static bool can_range_madv_lru_vma(struct vm_area_struct *vma, int behavior) if (!can_madv_lru_vma(vma)) return false; + /* For destructive madvise skip shared file-backed VMAs */ + if (madvise_destructive(behavior)) + return vma_is_anonymous(vma) || !(vma->vm_flags & VM_SHARED); + return true; } @@ -1239,6 +1256,23 @@ SYSCALL_DEFINE5(process_madvise, int, pidfd, const struct iovec __user *, vec, goto release_task; } + if (madvise_destructive(behavior)) { + /* Allow destructive madvise only on a dying processes */ + if (!signal_group_exit(task->signal)) { + ret = -EINVAL; + goto release_mm; + } + /* Ensure no competition with OOM-killer to avoid contention */ + if (unlikely(mm_is_oom_victim(mm)) || + unlikely(test_bit(MMF_OOM_SKIP, &mm->flags))) { + /* Already being reclaimed */ + ret = 0; + goto release_mm; + } + /* Mark mm as unstable */ + set_bit(MMF_UNSTABLE, &mm->flags); + } + /* * For range madvise only the entire address space is supported for now * and input iovec is ignored.