| Message ID | 20210108085202.4506-1-osalvador@suse.de (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | mm,hwpoison: Fix printing of page flags | expand |
On 1/8/21 2:22 PM, Oscar Salvador wrote: > Format %pG expects a lower case 'p' in order to print the flags. > Fix it. > > Reported-by: Dan Carpenter <dan.carpenter@oracle.com> > Signed-off-by: Oscar Salvador <osalvador@suse.de> > Fixes: 8295d535e2aa ("mm,hwpoison: refactor get_any_page") Reviewed-by: Anshuman Khandual <anshuman.khandual@arm.com> > --- > mm/memory-failure.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/memory-failure.c b/mm/memory-failure.c > index 5a38e9eade94..04d9f154a130 100644 > --- a/mm/memory-failure.c > +++ b/mm/memory-failure.c > @@ -1940,7 +1940,7 @@ int soft_offline_page(unsigned long pfn, int flags) > goto retry; > } > } else if (ret == -EIO) { > - pr_info("%s: %#lx: unknown page type: %lx (%pGP)\n", > + pr_info("%s: %#lx: unknown page type: %lx (%pGp)\n", > __func__, pfn, page->flags, &page->flags); > } > >
On Fri, Jan 08, 2021 at 09:52:02AM +0100, Oscar Salvador wrote: > Format %pG expects a lower case 'p' in order to print the flags. > Fix it. > > Reported-by: Dan Carpenter <dan.carpenter@oracle.com> > Signed-off-by: Oscar Salvador <osalvador@suse.de> > Fixes: 8295d535e2aa ("mm,hwpoison: refactor get_any_page") Thank you! Acked-by: Naoya Horiguchi <naoya.horiguchi@nec.com>
diff --git a/mm/memory-failure.c b/mm/memory-failure.c index 5a38e9eade94..04d9f154a130 100644 --- a/mm/memory-failure.c +++ b/mm/memory-failure.c @@ -1940,7 +1940,7 @@ int soft_offline_page(unsigned long pfn, int flags) goto retry; } } else if (ret == -EIO) { - pr_info("%s: %#lx: unknown page type: %lx (%pGP)\n", + pr_info("%s: %#lx: unknown page type: %lx (%pGp)\n", __func__, pfn, page->flags, &page->flags); }
Format %pG expects a lower case 'p' in order to print the flags. Fix it. Reported-by: Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by: Oscar Salvador <osalvador@suse.de> Fixes: 8295d535e2aa ("mm,hwpoison: refactor get_any_page") --- mm/memory-failure.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)