From patchwork Fri Jan 15 14:23:14 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tang Yizhou X-Patchwork-Id: 12022971 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DC3A2C433DB for ; Fri, 15 Jan 2021 14:12:08 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 6789123877 for ; Fri, 15 Jan 2021 14:12:08 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6789123877 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=huawei.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id B66478D017F; Fri, 15 Jan 2021 09:12:07 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id A791E8D0162; Fri, 15 Jan 2021 09:12:07 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 91ABE8D017F; Fri, 15 Jan 2021 09:12:07 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0121.hostedemail.com [216.40.44.121]) by kanga.kvack.org (Postfix) with ESMTP id 6D4B38D0162 for ; Fri, 15 Jan 2021 09:12:07 -0500 (EST) Received: from smtpin16.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 2545D3626 for ; Fri, 15 Jan 2021 14:12:07 +0000 (UTC) X-FDA: 77708198694.16.match84_03155292752f Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin16.hostedemail.com (Postfix) with ESMTP id 02067100E6903 for ; Fri, 15 Jan 2021 14:12:06 +0000 (UTC) X-HE-Tag: match84_03155292752f X-Filterd-Recvd-Size: 2175 Received: from szxga07-in.huawei.com (szxga07-in.huawei.com [45.249.212.35]) by imf24.hostedemail.com (Postfix) with ESMTP for ; Fri, 15 Jan 2021 14:12:05 +0000 (UTC) Received: from DGGEMS406-HUB.china.huawei.com (unknown [172.30.72.58]) by szxga07-in.huawei.com (SkyGuard) with ESMTP id 4DHNPs5R0gz7VtF; Fri, 15 Jan 2021 22:10:57 +0800 (CST) Received: from huawei.com (10.175.100.227) by DGGEMS406-HUB.china.huawei.com (10.3.19.206) with Microsoft SMTP Server id 14.3.498.0; Fri, 15 Jan 2021 22:11:52 +0800 From: Tang Yizhou To: CC: , David Rientjes , KOSAKI Motohiro , Shakeel Butt , Michal Hocko Subject: [PATCH v2] mm, oom: Fix a comment in dump_task Date: Fri, 15 Jan 2021 22:23:14 +0800 Message-ID: <20210115142314.12903-1-tangyizhou@huawei.com> X-Mailer: git-send-email 2.22.0 MIME-Version: 1.0 X-Originating-IP: [10.175.100.227] X-CFilter-Loop: Reflected X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: If p is a kthread, it will be checked in oom_unkillable_task() so we can delete the corresponding comment. Signed-off-by: Tang Yizhou Cc: David Rientjes Cc: KOSAKI Motohiro Cc: Shakeel Butt Cc: Michal Hocko Acked-by: David Rientjes Acked-by: Michal Hocko --- v2: Update Cc list mm/oom_kill.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/mm/oom_kill.c b/mm/oom_kill.c index 04b19b7b5435..9f043ad29554 100644 --- a/mm/oom_kill.c +++ b/mm/oom_kill.c @@ -395,9 +395,8 @@ static int dump_task(struct task_struct *p, void *arg) task = find_lock_task_mm(p); if (!task) { /* - * This is a kthread or all of p's threads have already - * detached their mm's. There's no need to report - * them; they can't be oom killed anyway. + * All of p's threads have already detached their mm's. There's + * no need to report them; they can't be oom killed anyway. */ return 0; }