From patchwork Thu Jan 28 07:11:32 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Chaitanya Kulkarni X-Patchwork-Id: 12052311 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 23F9BC433E0 for ; Thu, 28 Jan 2021 07:16:16 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id AC27E64DD6 for ; Thu, 28 Jan 2021 07:16:15 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AC27E64DD6 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=wdc.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 36C3B6B0083; Thu, 28 Jan 2021 02:16:15 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 3429B6B0095; Thu, 28 Jan 2021 02:16:15 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 258DD6B0096; Thu, 28 Jan 2021 02:16:15 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0054.hostedemail.com [216.40.44.54]) by kanga.kvack.org (Postfix) with ESMTP id 1506B6B0083 for ; Thu, 28 Jan 2021 02:16:15 -0500 (EST) Received: from smtpin14.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id D92B83635 for ; Thu, 28 Jan 2021 07:16:14 +0000 (UTC) X-FDA: 77754325068.14.north18_4702bfa2759d Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin14.hostedemail.com (Postfix) with ESMTP id B99DE18229818 for ; Thu, 28 Jan 2021 07:16:14 +0000 (UTC) X-HE-Tag: north18_4702bfa2759d X-Filterd-Recvd-Size: 5422 Received: from esa1.hgst.iphmx.com (esa1.hgst.iphmx.com [68.232.141.245]) by imf42.hostedemail.com (Postfix) with ESMTP for ; Thu, 28 Jan 2021 07:16:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=wdc.com; i=@wdc.com; q=dns/txt; s=dkim.wdc.com; t=1611818174; x=1643354174; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=mzuBJgEjO7736zP2e3T55gtpCfO2cszPJHhO/o9ayC4=; b=qfRrFdPiavsixAcTtOgZ0mPHOJR7xSkdFXxASVNcYUftEAsVh95MQ2WM 8uZmIq5fNhPQglvGrgqb3LG/jjii9zlZh0TKOZnlejWVPZ/33cBKZRcFK 7P/OYH2R0Td8JqkrY5LYMLcbfH1psKaRBKcJccXm844KUI7f8/RdMJZXe lFhB3MHIiFHrRfbv/z31AWiyHo257ZWOlYhqnEUY11kazd4jVystJ5gQJ cxdbYTE7seFXnFgQWxC0zvKjs2J5qPMg4QNEDSHqbaMFqVBUdVLkbEK/v Wu6gPD68HYfTLkjuEjdUwL1oj+eTEYZwJ4GF3XnAiRN+T5455wB11DGOM w==; IronPort-SDR: Q5ouPltstpZnhWYh9k03RfShVKC4Z86V0Y2B1k0iCpXO5tCAnAQ4hLSBoQHoXPeeGXNWwN7kMT f5xFhoW6RRckPh3gJQXg6Sf+cImqCLvReUTnzZggMYcuefLE7ac2nhvtQXsbuP5v/y+Fetk+Zu v0OWoAb13eoW2JtHUVpY4SVv5w4CuewYBD/iwx4Bo4a+phWcNm5YN2mS6y7yk9kFYcBPUAPFjr 2oi37afhNsDUloaXxYSAPNE/MVWah+qtOqZ2e8pWIYQn2OJodzHBmgZQiSLHNbNWwhcD2oZ9Md c6w= X-IronPort-AV: E=Sophos;i="5.79,381,1602518400"; d="scan'208";a="268892742" Received: from h199-255-45-15.hgst.com (HELO uls-op-cesaep02.wdc.com) ([199.255.45.15]) by ob1.hgst.iphmx.com with ESMTP; 28 Jan 2021 15:16:11 +0800 IronPort-SDR: aUAV5Vyt80XcAfTXH9ghivf7ApYwQRiG6WEUXmePheMuNIZZzOUr7WJQVkb8H2HKbrvkxtP5il /QozRjLuHvj4at5k60D9qRIxftc4h8PlJYM31q08kLmBwW1teX/wkqIR4F3SU/4K0NqAbvbvg4 ZK57HlHsoK6+kK/p730KlXIMha4LoxbrC6JaZzFo7heG8PfZAFw+L95rV8B97ueRL65hL+Fsto W8NBLQO1Exhd4RR1FaGsWU6Dv+P3CsFavNJF71TbNNUJrlZe/tNHd0w6BaJIsHLt67PCjbh/WG FsWHSIOWkmwSulrq99GkZgaY Received: from uls-op-cesaip02.wdc.com ([10.248.3.37]) by uls-op-cesaep02.wdc.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Jan 2021 22:58:29 -0800 IronPort-SDR: g9DYrZw82vrtcoqwLuT41C5LPwtay4x47njX4TQvn100PG3qzIQDYIPSbD2aKZ0nambVfkCSmu JHC6z8/1ifbcXhuz1R2nfguMjBFRQ4RaTCr3wehJDb3ERuWQ1NBrP8es0szoYDQyY3216WdfEV JcMopMzzk+/Wudlq5O10ELulyKCOeTk+PuDGw5+9rtJas4CG58lZZY6nLuQYmFyKdDpDYbQYnL x05lIaxi3M2yfAJSgs6mfnc20aeVZIpUbieSq2c4z3+si2ic8ziehclZMxZZAWaM0XsUZa2+hJ /C8= WDCIronportException: Internal Received: from vm.labspan.wdc.com (HELO vm.sc.wdc.com) ([10.6.137.102]) by uls-op-cesaip02.wdc.com with ESMTP; 27 Jan 2021 23:16:11 -0800 From: Chaitanya Kulkarni To: linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, dm-devel@redhat.com, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, drbd-dev@lists.linbit.com, xen-devel@lists.xenproject.org, linux-nvme@lists.infradead.org, linux-scsi@vger.kernel.org, target-devel@vger.kernel.org, linux-fscrypt@vger.kernel.org, jfs-discussion@lists.sourceforge.net, linux-nilfs@vger.kernel.org, ocfs2-devel@oss.oracle.com, linux-pm@vger.kernel.org, linux-mm@kvack.org Cc: axboe@kernel.dk, philipp.reisner@linbit.com, lars.ellenberg@linbit.com, konrad.wilk@oracle.com, roger.pau@citrix.com, minchan@kernel.org, ngupta@vflare.org, sergey.senozhatsky.work@gmail.com, agk@redhat.com, snitzer@redhat.com, hch@lst.de, sagi@grimberg.me, chaitanya.kulkarni@wdc.com, martin.petersen@oracle.com, viro@zeniv.linux.org.uk, tytso@mit.edu, jaegeuk@kernel.org, ebiggers@kernel.org, djwong@kernel.org, shaggy@kernel.org, konishi.ryusuke@gmail.com, mark@fasheh.com, jlbec@evilplan.org, joseph.qi@linux.alibaba.com, damien.lemoal@wdc.com, naohiro.aota@wdc.com, jth@kernel.org, rjw@rjwysocki.net, len.brown@intel.com, pavel@ucw.cz, akpm@linux-foundation.org, hare@suse.de, gustavoars@kernel.org, tiwai@suse.de, alex.shi@linux.alibaba.com, asml.silence@gmail.com, ming.lei@redhat.com, tj@kernel.org, osandov@fb.com, bvanassche@acm.org, jefflexu@linux.alibaba.com Subject: [RFC PATCH 33/34] mm: use bio_new in swap_readpage Date: Wed, 27 Jan 2021 23:11:32 -0800 Message-Id: <20210128071133.60335-34-chaitanya.kulkarni@wdc.com> X-Mailer: git-send-email 2.22.1 In-Reply-To: <20210128071133.60335-1-chaitanya.kulkarni@wdc.com> References: <20210128071133.60335-1-chaitanya.kulkarni@wdc.com> MIME-Version: 1.0 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Signed-off-by: Chaitanya Kulkarni --- mm/page_io.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/mm/page_io.c b/mm/page_io.c index 25b321489703..7579485ccb5e 100644 --- a/mm/page_io.c +++ b/mm/page_io.c @@ -342,7 +342,7 @@ int __swap_writepage(struct page *page, struct writeback_control *wbc, return 0; } - bio = bio_alloc(sis->bdev, swap_page_sector(page), REQ_OP_WRITE, + bio = bio_new(sis->bdev, swap_page_sector(page), REQ_OP_WRITE, REQ_SWAP | wbc_to_write_flags(wbc), 1, GFP_NOIO); bio->bi_end_io = end_write_func; bio_add_page(bio, page, thp_size(page), 0); @@ -406,10 +406,8 @@ int swap_readpage(struct page *page, bool synchronous) } ret = 0; - bio = bio_alloc(GFP_KERNEL, 1); - bio_set_dev(bio, sis->bdev); - bio->bi_opf = REQ_OP_READ; - bio->bi_iter.bi_sector = swap_page_sector(page); + bio = bio_new(sis->bdev, swap_page_sector(page), REQ_OP_READ, 0, 1, + GFP_KERNEL); bio->bi_end_io = end_swap_bio_read; bio_add_page(bio, page, thp_size(page), 0);