From patchwork Sun Mar 14 08:37:16 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yafang Shao X-Patchwork-Id: 12137219 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.5 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3EF75C433DB for ; Sun, 14 Mar 2021 08:37:54 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id DCFA664EBE for ; Sun, 14 Mar 2021 08:37:53 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DCFA664EBE Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 803B96B0070; Sun, 14 Mar 2021 04:37:53 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7B2A46B0071; Sun, 14 Mar 2021 04:37:53 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 605026B0072; Sun, 14 Mar 2021 04:37:53 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0030.hostedemail.com [216.40.44.30]) by kanga.kvack.org (Postfix) with ESMTP id 438BA6B0070 for ; Sun, 14 Mar 2021 04:37:53 -0400 (EDT) Received: from smtpin17.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 004DC8249980 for ; Sun, 14 Mar 2021 08:37:52 +0000 (UTC) X-FDA: 77917826826.17.566896C Received: from mail-pj1-f45.google.com (mail-pj1-f45.google.com [209.85.216.45]) by imf16.hostedemail.com (Postfix) with ESMTP id 616B98019142 for ; Sun, 14 Mar 2021 08:37:52 +0000 (UTC) Received: by mail-pj1-f45.google.com with SMTP id bt4so7230792pjb.5 for ; Sun, 14 Mar 2021 00:37:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=m/XIknGvLR84rGMdwQ6aEaAVPb5smu+oD8b3vQ4IM8k=; b=aDVxzuZ8IcYGLj1RSwLhewC5PmVWu0dlfJ/36dzgZF9bSceI+blRlOfPsfNSxxW6O/ 8Ocjs9Fhv41QkxDt382bCQmXHCpkRJTCrCtCLC+itFc1tbyflTQPJA/Y/k590GKgeKic aINjnFc+852JOxRUIGUoZPPOgVQOo41HsbdxjUWmxE/7GghWYlqigSXAOlaKBJ0GIMOF vPKeaxLpQcc2WMYuRZcY66ufiCsAgNT98rwfoyr7wfEpDRvbOqigR/2ac9lqVgS0E0Lx FWHyyPQ5gWtKmm6WbX7qxF8rzq+wjmzWsfSIBQRYMs/EuQN9PDARAgq4B0uXfydA9GGE oFSA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=m/XIknGvLR84rGMdwQ6aEaAVPb5smu+oD8b3vQ4IM8k=; b=K1LKeyE05GRpitG3TY/wiv+mlH9nxbQDNcF3CzWsmLPlILNAXsDsv2dzDX6hgRbrKv 474l18dLmTckVLvc+TeMf726SzijiKboDhEi2cjl/Pt4rjZFd6suf0+SE1okNtAYtjxE 8VOwN8sJKEjW+leBrsF8RhOeApA/Drr1MrK3+/bYv4HD+j/k8xjKPElPqENwidNnkEMP +lOiekJGpesQXUCqfQvD86BaiLQqsnG+EHTCIX515vb2g4r1fAvO8B5pEWPe2T/O+Ksh HJKwlilMk3DfQnRIz3RoBWkMNsjTpGRAc/8ZHHGV5ACLZflZX8gNogzPfXdbpfi78DJg ZLfA== X-Gm-Message-State: AOAM533PXZXyE3i76uWc4yZHgc5u64kkwgVj9DNaqNNCzXIb2ZGBGSoR KSqGMKyMdFWupXX4g31oiSE= X-Google-Smtp-Source: ABdhPJzYICA0G5WYRTuswHJMdSVt3yyYJyCjLjSlEWppiO/c4hb0DLUOG9dnJfoMsAvVAQDIzepZog== X-Received: by 2002:a17:90b:1a86:: with SMTP id ng6mr7015003pjb.26.1615711071534; Sun, 14 Mar 2021 00:37:51 -0800 (PST) Received: from localhost.localdomain ([50.236.19.102]) by smtp.gmail.com with ESMTPSA id s28sm10462585pfd.155.2021.03.14.00.37.45 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sun, 14 Mar 2021 00:37:51 -0800 (PST) From: Yafang Shao To: pmladek@suse.com, willy@infradead.org, andriy.shevchenko@linux.intel.com, david@redhat.com, linmiaohe@huawei.com, vbabka@suse.cz, cl@linux.com, penberg@kernel.org, rientjes@google.com, iamjoonsoo.kim@lge.com, akpm@linux-foundation.org, rostedt@goodmis.org, sergey.senozhatsky@gmail.com, joe@perches.com Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, lkp@intel.com, Yafang Shao Subject: [PATCH v6 2/3] mm, slub: don't combine pr_err with INFO Date: Sun, 14 Mar 2021 16:37:16 +0800 Message-Id: <20210314083717.96380-3-laoar.shao@gmail.com> X-Mailer: git-send-email 2.24.3 (Apple Git-128) In-Reply-To: <20210314083717.96380-1-laoar.shao@gmail.com> References: <20210314083717.96380-1-laoar.shao@gmail.com> MIME-Version: 1.0 X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 616B98019142 X-Stat-Signature: sappjgswkq9cpjpxmo6pxthitwxxkka6 Received-SPF: none (gmail.com>: No applicable sender policy available) receiver=imf16; identity=mailfrom; envelope-from=""; helo=mail-pj1-f45.google.com; client-ip=209.85.216.45 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1615711072-492163 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: It is strange to combine "pr_err" with "INFO", so let's remove the prefix completely. This patch is motivated by David's comment[1]. - before the patch [ 8846.517809] INFO: Slab 0x00000000f42a2c60 objects=33 used=3 fp=0x0000000060d32ca8 flags=0x17ffffc0010200(slab|head) - after the patch [ 6343.396602] Slab 0x000000004382e02b objects=33 used=3 fp=0x000000009ae06ffc flags=0x17ffffc0010200(slab|head) [1]. https://lore.kernel.org/linux-mm/b9c0f2b6-e9b0-0c36-ebdd-2bc684c5a762@redhat.com/#t Suggested-by: Vlastimil Babka Signed-off-by: Yafang Shao Acked-by: Vlastimil Babka Reviewed-by: Miaohe Lin Reviewed-by: Andy Shevchenko Reviewed-by: David Hildenbrand Cc: Matthew Wilcox Acked-by: David Rientjes --- mm/slub.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/mm/slub.c b/mm/slub.c index ed3f728c1367..7ed388077633 100644 --- a/mm/slub.c +++ b/mm/slub.c @@ -624,7 +624,7 @@ static void print_track(const char *s, struct track *t, unsigned long pr_time) if (!t->addr) return; - pr_err("INFO: %s in %pS age=%lu cpu=%u pid=%d\n", + pr_err("%s in %pS age=%lu cpu=%u pid=%d\n", s, (void *)t->addr, pr_time - t->when, t->cpu, t->pid); #ifdef CONFIG_STACKTRACE { @@ -650,7 +650,7 @@ void print_tracking(struct kmem_cache *s, void *object) static void print_page_info(struct page *page) { - pr_err("INFO: Slab 0x%p objects=%u used=%u fp=0x%p flags=%#lx(%pGp)\n", + pr_err("Slab 0x%p objects=%u used=%u fp=0x%p flags=%#lx(%pGp)\n", page, page->objects, page->inuse, page->freelist, page->flags, &page->flags); @@ -707,7 +707,7 @@ static void print_trailer(struct kmem_cache *s, struct page *page, u8 *p) print_page_info(page); - pr_err("INFO: Object 0x%p @offset=%tu fp=0x%p\n\n", + pr_err("Object 0x%p @offset=%tu fp=0x%p\n\n", p, p - addr, get_freepointer(s, p)); if (s->flags & SLAB_RED_ZONE) @@ -800,7 +800,7 @@ static int check_bytes_and_report(struct kmem_cache *s, struct page *page, end--; slab_bug(s, "%s overwritten", what); - pr_err("INFO: 0x%p-0x%p @offset=%tu. First byte 0x%x instead of 0x%x\n", + pr_err("0x%p-0x%p @offset=%tu. First byte 0x%x instead of 0x%x\n", fault, end - 1, fault - addr, fault[0], value); print_trailer(s, page, object); @@ -3899,7 +3899,7 @@ static void list_slab_objects(struct kmem_cache *s, struct page *page, for_each_object(p, s, addr, page->objects) { if (!test_bit(__obj_to_index(s, addr, p), map)) { - pr_err("INFO: Object 0x%p @offset=%tu\n", p, p - addr); + pr_err("Object 0x%p @offset=%tu\n", p, p - addr); print_tracking(s, p); } }