Message ID | 20210324190626.564297-5-guro@fb.com (mailing list archive) |
---|---|
State | New, archived |
Headers | show
Return-Path: <SRS0=u5hr=IW=kvack.org=owner-linux-mm@kernel.org> X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-19.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0A73AC433E1 for <linux-mm@archiver.kernel.org>; Wed, 24 Mar 2021 19:06:42 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 99194619B1 for <linux-mm@archiver.kernel.org>; Wed, 24 Mar 2021 19:06:41 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 99194619B1 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=fb.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id D97D76B02EF; Wed, 24 Mar 2021 15:06:39 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CF96B8D0017; Wed, 24 Mar 2021 15:06:39 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B23256B02F3; Wed, 24 Mar 2021 15:06:39 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0229.hostedemail.com [216.40.44.229]) by kanga.kvack.org (Postfix) with ESMTP id 8552E6B02EF for <linux-mm@kvack.org>; Wed, 24 Mar 2021 15:06:39 -0400 (EDT) Received: from smtpin05.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 3E5518248047 for <linux-mm@kvack.org>; Wed, 24 Mar 2021 19:06:39 +0000 (UTC) X-FDA: 77955699318.05.199CDAA Received: from mx0a-00082601.pphosted.com (mx0a-00082601.pphosted.com [67.231.145.42]) by imf23.hostedemail.com (Postfix) with ESMTP id 1BB48A000381 for <linux-mm@kvack.org>; Wed, 24 Mar 2021 19:06:37 +0000 (UTC) Received: from pps.filterd (m0148461.ppops.net [127.0.0.1]) by mx0a-00082601.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id 12OJ30SH023852 for <linux-mm@kvack.org>; Wed, 24 Mar 2021 12:06:37 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fb.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : mime-version : content-transfer-encoding : content-type; s=facebook; bh=Ieh/wcC81zFFEwxI9926Yf3+LMLmn6Q4SUMf1JE6GPM=; b=hwxZIJ0Yh7ybjJwK0QbrtsH5dNtKA4QyKoonlP8x2piRsUGYViKrKRG9ykge5RPm/1VG YhnwZKNU9FY3EMUbJmsOk8EYF0VEjQ51hbAdPFr4NyG91vvOba5LcOikkYC81Mpyuzga Dr6iqv2ITjKWds66PDjwCKmu66ty/sk+hRs= Received: from mail.thefacebook.com ([163.114.132.120]) by mx0a-00082601.pphosted.com with ESMTP id 37fpghpvwe-3 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for <linux-mm@kvack.org>; Wed, 24 Mar 2021 12:06:37 -0700 Received: from intmgw001.05.prn6.facebook.com (2620:10d:c085:208::f) by mail.thefacebook.com (2620:10d:c085:11d::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Wed, 24 Mar 2021 12:06:36 -0700 Received: by devvm3388.prn0.facebook.com (Postfix, from userid 111017) id 937BB57ACF30; Wed, 24 Mar 2021 12:06:33 -0700 (PDT) From: Roman Gushchin <guro@fb.com> To: Dennis Zhou <dennis@kernel.org> CC: Tejun Heo <tj@kernel.org>, Christoph Lameter <cl@linux.com>, Andrew Morton <akpm@linux-foundation.org>, <linux-mm@kvack.org>, <linux-kernel@vger.kernel.org>, Roman Gushchin <guro@fb.com> Subject: [PATCH rfc 4/4] percpu: fix a comment about the chunks ordering Date: Wed, 24 Mar 2021 12:06:26 -0700 Message-ID: <20210324190626.564297-5-guro@fb.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20210324190626.564297-1-guro@fb.com> References: <20210324190626.564297-1-guro@fb.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-FB-Internal: Safe Content-Type: text/plain X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.369,18.0.761 definitions=2021-03-24_13:2021-03-24,2021-03-24 signatures=0 X-Proofpoint-Spam-Details: rule=fb_default_notspam policy=fb_default score=0 bulkscore=0 mlxlogscore=858 priorityscore=1501 suspectscore=0 malwarescore=0 spamscore=0 phishscore=0 lowpriorityscore=0 mlxscore=0 impostorscore=0 adultscore=0 clxscore=1015 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2103240137 X-FB-Internal: deliver X-Stat-Signature: 4s3r6jxcw3zecxc6mzg3cthzd7czpjqd X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 1BB48A000381 Received-SPF: none (fb.com>: No applicable sender policy available) receiver=imf23; identity=mailfrom; envelope-from="<prvs=2717991712=guro@fb.com>"; helo=mx0a-00082601.pphosted.com; client-ip=67.231.145.42 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1616612797-744526 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: <linux-mm.kvack.org> |
Series |
percpu: partial chunk depopulation
|
expand
|
diff --git a/mm/percpu.c b/mm/percpu.c index 148137f0fc0b..08fb6e5d3232 100644 --- a/mm/percpu.c +++ b/mm/percpu.c @@ -99,7 +99,10 @@ #include "percpu-internal.h" -/* the slots are sorted by free bytes left, 1-31 bytes share the same slot */ +/* + * The slots are sorted by the size of the biggest continuous free area. + * 1-31 bytes share the same slot. + */ #define PCPU_SLOT_BASE_SHIFT 5 /* chunks in slots below this are subject to being sidelined on failed alloc */ #define PCPU_SLOT_FAIL_THRESHOLD 3
Since the commit 3e54097beb22 ("percpu: manage chunks based on contig_bits instead of free_bytes") chunks are sorted based on the size of the biggest continuous free area instead of the total number of free bytes. Update the corresponding comment to reflect this. Signed-off-by: Roman Gushchin <guro@fb.com> --- mm/percpu.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)