From patchwork Wed Mar 31 08:51:56 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Oliver Glitta X-Patchwork-Id: 12174769 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 37E31C433E0 for ; Wed, 31 Mar 2021 08:52:03 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id C8D2C61998 for ; Wed, 31 Mar 2021 08:52:02 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C8D2C61998 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 6AEE56B0081; Wed, 31 Mar 2021 04:52:01 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 672FE6B0082; Wed, 31 Mar 2021 04:52:01 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 53A0A6B0083; Wed, 31 Mar 2021 04:52:01 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0122.hostedemail.com [216.40.44.122]) by kanga.kvack.org (Postfix) with ESMTP id 3C3016B0081 for ; Wed, 31 Mar 2021 04:52:01 -0400 (EDT) Received: from smtpin26.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id EB28045BC for ; Wed, 31 Mar 2021 08:52:00 +0000 (UTC) X-FDA: 77979552000.26.43E2461 Received: from mail-wm1-f43.google.com (mail-wm1-f43.google.com [209.85.128.43]) by imf28.hostedemail.com (Postfix) with ESMTP id 1E1DE20001D6 for ; Wed, 31 Mar 2021 08:51:59 +0000 (UTC) Received: by mail-wm1-f43.google.com with SMTP id t5-20020a1c77050000b029010e62cea9deso773353wmi.0 for ; Wed, 31 Mar 2021 01:52:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=Fwt0WLOhquJhgye7Yu7LsgU1jgDJ8L/oCfgCwbcLyss=; b=is3OwWphrHI3UOuP46knn5KlWCMcHkZHC05/gfR7trPJxNkYnd/f9IYazjk8kdgSlE BVpAoTGjiyDlmzpDqG0CtnZMujEKvPy4EApikV6/KfxWwL9aL8/zyzlTHg7XmS8sfl3P yJKaTuHcGiN42kwBVtX1r/iyFI3rJ7/Qoh0Quz1+QCJ+FKhqHp1dmYrbO7Rc3JanFqwo nxiLaQJX0cZ7UQMZr17GdKqQSyMgQN1KDOUaa/DW8lCnEbf+8Lg40GXm/L8NBLCz82fX 286EfLx0U5W9HhFb7G25jQbxvD+JNwG8KankOmLbPZHoJtiJgQ7BC2qYkRB86h/paDgI AAJg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=Fwt0WLOhquJhgye7Yu7LsgU1jgDJ8L/oCfgCwbcLyss=; b=hQmwpDAq2WFr82F/XdY+J9/v7GCoU3momf8PI48ol0vATKcpot77kyusXvQsYcS5yX ZeHLaw8C4DxiVgPnWlrdeckdjg5Dn4YfxdX4SoDqYK48JIoGMnpN6X3+hpwuwvnWTt3f EHwAgkWVVikej0MmMhEfdQwJQ4bEVTQLPh/BUVS3VrOnXWdLeUukuc3N3WPozsbJsFFc pN1ZXqa9Gr3P+eH+hPLThsSxQL3fHDGs5M6xtBbGgvyzH1+HeY8p1mef4XeX6VXvIjkv 1HTjPNoX3PUxK0R6ez13jKeYXBqbvVZ1lo24uexFYlalCoFXbi6JOfx3shZpZF52KQrJ ULkQ== X-Gm-Message-State: AOAM532Adp2Ve+ddP4sTilA7wwjgigyGdbFuhrZw3bF4B0qEuhuBOJPt N8JCudkuUtgUUVvkhS7xbFY= X-Google-Smtp-Source: ABdhPJxd3JD9ULyFgXV/3YWsbDHBUQvZMFyPOZc/ACB0UowVHZULQIZLTGjN2r3Y6FsMkp/wLQIlGg== X-Received: by 2002:a1c:bdc2:: with SMTP id n185mr2185771wmf.128.1617180719426; Wed, 31 Mar 2021 01:51:59 -0700 (PDT) Received: from oliver-Z170M-D3H.cuni.cz ([2001:718:1e03:5128:d1ec:8c5:2b34:58fe]) by smtp.gmail.com with ESMTPSA id m11sm3205346wrz.40.2021.03.31.01.51.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 31 Mar 2021 01:51:59 -0700 (PDT) From: glittao@gmail.com To: cl@linux.com, penberg@kernel.org, rientjes@google.com, iamjoonsoo.kim@lge.com, akpm@linux-foundation.org, vbabka@suse.cz Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, Oliver Glitta Subject: [PATCH v3 2/2] slub: remove resiliency_test() function Date: Wed, 31 Mar 2021 10:51:56 +0200 Message-Id: <20210331085156.5028-2-glittao@gmail.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20210331085156.5028-1-glittao@gmail.com> References: <20210331085156.5028-1-glittao@gmail.com> X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 1E1DE20001D6 X-Stat-Signature: kz4p6ecu1gzut6imx4te85f8noa7yqdi Received-SPF: none (gmail.com>: No applicable sender policy available) receiver=imf28; identity=mailfrom; envelope-from=""; helo=mail-wm1-f43.google.com; client-ip=209.85.128.43 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1617180719-294980 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: From: Oliver Glitta Function resiliency_test() is hidden behind #ifdef SLUB_RESILIENCY_TEST that is not part of Kconfig, so nobody runs it. This function is replaced with KUnit test for SLUB added by the previous patch "selftests: add a KUnit test for SLUB debugging functionality". Signed-off-by: Oliver Glitta Acked-by: Vlastimil Babka Acked-by: David Rientjes --- mm/slub.c | 64 ------------------------------------------------------- 1 file changed, 64 deletions(-) diff --git a/mm/slub.c b/mm/slub.c index 7083e89432d0..6eff5754895f 100644 --- a/mm/slub.c +++ b/mm/slub.c @@ -153,9 +153,6 @@ static inline bool kmem_cache_has_cpu_partial(struct kmem_cache *s) * - Variable sizing of the per node arrays */ -/* Enable to test recovery from slab corruption on boot */ -#undef SLUB_RESILIENCY_TEST - /* Enable to log cmpxchg failures */ #undef SLUB_DEBUG_CMPXCHG @@ -4923,66 +4920,6 @@ static int list_locations(struct kmem_cache *s, char *buf, } #endif /* CONFIG_SLUB_DEBUG */ -#ifdef SLUB_RESILIENCY_TEST -static void __init resiliency_test(void) -{ - u8 *p; - int type = KMALLOC_NORMAL; - - BUILD_BUG_ON(KMALLOC_MIN_SIZE > 16 || KMALLOC_SHIFT_HIGH < 10); - - pr_err("SLUB resiliency testing\n"); - pr_err("-----------------------\n"); - pr_err("A. Corruption after allocation\n"); - - p = kzalloc(16, GFP_KERNEL); - p[16] = 0x12; - pr_err("\n1. kmalloc-16: Clobber Redzone/next pointer 0x12->0x%p\n\n", - p + 16); - - validate_slab_cache(kmalloc_caches[type][4]); - - /* Hmmm... The next two are dangerous */ - p = kzalloc(32, GFP_KERNEL); - p[32 + sizeof(void *)] = 0x34; - pr_err("\n2. kmalloc-32: Clobber next pointer/next slab 0x34 -> -0x%p\n", - p); - pr_err("If allocated object is overwritten then not detectable\n\n"); - - validate_slab_cache(kmalloc_caches[type][5]); - p = kzalloc(64, GFP_KERNEL); - p += 64 + (get_cycles() & 0xff) * sizeof(void *); - *p = 0x56; - pr_err("\n3. kmalloc-64: corrupting random byte 0x56->0x%p\n", - p); - pr_err("If allocated object is overwritten then not detectable\n\n"); - validate_slab_cache(kmalloc_caches[type][6]); - - pr_err("\nB. Corruption after free\n"); - p = kzalloc(128, GFP_KERNEL); - kfree(p); - *p = 0x78; - pr_err("1. kmalloc-128: Clobber first word 0x78->0x%p\n\n", p); - validate_slab_cache(kmalloc_caches[type][7]); - - p = kzalloc(256, GFP_KERNEL); - kfree(p); - p[50] = 0x9a; - pr_err("\n2. kmalloc-256: Clobber 50th byte 0x9a->0x%p\n\n", p); - validate_slab_cache(kmalloc_caches[type][8]); - - p = kzalloc(512, GFP_KERNEL); - kfree(p); - p[512] = 0xab; - pr_err("\n3. kmalloc-512: Clobber redzone 0xab->0x%p\n\n", p); - validate_slab_cache(kmalloc_caches[type][9]); -} -#else -#ifdef CONFIG_SYSFS -static void resiliency_test(void) {}; -#endif -#endif /* SLUB_RESILIENCY_TEST */ - #ifdef CONFIG_SYSFS enum slab_stat_type { SL_ALL, /* All slabs */ @@ -5831,7 +5768,6 @@ static int __init slab_sysfs_init(void) } mutex_unlock(&slab_mutex); - resiliency_test(); return 0; }