diff mbox series

[PATCH-next,5/5] mm/vmalloc: remove an empty line

Message ID 20210402202237.20334-5-urezki@gmail.com (mailing list archive)
State New, archived
Headers show
Series [PATCH-next,1/5] lib/test_vmalloc.c: remove two kvfree_rcu() tests | expand

Commit Message

Uladzislau Rezki April 2, 2021, 8:22 p.m. UTC 
Signed-off-by: Uladzislau Rezki (Sony) <urezki@gmail.com>
---
 mm/vmalloc.c | 1 -
 1 file changed, 1 deletion(-)

Comments

Souptick Joarder April 2, 2021, 8:30 p.m. UTC | #1 
On Sat, Apr 3, 2021 at 1:53 AM Uladzislau Rezki (Sony) <urezki@gmail.com> wrote:
>
> Signed-off-by: Uladzislau Rezki (Sony) <urezki@gmail.com>

How about merging it with patch [4/5] ?

> ---
>  mm/vmalloc.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/mm/vmalloc.c b/mm/vmalloc.c
> index 093c7e034ca2..1e643280cbcf 100644
> --- a/mm/vmalloc.c
> +++ b/mm/vmalloc.c
> @@ -1503,7 +1503,6 @@ static struct vmap_area *alloc_vmap_area(unsigned long size,
>         va->va_end = addr + size;
>         va->vm = NULL;
>
> -
>         spin_lock(&vmap_area_lock);
>         insert_vmap_area(va, &vmap_area_root, &vmap_area_list);
>         spin_unlock(&vmap_area_lock);
> --
> 2.20.1
>
>
Uladzislau Rezki April 2, 2021, 8:58 p.m. UTC | #2 
> On Sat, Apr 3, 2021 at 1:53 AM Uladzislau Rezki (Sony) <urezki@gmail.com> wrote:
> >
> > Signed-off-by: Uladzislau Rezki (Sony) <urezki@gmail.com>
> 
> How about merging it with patch [4/5] ?
> 
I had in mind such concern. Yes we can do a squashing with [4/5].
If there are other comments i will rework whole series if not we
can ask Andrew to merge it.

Thank you.

--
Vlad Rezki
diff mbox series

Patch

diff --git a/mm/vmalloc.c b/mm/vmalloc.c
index 093c7e034ca2..1e643280cbcf 100644
--- a/mm/vmalloc.c
+++ b/mm/vmalloc.c
@@ -1503,7 +1503,6 @@  static struct vmap_area *alloc_vmap_area(unsigned long size,
 	va->va_end = addr + size;
 	va->vm = NULL;
 
-
 	spin_lock(&vmap_area_lock);
 	insert_vmap_area(va, &vmap_area_root, &vmap_area_list);
 	spin_unlock(&vmap_area_lock);