diff mbox series

[v7,7/8] x86/Kconfig: Introduce ARCH_MHP_MEMMAP_ON_MEMORY_ENABLE

Message ID 20210408121804.10440-8-osalvador@suse.de (mailing list archive)
State New, archived
Headers show
Series [v7,1/8] drivers/base/memory: Introduce memory_block_{online,offline} | expand

Commit Message

Oscar Salvador April 8, 2021, 12:18 p.m. UTC 
Enable x86_64 platform to use the MHP_MEMMAP_ON_MEMORY feature.

Signed-off-by: Oscar Salvador <osalvador@suse.de>
Reviewed-by: David Hildenbrand <david@redhat.com>
---
 arch/x86/Kconfig | 3 +++
 1 file changed, 3 insertions(+)

Comments

Christoph Hellwig April 8, 2021, 1:36 p.m. UTC | #1 
On Thu, Apr 08, 2021 at 02:18:03PM +0200, Oscar Salvador wrote:
> Enable x86_64 platform to use the MHP_MEMMAP_ON_MEMORY feature.
> +config ARCH_MHP_MEMMAP_ON_MEMORY_ENABLE
> +	def_bool y

This needs to go into a common file, with the architectures just
selecting the symbol.
David Hildenbrand April 8, 2021, 6:19 p.m. UTC | #2 
On 08.04.21 15:36, Christoph Hellwig wrote:
> On Thu, Apr 08, 2021 at 02:18:03PM +0200, Oscar Salvador wrote:
>> Enable x86_64 platform to use the MHP_MEMMAP_ON_MEMORY feature.
>> +config ARCH_MHP_MEMMAP_ON_MEMORY_ENABLE
>> +	def_bool y
> 
> This needs to go into a common file, with the architectures just
> selecting the symbol.
> 

I'd like to point out that we have plenty of counter examples. Meaning: 
it's really hard to figure out what the correct way is. Unfortunately, 
the correct way also doesn't seem to be documented :(
diff mbox series

Patch

diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig
index 2792879d398e..9f0211df1746 100644
--- a/arch/x86/Kconfig
+++ b/arch/x86/Kconfig
@@ -2433,6 +2433,9 @@  config ARCH_ENABLE_MEMORY_HOTREMOVE
 	def_bool y
 	depends on MEMORY_HOTPLUG
 
+config ARCH_MHP_MEMMAP_ON_MEMORY_ENABLE
+	def_bool y
+
 config USE_PERCPU_NUMA_NODE_ID
 	def_bool y
 	depends on NUMA