From patchwork Fri Apr 9 12:09:57 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mel Gorman X-Patchwork-Id: 12193997 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A7642C433B4 for ; Fri, 9 Apr 2021 12:10:04 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 17F1C610CB for ; Fri, 9 Apr 2021 12:10:04 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 17F1C610CB Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=techsingularity.net Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 984216B006E; Fri, 9 Apr 2021 08:10:03 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 91B896B0070; Fri, 9 Apr 2021 08:10:03 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7ADC16B0074; Fri, 9 Apr 2021 08:10:03 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0150.hostedemail.com [216.40.44.150]) by kanga.kvack.org (Postfix) with ESMTP id 5C1856B006E for ; Fri, 9 Apr 2021 08:10:03 -0400 (EDT) Received: from smtpin09.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 15077AF9C for ; Fri, 9 Apr 2021 12:10:03 +0000 (UTC) X-FDA: 78012710286.09.A5D3E91 Received: from outbound-smtp15.blacknight.com (outbound-smtp15.blacknight.com [46.22.139.232]) by imf13.hostedemail.com (Postfix) with ESMTP id DABBFE00010C for ; Fri, 9 Apr 2021 12:09:59 +0000 (UTC) Received: from mail.blacknight.com (pemlinmail04.blacknight.ie [81.17.254.17]) by outbound-smtp15.blacknight.com (Postfix) with ESMTPS id 2F48B1C3D28 for ; Fri, 9 Apr 2021 13:09:59 +0100 (IST) Received: (qmail 12263 invoked from network); 9 Apr 2021 12:09:59 -0000 Received: from unknown (HELO techsingularity.net) (mgorman@techsingularity.net@[84.203.22.4]) by 81.17.254.9 with ESMTPSA (AES256-SHA encrypted, authenticated); 9 Apr 2021 12:09:59 -0000 Date: Fri, 9 Apr 2021 13:09:57 +0100 From: Mel Gorman To: Andrew Morton Cc: Linux-MM , LKML , Oscar Salvador , Michal Hocko , "Michael S. Tsirkin" , David Hildenbrand , Vlastimil Babka , Alexander Duyck , Minchan Kim Subject: [PATCH] mm/memory_hotplug: Make unpopulated zones PCP structures unreachable during hot remove Message-ID: <20210409120957.GM3697@techsingularity.net> MIME-Version: 1.0 Content-Disposition: inline User-Agent: Mutt/1.10.1 (2018-07-13) X-Stat-Signature: 1w8x6gyprujyd61nrk8c9n3ibaiie3jx X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: DABBFE00010C Received-SPF: none (techsingularity.net>: No applicable sender policy available) receiver=imf13; identity=mailfrom; envelope-from=""; helo=outbound-smtp15.blacknight.com; client-ip=46.22.139.232 X-HE-DKIM-Result: none/none X-HE-Tag: 1617970199-660261 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: zone_pcp_reset allegedly protects against a race with drain_pages using local_irq_save but this is bogus. local_irq_save only operates on the local CPU. If memory hotplug is running on CPU A and drain_pages is running on CPU B, disabling IRQs on CPU A does not affect CPU B and offers no protection. This patch reorders memory hotremove such that the PCP structures relevant to the zone are no longer reachable by the time the structures are freed. With this reordering, no protection is required to prevent a use-after-free and the IRQs can be left enabled. zone_pcp_reset is renamed to zone_pcp_destroy to make it clear that the per-cpu structures are deleted when the function returns. Signed-off-by: Mel Gorman --- mm/internal.h | 2 +- mm/memory_hotplug.c | 10 +++++++--- mm/page_alloc.c | 22 ++++++++++++++++------ 3 files changed, 24 insertions(+), 10 deletions(-) diff --git a/mm/internal.h b/mm/internal.h index 09adf152a10b..cc34ce4461b7 100644 --- a/mm/internal.h +++ b/mm/internal.h @@ -203,7 +203,7 @@ extern void free_unref_page(struct page *page); extern void free_unref_page_list(struct list_head *list); extern void zone_pcp_update(struct zone *zone); -extern void zone_pcp_reset(struct zone *zone); +extern void zone_pcp_destroy(struct zone *zone); extern void zone_pcp_disable(struct zone *zone); extern void zone_pcp_enable(struct zone *zone); diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c index 0cdbbfbc5757..3d059c9f9c2d 100644 --- a/mm/memory_hotplug.c +++ b/mm/memory_hotplug.c @@ -1687,12 +1687,16 @@ int __ref offline_pages(unsigned long start_pfn, unsigned long nr_pages) zone->nr_isolate_pageblock -= nr_pages / pageblock_nr_pages; spin_unlock_irqrestore(&zone->lock, flags); - zone_pcp_enable(zone); - /* removal success */ adjust_managed_page_count(pfn_to_page(start_pfn), -nr_pages); zone->present_pages -= nr_pages; + /* + * Restore PCP after managed pages has been updated. Unpopulated + * zones PCP structures will remain unusable. + */ + zone_pcp_enable(zone); + pgdat_resize_lock(zone->zone_pgdat, &flags); zone->zone_pgdat->node_present_pages -= nr_pages; pgdat_resize_unlock(zone->zone_pgdat, &flags); @@ -1700,8 +1704,8 @@ int __ref offline_pages(unsigned long start_pfn, unsigned long nr_pages) init_per_zone_wmark_min(); if (!populated_zone(zone)) { - zone_pcp_reset(zone); build_all_zonelists(NULL); + zone_pcp_destroy(zone); } else zone_pcp_update(zone); diff --git a/mm/page_alloc.c b/mm/page_alloc.c index 5e8aedb64b57..d6c3db853552 100644 --- a/mm/page_alloc.c +++ b/mm/page_alloc.c @@ -8946,18 +8946,29 @@ void zone_pcp_disable(struct zone *zone) void zone_pcp_enable(struct zone *zone) { - __zone_set_pageset_high_and_batch(zone, zone->pageset_high, zone->pageset_batch); + /* + * If the zone is populated, restore the high and batch counts. + * If unpopulated, leave the high and batch count as 0 and 1 + * respectively as done by zone_pcp_disable. The per-cpu + * structures will later be freed by zone_pcp_destroy. + */ + if (populated_zone(zone)) + __zone_set_pageset_high_and_batch(zone, zone->pageset_high, zone->pageset_batch); + mutex_unlock(&pcp_batch_high_lock); } -void zone_pcp_reset(struct zone *zone) +/* + * Called when a zone has been hot-removed. At this point, the PCP has been + * drained, disabled and the zone is removed from the zonelists so the + * structures are no longer in use. PCP was disabled/drained by + * zone_pcp_disable. This function will drain any remaining vmstat deltas. + */ +void zone_pcp_destroy(struct zone *zone) { - unsigned long flags; int cpu; struct per_cpu_pageset *pset; - /* avoid races with drain_pages() */ - local_irq_save(flags); if (zone->pageset != &boot_pageset) { for_each_online_cpu(cpu) { pset = per_cpu_ptr(zone->pageset, cpu); @@ -8966,7 +8977,6 @@ void zone_pcp_reset(struct zone *zone) free_percpu(zone->pageset); zone->pageset = &boot_pageset; } - local_irq_restore(flags); } #ifdef CONFIG_MEMORY_HOTREMOVE