From patchwork Fri Apr 9 20:52:48 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mike Kravetz X-Patchwork-Id: 12195071 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,MSGID_FROM_MTA_HEADER,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 837F1C433B4 for ; Fri, 9 Apr 2021 20:53:33 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 11DA861108 for ; Fri, 9 Apr 2021 20:53:33 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 11DA861108 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=oracle.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id A00196B0070; Fri, 9 Apr 2021 16:53:32 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 95F986B0071; Fri, 9 Apr 2021 16:53:32 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 763A56B0072; Fri, 9 Apr 2021 16:53:32 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0204.hostedemail.com [216.40.44.204]) by kanga.kvack.org (Postfix) with ESMTP id 4744B6B0070 for ; Fri, 9 Apr 2021 16:53:32 -0400 (EDT) Received: from smtpin29.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 03557AF68 for ; Fri, 9 Apr 2021 20:53:32 +0000 (UTC) X-FDA: 78014029464.29.5D00334 Received: from userp2130.oracle.com (userp2130.oracle.com [156.151.31.86]) by imf10.hostedemail.com (Postfix) with ESMTP id 882DA40002D3 for ; Fri, 9 Apr 2021 20:53:27 +0000 (UTC) Received: from pps.filterd (userp2130.oracle.com [127.0.0.1]) by userp2130.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 139KoYvq128542; Fri, 9 Apr 2021 20:53:16 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : content-transfer-encoding : content-type : mime-version; s=corp-2020-01-29; bh=bt9Rgw2Wi1977yVo8yxhNFJ9syZSk12iVGxQE7xzr7g=; b=DOCtLnHK9Kraut3bf6SOVVcIIZpL6hhxF/kSj4ENTxQMElv5un242vrtBLz0Nii1x2Bm 1zfufmryfWUVgxkigoeMyg/21vfQSuYEZSklUIoSp1ExTZ87UqY41Peeh8XFPI269eEP W1ZQB15A4RcyfkoXFGx0uz8mMckkp7Ptg/KLW28amdOOrVR2PcPwBRjZr+qOleEkdn24 HbQtG4RQQLOYgVgSH6lXcISAjOvpulhez0OO4zonEP19xwZ/VL5+CyJfgEJpCnFZpGff ozeTNub16BLgM9LorlGXST+gRxJabSmojx0MM5KUUNXUcVh6NhkEjAFGZ/oqjous6lXQ vw== Received: from aserp3020.oracle.com (aserp3020.oracle.com [141.146.126.70]) by userp2130.oracle.com with ESMTP id 37rva6apk7-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 09 Apr 2021 20:53:16 +0000 Received: from pps.filterd (aserp3020.oracle.com [127.0.0.1]) by aserp3020.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 139KjSfU174393; Fri, 9 Apr 2021 20:53:15 GMT Received: from nam10-bn7-obe.outbound.protection.outlook.com (mail-bn7nam10lp2101.outbound.protection.outlook.com [104.47.70.101]) by aserp3020.oracle.com with ESMTP id 37rvb71qjn-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 09 Apr 2021 20:53:15 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Ihnz3nX559IqwtZLMlfUkRtMDDvQBExiyrX3g8dEhnRJSvPR76o2JDU8E0DLUeAKn6EOVQ9MHTyIbyHJ+t/3wC9HJ9ICzuwBfXH+GDUIXJogPXgsTUcbCfRXl5Deb/o6xBAbgy15WuC4sn1Ec5eRvVwwExx4P6M83iXRMWPHutBqxT+fmyu1gsNm1Jj5CAN0AdUXJ57Cy9g0fCxN4ka0VkC6QKEaE60Txve95+NYt6/BvNVsmn7LesDMB+esC0UeBpv/8Z26Ogrwi0qkc6ou7QW26nuetsT2TD2I5HtngbGZ9hb+T2up/dIJkTEUKwgNZHLJRAhBVYNkqsujDkVH+w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=bt9Rgw2Wi1977yVo8yxhNFJ9syZSk12iVGxQE7xzr7g=; b=TQPYeWQEmwUvPuZefaxATnUuJtsRrb+rx54WRUBRRwpN/WAtTQZXB4QbM7KOCHo9R2nbm3w6j6jhnYg+UfR+mYIAOwPOaQ7HHOGH7rZOggz70WHClwYCBm779nnpFELrdyd/PdkAYPivV8Xady+hJfXA6ntBvru6dE9B2i/Dg+tbd9oHPYzJeAEKzhcq3RW9gHlmkPVYz1ywRYQIVtWDqXgI65SZ71otvMhc45a827DT7Mi1qFKWvswXuzeXxtIW9c1MlBMFrFvZgFLCGJOc4VblM4H5YzJ42WpnmFfB+OrYZ5WzoSfzOJdtXKLyixXEgpqeeIF9R3e7IQTNbAUpTw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=bt9Rgw2Wi1977yVo8yxhNFJ9syZSk12iVGxQE7xzr7g=; b=BNp8vIwiGZw8JFXBo7MxLadHzDoWONpBFQ1Nvl3TSWjzQoGcEtBgGzcnYO7zfuYc+9jdnqQkk0Q/IQziTKylAV2Z9Qfa0/Jke13HlzBtCbK15J/HMTpDcYuDx26wDK2WgDzfTfNO02Lsgb+4uxqyFLP9drgMvt+byq+xzZxPImc= Authentication-Results: kvack.org; dkim=none (message not signed) header.d=none;kvack.org; dmarc=none action=none header.from=oracle.com; Received: from BY5PR10MB4196.namprd10.prod.outlook.com (2603:10b6:a03:20d::23) by BY5PR10MB3972.namprd10.prod.outlook.com (2603:10b6:a03:1b6::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3999.32; Fri, 9 Apr 2021 20:53:13 +0000 Received: from BY5PR10MB4196.namprd10.prod.outlook.com ([fe80::980e:61ba:57d2:47ee]) by BY5PR10MB4196.namprd10.prod.outlook.com ([fe80::980e:61ba:57d2:47ee%7]) with mapi id 15.20.4020.018; Fri, 9 Apr 2021 20:53:13 +0000 From: Mike Kravetz To: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Andrew Morton Cc: Roman Gushchin , Michal Hocko , Shakeel Butt , Oscar Salvador , David Hildenbrand , Muchun Song , David Rientjes , Miaohe Lin , Peter Zijlstra , Matthew Wilcox , HORIGUCHI NAOYA , "Aneesh Kumar K . V" , Waiman Long , Peter Xu , Mina Almasry , Hillf Danton , Joonsoo Kim , Barry Song , Will Deacon , Mike Kravetz Subject: [PATCH v5 2/8] hugetlb: no need to drop hugetlb_lock to call cma_release Date: Fri, 9 Apr 2021 13:52:48 -0700 Message-Id: <20210409205254.242291-3-mike.kravetz@oracle.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20210409205254.242291-1-mike.kravetz@oracle.com> References: <20210409205254.242291-1-mike.kravetz@oracle.com> X-Originating-IP: [50.38.35.18] X-ClientProxiedBy: CO1PR15CA0050.namprd15.prod.outlook.com (2603:10b6:101:1f::18) To BY5PR10MB4196.namprd10.prod.outlook.com (2603:10b6:a03:20d::23) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from monkey.oracle.com (50.38.35.18) by CO1PR15CA0050.namprd15.prod.outlook.com (2603:10b6:101:1f::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4020.16 via Frontend Transport; Fri, 9 Apr 2021 20:53:12 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 758335e7-909d-4e1e-ee17-08d8fb997da2 X-MS-TrafficTypeDiagnostic: BY5PR10MB3972: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:4125; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: FWFcgWBTToIP1DTNhdDflvAjfcrigng0wEZa/MTZR5ifLJyB3aD6c5EuPNKHI8iGYk/WI4qXyrCGOATYfu9X5nOjaK61g/PsbzS7mVmTVfnOdagcchqtCPrG1JL4l+NXAAT2QYw41JIHpbGkSxXVGWHUOysrPjN6ZpQs2JOxY1uSUhEytWOKJfok4+MmlKgROdAB3BZUr+eDcKBPayZFpcV4URZszleusZDEeemUoVbvXrjRxiq8JeDBiOAphEnRNCuqDnVQcggUaej0abBgiwRm605VOSOqP8SaJW5gQpEezJXjEixba/xNJmbQhTtk0OsSax3DMBqgKBeZ1migRXXU22q0Zi2i8bIlEOvxYr0vZiVRNRY8eXtfX4I7mEGwyXK8BzTeTw7hiFd8CT3h0guAVjUmn7mELl3DynqKYfxKbTQz+1dKB48F1ho+SBy9WS34D9jBmmevCpPo9LUXvT2zDz8uT2Edov5BfBmXG/Qm3h5OFq3qHC2zmeYgJ4tcwiUnUxrkHZFVdXAVEuqoYcF7qWN2/m1lz0kic9rLgpu829b2q9NdH9eaKwrDWrJBwtPpXZCdSVPKvsiLfcZlm9wC0vg+oGYUmpFrB/p3lVn4kpo/5hHc+jDO+ASSD/U+ol1P1USqB5XOmJFnQioRaRIhx1WDz7E62g8LQvtSziLR0hJM3g1pPIuxE9OAYmH9 X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BY5PR10MB4196.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(346002)(396003)(376002)(366004)(136003)(39860400002)(38100700001)(5660300002)(66946007)(7416002)(956004)(6486002)(83380400001)(66556008)(8936002)(66476007)(4326008)(316002)(6666004)(6916009)(54906003)(44832011)(7696005)(2906002)(478600001)(1076003)(52116002)(16526019)(38350700001)(107886003)(36756003)(26005)(86362001)(8676002)(186003)(2616005);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: tZEu7sr7r4Li06yIIrpnLJVXvm/pk7nImDQ/JlkW0IFzzbAQIjAMCIM1VIkL1XXY60cpxi9ZSGDahLo7n9NQiwdQe3EkwsSJrfKkG3slx9STfGr/S9+IsX7DRcK5I/wK/nQa7nYi2jDGkMRmkk1oPzIFYIQcHA/m1dRbFw1JpzrrWsNfSxOqqPAPfgupHqAydt0wYANz6J/tzcw0I/AqpVvwUaSE8f0hP7J5iWCUfCgVdYOufgpjixIKDB6rnqolivFTwmPQ+EIPRPQ0faurK5Mrlzo3tj0QMDqrzHoT4k4woaT7HE1yw87GO2zNXVHZlAltkKeQk/BQ1d4Im797F3305kwnoA7EEkSImmoJSqPycIlz50J4GlRq6M0H1WI/FGX7bzzgg7Jl44i+dDyHTng7ao3me/wLnHikOZyU/sQPaxJzKKIg0tU4/448UQQXiG/bpqhYnHX7BZYGeXBiF1W82nIT4effbfsj6Em3lwl5hj4afs1hz/kcXn56XmIVqdXHmT8gwE6qDBXgAO3lg6NcA4Lbopz3DrZSJaKKPteB2qsKFQqSLPRab+utCBso0Dha60mASZM2YCDSEAlkQyQ4HsEWNbl8ZC+raGmYg3PU34JyuG6B41KV3pNCHRfx474Oq3vKgSyoiyAP0i9Up8OaaQERFst2RdlXyng5oiUHcI5PCzmaJnWqGi20ROeQMbaAv55YDLLz6wd+QkxLBVmj1Ejf5DBGGBXCdj0YAfdtwp860CTSg3fChTY7/rQ0G4X680IYrJEe+c/y6du1drzXFdsUnZezcEM/n56E3B7QB/pTuBt6FvJs2ityK2zzS5Q3k/7YjI3jnefyEByLbxg1gOJxUTK52TuECM5Hq5/sYTC+E9wvucs3Hdd2+HNGY3u72iTl0ms0qin6zs3apKmk6tlCITsddqELDEkg/Z4nfWr/lKoJY5ZatD2UjnsjUeLXWBF58abOIxc5fcur4B5a7ihcAIAUlPIjLDejVDYhabnBsyUVw2PkdnW0Mk9vBEQ1zb7LoqRr6tPUgfz3SyxCOblcfihEn0PKEEvYBPpM9TKe3RCZtyKuE1C9Iq7lz7Dz4MgZQ5h6jq3TjZ8ulhxPg1gC5GwGOuVI1fPvrqFAHbnYBuJ+G8yfHfFcE1uRxg3HrlzyoQF43nTTbo0hBk/KoLQGxNidet+QSqLmBULNYtDDORorT8omL9JtbyFokkDKvEiPaqaNQaQplnFrkqyWkxuYHtp3VAI7JsG7iwI26WHwBgNX+R9/cVBT3I8y6hG32gGvp4muCiBTaiATNrCSBXJV0mPRNVPN4amqrv3oNzGohn14fszfRmtKd/e+ X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 758335e7-909d-4e1e-ee17-08d8fb997da2 X-MS-Exchange-CrossTenant-AuthSource: BY5PR10MB4196.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Apr 2021 20:53:13.1588 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: rPp/PjwDavGe/df5pzBVlGsvM8Zn5gX9InAesxBZ19VGpKwGNQ2UMbmgTCXiQ6k7kk5CRcOgeXgy9VidXYQHDA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR10MB3972 X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=9949 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 mlxlogscore=999 malwarescore=0 mlxscore=0 suspectscore=0 adultscore=0 spamscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2104060000 definitions=main-2104090152 X-Proofpoint-GUID: X_rOirQhibz4gh813l9hcsas-iZuZMDq X-Proofpoint-ORIG-GUID: X_rOirQhibz4gh813l9hcsas-iZuZMDq X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=9949 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 clxscore=1015 lowpriorityscore=0 suspectscore=0 adultscore=0 mlxlogscore=999 bulkscore=0 priorityscore=1501 impostorscore=0 phishscore=0 mlxscore=0 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2104060000 definitions=main-2104090152 X-Rspamd-Queue-Id: 882DA40002D3 X-Stat-Signature: 43zrticxko4aegnip3o65mbac6meky9n X-Rspamd-Server: rspam02 Received-SPF: none (oracle.com>: No applicable sender policy available) receiver=imf10; identity=mailfrom; envelope-from=""; helo=userp2130.oracle.com; client-ip=156.151.31.86 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1618001607-328842 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Now that cma_release is non-blocking and irq safe, there is no need to drop hugetlb_lock before calling. Signed-off-by: Mike Kravetz Acked-by: Roman Gushchin Acked-by: Michal Hocko Reviewed-by: Oscar Salvador Reviewed-by: David Hildenbrand --- mm/hugetlb.c | 6 ------ 1 file changed, 6 deletions(-) diff --git a/mm/hugetlb.c b/mm/hugetlb.c index 07a95b8623ee..3a10b96a2124 100644 --- a/mm/hugetlb.c +++ b/mm/hugetlb.c @@ -1348,14 +1348,8 @@ static void update_and_free_page(struct hstate *h, struct page *page) set_compound_page_dtor(page, NULL_COMPOUND_DTOR); set_page_refcounted(page); if (hstate_is_gigantic(h)) { - /* - * Temporarily drop the hugetlb_lock, because - * we might block in free_gigantic_page(). - */ - spin_unlock(&hugetlb_lock); destroy_compound_gigantic_page(page, huge_page_order(h)); free_gigantic_page(page, huge_page_order(h)); - spin_lock(&hugetlb_lock); } else { __free_pages(page, huge_page_order(h)); }