[04/13] kernel/resource: fix return code check in __request_free_mem_region

Commit Message

Andrew Morton May 15, 2021, 12:27 a.m. UTC

From: Alistair Popple <[e-mail]>
Subject: kernel/resource: fix return code check in __request_free_mem_region

Splitting an earlier version of a patch that allowed calling
__request_region() while holding the resource lock into a series of
patches required changing the return code for the newly introduced
__request_region_locked().

Unfortunately this change was not carried through to a subsequent commit
56fd94919b8b ("kernel/resource: fix locking in request_free_mem_region")
in the series.  This resulted in a use-after-free due to freeing the
struct resource without properly releasing it.  Fix this by correcting the
return code check so that the struct is not freed if the request to add it
was successful.

Link: https://lkml.kernel.org/r/[e-mail]
Fixes: 56fd94919b8b ("kernel/resource: fix locking in request_free_mem_region")
Signed-off-by: Alistair Popple <[e-mail]>
Reported-by: kernel test robot <[e-mail]>
Reviewed-by: David Hildenbrand <[e-mail]>
Cc: Balbir Singh <[e-mail]>
Cc: Dan Williams <[e-mail]>
Cc: Daniel Vetter <[e-mail]>
Cc: Greg Kroah-Hartman <[e-mail]>
Cc: Jerome Glisse <[e-mail]>
Cc: John Hubbard <[e-mail]>
Cc: Muchun Song <[e-mail]>
Cc: Oliver Sang <[e-mail]>
Signed-off-by: Andrew Morton <[e-mail]>
---

 kernel/resource.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Patch

--- a/kernel/resource.c~kernel-resource-fix-return-code-check-in-__request_free_mem_region
+++ a/kernel/resource.c
@@ -1805,7 +1805,7 @@  static struct resource *__request_free_m
 				REGION_DISJOINT)
 			continue;
 
-		if (!__request_region_locked(res, &iomem_resource, addr, size,
+		if (__request_region_locked(res, &iomem_resource, addr, size,
 						name, 0))
 			break;