Message ID | 20210524233946.20352-21-vbabka@suse.cz (mailing list archive) |
---|---|
State | New, archived |
Headers | show
Return-Path: <SRS0=fGrr=KT=kvack.org=owner-linux-mm@kernel.org> X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6822DC47085 for <linux-mm@archiver.kernel.org>; Mon, 24 May 2021 23:41:31 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 130C06141F for <linux-mm@archiver.kernel.org>; Mon, 24 May 2021 23:41:31 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 130C06141F Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.cz Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 5FD976B0096; Mon, 24 May 2021 19:40:59 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 659E86B0099; Mon, 24 May 2021 19:40:58 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C573C6B008A; Mon, 24 May 2021 19:40:55 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0148.hostedemail.com [216.40.44.148]) by kanga.kvack.org (Postfix) with ESMTP id 53CF06B0081 for <linux-mm@kvack.org>; Mon, 24 May 2021 19:40:53 -0400 (EDT) Received: from smtpin28.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id E065175AF for <linux-mm@kvack.org>; Mon, 24 May 2021 23:40:52 +0000 (UTC) X-FDA: 78177747144.28.7EE8FA3 Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by imf28.hostedemail.com (Postfix) with ESMTP id 229E920007E6 for <linux-mm@kvack.org>; Mon, 24 May 2021 23:40:47 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1621899649; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Vn0q2MowqtMDKWpeLbHMppeC+VLuK7X9dSk7w+C8hww=; b=iRccDoB8mUyH/MVrd5v/64ILvNf/DpJlIU/v48EEFKkMgev39CghddEg4y9LsUrIKRu6XH Vzp+HqV2vRgi6kR9MyRvBnVXqwe3SF3zg1X7KD/CwwMKasbeyP0cOwNzlSNmKGOXMlQLc0 S3F+aOYgdh8oUb6jL+yfcIwKGcKs4vU= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1621899649; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Vn0q2MowqtMDKWpeLbHMppeC+VLuK7X9dSk7w+C8hww=; b=dV6m66/oQWOK1Ti2udRobMzvcSd+vTOLKwUtUfQqdMnsPYeYCo0YkMChbRCj06BF71IvKO PD8SG0esmzSymSDw== Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 32B78AF45; Mon, 24 May 2021 23:40:49 +0000 (UTC) From: Vlastimil Babka <vbabka@suse.cz> To: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Christoph Lameter <cl@linux.com>, David Rientjes <rientjes@google.com>, Pekka Enberg <penberg@kernel.org>, Joonsoo Kim <iamjoonsoo.kim@lge.com> Cc: Sebastian Andrzej Siewior <bigeasy@linutronix.de>, Thomas Gleixner <tglx@linutronix.de>, Mel Gorman <mgorman@techsingularity.net>, Jesper Dangaard Brouer <brouer@redhat.com>, Peter Zijlstra <peterz@infradead.org>, Jann Horn <jannh@google.com>, Vlastimil Babka <vbabka@suse.cz> Subject: [RFC 20/26] mm, slub: discard slabs in unfreeze_partials() without irqs disabled Date: Tue, 25 May 2021 01:39:40 +0200 Message-Id: <20210524233946.20352-21-vbabka@suse.cz> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210524233946.20352-1-vbabka@suse.cz> References: <20210524233946.20352-1-vbabka@suse.cz> MIME-Version: 1.0 Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=iRccDoB8; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b="dV6m66/o"; dmarc=none; spf=pass (imf28.hostedemail.com: domain of vbabka@suse.cz designates 195.135.220.15 as permitted sender) smtp.mailfrom=vbabka@suse.cz X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 229E920007E6 X-Stat-Signature: 4jgcfbezt5bmttgqpo7mwidihyraxxac X-HE-Tag: 1621899647-906249 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: <linux-mm.kvack.org> |
Series |
SLUB: use local_lock for kmem_cache_cpu protection and reduce disabling irqs
|
expand
|
diff --git a/mm/slub.c b/mm/slub.c index 446d2d5344c9..33c3faacf7b1 100644 --- a/mm/slub.c +++ b/mm/slub.c @@ -2360,6 +2360,8 @@ static void unfreeze_partials(struct kmem_cache *s, if (n) spin_unlock(&n->list_lock); + local_irq_restore(flags); + while (discard_page) { page = discard_page; discard_page = discard_page->next; @@ -2369,7 +2371,6 @@ static void unfreeze_partials(struct kmem_cache *s, stat(s, FREE_SLAB); } - local_irq_restore(flags); #endif /* CONFIG_SLUB_CPU_PARTIAL */ }
No need for disabled irqs when discarding slabs, so restore them before discarding. Signed-off-by: Vlastimil Babka <vbabka@suse.cz> --- mm/slub.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)