Message ID | 20210524233946.20352-25-vbabka@suse.cz (mailing list archive) |
---|---|
State | New, archived |
Headers | show
Return-Path: <SRS0=fGrr=KT=kvack.org=owner-linux-mm@kernel.org> X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BB980C2B9F8 for <linux-mm@archiver.kernel.org>; Mon, 24 May 2021 23:41:26 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 660A661420 for <linux-mm@archiver.kernel.org>; Mon, 24 May 2021 23:41:26 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 660A661420 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.cz Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id E45796B0087; Mon, 24 May 2021 19:40:58 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E90B36B0095; Mon, 24 May 2021 19:40:57 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 128706B0089; Mon, 24 May 2021 19:40:54 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0075.hostedemail.com [216.40.44.75]) by kanga.kvack.org (Postfix) with ESMTP id 2A5F56B0092 for <linux-mm@kvack.org>; Mon, 24 May 2021 19:40:53 -0400 (EDT) Received: from smtpin30.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id B3192181AEF2A for <linux-mm@kvack.org>; Mon, 24 May 2021 23:40:52 +0000 (UTC) X-FDA: 78177747144.30.2A49188 Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by imf22.hostedemail.com (Postfix) with ESMTP id E94D5C0007CB for <linux-mm@kvack.org>; Mon, 24 May 2021 23:40:46 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1621899649; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=op7fjoPtUEPr3ctFy+oe8fOC8FmEaHNINBmfV/1aXJA=; b=j5CrEwlsrJ97eI7Q/RnlCCVX0h2O6pGXZM2B5dR0ojnjGzy7U6d2dOldaQ8rJhxJsXpLqQ JXUGR2u3a1uTkaws8Q2smsz50395pxrSVcVaB/Lu2aq51gSuFkuhaU34tXe6xpwkpeYu1G 5p8hrzf31ehPMkgSpetskqpAgVf4Mu0= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1621899649; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=op7fjoPtUEPr3ctFy+oe8fOC8FmEaHNINBmfV/1aXJA=; b=9AvNRWnIj2pXJNZYmJPqNKbMhCG+4woX0Bxur60VVtdBkzhuL50yg+ZedmgWqslu8IHFko Skfp93IfQ25rSTBg== Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id C257CAF52; Mon, 24 May 2021 23:40:49 +0000 (UTC) From: Vlastimil Babka <vbabka@suse.cz> To: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Christoph Lameter <cl@linux.com>, David Rientjes <rientjes@google.com>, Pekka Enberg <penberg@kernel.org>, Joonsoo Kim <iamjoonsoo.kim@lge.com> Cc: Sebastian Andrzej Siewior <bigeasy@linutronix.de>, Thomas Gleixner <tglx@linutronix.de>, Mel Gorman <mgorman@techsingularity.net>, Jesper Dangaard Brouer <brouer@redhat.com>, Peter Zijlstra <peterz@infradead.org>, Jann Horn <jannh@google.com>, Vlastimil Babka <vbabka@suse.cz> Subject: [RFC 24/26] mm, slub: don't disable irqs in slub_cpu_dead() Date: Tue, 25 May 2021 01:39:44 +0200 Message-Id: <20210524233946.20352-25-vbabka@suse.cz> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210524233946.20352-1-vbabka@suse.cz> References: <20210524233946.20352-1-vbabka@suse.cz> MIME-Version: 1.0 Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=j5CrEwls; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=9AvNRWnI; dmarc=none; spf=pass (imf22.hostedemail.com: domain of vbabka@suse.cz designates 195.135.220.15 as permitted sender) smtp.mailfrom=vbabka@suse.cz X-Stat-Signature: 6rxs9h5fhqf1xq5qnyb5gbz71p577zsb X-Rspamd-Queue-Id: E94D5C0007CB X-Rspamd-Server: rspam02 X-HE-Tag: 1621899646-239546 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: <linux-mm.kvack.org> |
Series |
SLUB: use local_lock for kmem_cache_cpu protection and reduce disabling irqs
|
expand
|
diff --git a/mm/slub.c b/mm/slub.c index aee83758bbc4..bfa5e7c4da1b 100644 --- a/mm/slub.c +++ b/mm/slub.c @@ -2515,14 +2515,10 @@ static void flush_all(struct kmem_cache *s) static int slub_cpu_dead(unsigned int cpu) { struct kmem_cache *s; - unsigned long flags; mutex_lock(&slab_mutex); - list_for_each_entry(s, &slab_caches, list) { - local_irq_save(flags); + list_for_each_entry(s, &slab_caches, list) __flush_cpu_slab(s, cpu); - local_irq_restore(flags); - } mutex_unlock(&slab_mutex); return 0; }
slub_cpu_dead() cleans up for an offlined cpu from another cpu and calls only functions that are now irq safe, so we don't need to disable irqs anymore. Signed-off-by: Vlastimil Babka <vbabka@suse.cz> --- mm/slub.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-)