From patchwork Mon May 24 23:39:45 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Vlastimil Babka X-Patchwork-Id: 12277267 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0536FC2B9F7 for ; Mon, 24 May 2021 23:41:22 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id AC3AD6141F for ; Mon, 24 May 2021 23:41:21 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AC3AD6141F Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.cz Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 778A96B008C; Mon, 24 May 2021 19:40:58 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 802336B009B; Mon, 24 May 2021 19:40:57 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 829816B0087; Mon, 24 May 2021 19:40:54 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0201.hostedemail.com [216.40.44.201]) by kanga.kvack.org (Postfix) with ESMTP id 21E206B008C for ; Mon, 24 May 2021 19:40:53 -0400 (EDT) Received: from smtpin30.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id BA482180ACF86 for ; Mon, 24 May 2021 23:40:52 +0000 (UTC) X-FDA: 78177747144.30.179F5BA Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by imf29.hostedemail.com (Postfix) with ESMTP id EC617DE for ; Mon, 24 May 2021 23:40:44 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1621899650; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=J5QSAKwogWxiihbFPOl0HVlMof8QL2JF10nKieb0JlE=; b=mYMOGIMkYBZS2dqEnwu7v4VwPr8L5qdfFRH1Au4jNyg5hhYxkozBUQVtmLuBXMILltE7SS 0xov9E2ugEBQWIfl0/yh7ypvMIiLAjLlw1Y7DVl3VlqUh89jjVMlVlUZc+qABkuaKIDy6V kL4YdysgJAQ4umo8VioOpFwisLYnqBg= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1621899650; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=J5QSAKwogWxiihbFPOl0HVlMof8QL2JF10nKieb0JlE=; b=RvHe4x13YTAy3y2hzKOWFdxfidOnlP0m+M7I/MHXjxm8KmLql1wtJs0OuAhgT3/Ry3bVhx qXI8N+bOg9fJOxAA== Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id E51D6AF59; Mon, 24 May 2021 23:40:49 +0000 (UTC) From: Vlastimil Babka To: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Christoph Lameter , David Rientjes , Pekka Enberg , Joonsoo Kim Cc: Sebastian Andrzej Siewior , Thomas Gleixner , Mel Gorman , Jesper Dangaard Brouer , Peter Zijlstra , Jann Horn , Vlastimil Babka Subject: [RFC 25/26] mm, slub: use migrate_disable() in put_cpu_partial() Date: Tue, 25 May 2021 01:39:45 +0200 Message-Id: <20210524233946.20352-26-vbabka@suse.cz> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210524233946.20352-1-vbabka@suse.cz> References: <20210524233946.20352-1-vbabka@suse.cz> MIME-Version: 1.0 Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=mYMOGIMk; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=RvHe4x13; dmarc=none; spf=pass (imf29.hostedemail.com: domain of vbabka@suse.cz designates 195.135.220.15 as permitted sender) smtp.mailfrom=vbabka@suse.cz X-Stat-Signature: emkiu93wn1jsspw4igfq5xr5ks9zh87n X-Rspamd-Queue-Id: EC617DE X-Rspamd-Server: rspam02 X-HE-Tag: 1621899644-103695 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: In put_cpu_partial, we need a stable cpu, but being preempted is not an issue. So, disable migration instead of preemption. Signed-off-by: Vlastimil Babka --- mm/slub.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/mm/slub.c b/mm/slub.c index bfa5e7c4da1b..8818c210cb97 100644 --- a/mm/slub.c +++ b/mm/slub.c @@ -2417,7 +2417,7 @@ static void put_cpu_partial(struct kmem_cache *s, struct page *page, int drain) int pages; int pobjects; - preempt_disable(); + migrate_disable(); do { pages = 0; pobjects = 0; @@ -2451,7 +2451,7 @@ static void put_cpu_partial(struct kmem_cache *s, struct page *page, int drain) if (unlikely(!slub_cpu_partial(s))) unfreeze_partials(s); - preempt_enable(); + migrate_enable(); #endif /* CONFIG_SLUB_CPU_PARTIAL */ }