From patchwork Wed May 26 02:56:23 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Boyd X-Patchwork-Id: 12280543 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CCA6CC47088 for ; Wed, 26 May 2021 02:56:33 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 7D9DB60241 for ; Wed, 26 May 2021 02:56:33 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7D9DB60241 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id AE0F16B0070; Tue, 25 May 2021 22:56:31 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A1CFE6B0071; Tue, 25 May 2021 22:56:31 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 820C46B0072; Tue, 25 May 2021 22:56:31 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0051.hostedemail.com [216.40.44.51]) by kanga.kvack.org (Postfix) with ESMTP id 31F616B0070 for ; Tue, 25 May 2021 22:56:31 -0400 (EDT) Received: from smtpin03.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id D0B698249980 for ; Wed, 26 May 2021 02:56:30 +0000 (UTC) X-FDA: 78181868940.03.D5E24CD Received: from mail-pf1-f170.google.com (mail-pf1-f170.google.com [209.85.210.170]) by imf14.hostedemail.com (Postfix) with ESMTP id 6F58BC0007D5 for ; Wed, 26 May 2021 02:56:23 +0000 (UTC) Received: by mail-pf1-f170.google.com with SMTP id q67so8086022pfb.4 for ; Tue, 25 May 2021 19:56:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=xkanLPqi5ol7KoX7EbuFclwRAZagzb8ztuCHeHsTeLk=; b=fh84BKPzGBLUX+dgAR2OAm/T2zW/OHN6jKDfSMdz7m66fH/m5N60WUdFT3CEJ8+UKa cNb2rKr9C4cs0lt1dMx7B64xdMB4kB3bFvtvkt2PfESYu4v3of5BQkz3URRmBxNNAA6D gZ23XlpA3E6G4bGOYu5aOLm9HNVqpSBzH3RKo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=xkanLPqi5ol7KoX7EbuFclwRAZagzb8ztuCHeHsTeLk=; b=cbkC9U6q83ZuRlOd/cAcWPiieC3cHg2LXyrIS9XmLtHqvNKWuJ+DYw83bySFgRPut6 2kTOQ8Yb947YG4t1A9tBeSq8MythHLPSecIB4n5RULBGtR3QKnx0cxLYCE0Ck7srS39S L6kKeR8nBdBvqlqpK17E8b0WwBzraX3Tw3nC3LPEefxTxMnTWrJFwBHjjW/p8gSlcAw8 b1RaWTRgvP/gh/Mh8aznBtOofN3BTxcGnK4vsYCxJIHv4oLhluJOAnKGIsh4AZZmBrwM PqXCoAqdC99gzlbOAn9vO9+Zkb4rwdOQkteXuljnvbWK87z16aFE9ZIkC7B5kUfLLQ5G sWCw== X-Gm-Message-State: AOAM533U1tK61wNW3cx/QaAI7E5aAyRjm6SDfS2Uaa0iIkL5dNqsCePe rw0pyjR4HNotNp/nOV8bKxXnQQ== X-Google-Smtp-Source: ABdhPJyjbBdzs379VlR6V1iDNs2B37WXFNjJbcWhKeycGJ5QtfLfxiJKfWgM3JxTL8VX0iht64NcSw== X-Received: by 2002:a63:6c9:: with SMTP id 192mr22698285pgg.39.1621997789860; Tue, 25 May 2021 19:56:29 -0700 (PDT) Received: from smtp.gmail.com ([2620:15c:202:201:5a1b:e4e5:eb10:8870]) by smtp.gmail.com with ESMTPSA id 5sm2966295pjo.17.2021.05.25.19.56.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 25 May 2021 19:56:29 -0700 (PDT) From: Stephen Boyd To: Andrew Morton Cc: linux-kernel@vger.kernel.org, Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Vlastimil Babka , linux-mm@kvack.org, Petr Mladek , Joe Perches Subject: [PATCH v2 2/4] slub: Actually use 'message' in restore_bytes() Date: Tue, 25 May 2021 19:56:23 -0700 Message-Id: <20210526025625.601023-3-swboyd@chromium.org> X-Mailer: git-send-email 2.31.1.818.g46aad6cb9e-goog In-Reply-To: <20210526025625.601023-1-swboyd@chromium.org> References: <20210526025625.601023-1-swboyd@chromium.org> MIME-Version: 1.0 X-Rspamd-Queue-Id: 6F58BC0007D5 Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=fh84BKPz; dmarc=pass (policy=none) header.from=chromium.org; spf=pass (imf14.hostedemail.com: domain of swboyd@chromium.org designates 209.85.210.170 as permitted sender) smtp.mailfrom=swboyd@chromium.org X-Rspamd-Server: rspam03 X-Stat-Signature: dcnz51ejgnethg6haguqjfgjpt3kmwcw X-HE-Tag: 1621997783-227674 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: The message argument isn't used here. Let's pass the string to the printk message so that the developer can figure out what's happening, instead of guessing that a redzone is being restored, etc. Reviewed-by: Vlastimil Babka Acked-by: David Rientjes Signed-off-by: Stephen Boyd Reviewed-by: Muchun Song --- mm/slub.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mm/slub.c b/mm/slub.c index 2f53e8a9c28e..6168b3ce1b3e 100644 --- a/mm/slub.c +++ b/mm/slub.c @@ -777,7 +777,7 @@ static void init_object(struct kmem_cache *s, void *object, u8 val) static void restore_bytes(struct kmem_cache *s, char *message, u8 data, void *from, void *to) { - slab_fix(s, "Restoring 0x%p-0x%p=0x%x\n", from, to - 1, data); + slab_fix(s, "Restoring %s 0x%p-0x%p=0x%x\n", message, from, to - 1, data); memset(from, data, to - from); }