| Message ID | 20210603084621.24109-2-mgorman@techsingularity.net (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Allow high order pages to be stored on PCP | expand |
On 6/3/21 10:46 AM, Mel Gorman wrote: > In the next page, free_compount_page is going to use the common helper > free_the_page. This patch moves the definition to ease review. No > functional change. > > Signed-off-by: Mel Gorman <mgorman@techsingularity.net> Acked-by: Vlastimil Babka <vbabka@suse.cz> > --- > mm/page_alloc.c | 16 ++++++++-------- > 1 file changed, 8 insertions(+), 8 deletions(-) > > diff --git a/mm/page_alloc.c b/mm/page_alloc.c > index 4c468aa596aa..99ddac0ffece 100644 > --- a/mm/page_alloc.c > +++ b/mm/page_alloc.c > @@ -687,6 +687,14 @@ static void bad_page(struct page *page, const char *reason) > add_taint(TAINT_BAD_PAGE, LOCKDEP_NOW_UNRELIABLE); > } > > +static inline void free_the_page(struct page *page, unsigned int order) > +{ > + if (order == 0) /* Via pcp? */ > + free_unref_page(page); > + else > + __free_pages_ok(page, order, FPI_NONE); > +} > + > /* > * Higher-order pages are called "compound pages". They are structured thusly: > * > @@ -5345,14 +5353,6 @@ unsigned long get_zeroed_page(gfp_t gfp_mask) > } > EXPORT_SYMBOL(get_zeroed_page); > > -static inline void free_the_page(struct page *page, unsigned int order) > -{ > - if (order == 0) /* Via pcp? */ > - free_unref_page(page); > - else > - __free_pages_ok(page, order, FPI_NONE); > -} > - > /** > * __free_pages - Free pages allocated with alloc_pages(). > * @page: The page pointer returned from alloc_pages(). >
diff --git a/mm/page_alloc.c b/mm/page_alloc.c index 4c468aa596aa..99ddac0ffece 100644 --- a/mm/page_alloc.c +++ b/mm/page_alloc.c @@ -687,6 +687,14 @@ static void bad_page(struct page *page, const char *reason) add_taint(TAINT_BAD_PAGE, LOCKDEP_NOW_UNRELIABLE); } +static inline void free_the_page(struct page *page, unsigned int order) +{ + if (order == 0) /* Via pcp? */ + free_unref_page(page); + else + __free_pages_ok(page, order, FPI_NONE); +} + /* * Higher-order pages are called "compound pages". They are structured thusly: * @@ -5345,14 +5353,6 @@ unsigned long get_zeroed_page(gfp_t gfp_mask) } EXPORT_SYMBOL(get_zeroed_page); -static inline void free_the_page(struct page *page, unsigned int order) -{ - if (order == 0) /* Via pcp? */ - free_unref_page(page); - else - __free_pages_ok(page, order, FPI_NONE); -} - /** * __free_pages - Free pages allocated with alloc_pages(). * @page: The page pointer returned from alloc_pages().
In the next page, free_compount_page is going to use the common helper free_the_page. This patch moves the definition to ease review. No functional change. Signed-off-by: Mel Gorman <mgorman@techsingularity.net> --- mm/page_alloc.c | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-)