From patchwork Sat Jun 5 01:42:15 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nicholas Piggin X-Patchwork-Id: 12301125 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.5 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2A9D3C47082 for ; Sat, 5 Jun 2021 04:34:12 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id B8A706141B for ; Sat, 5 Jun 2021 04:34:11 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B8A706141B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 5A6E96B006C; Sat, 5 Jun 2021 00:34:11 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 57D7C6B006E; Sat, 5 Jun 2021 00:34:11 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 41E666B0070; Sat, 5 Jun 2021 00:34:11 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0123.hostedemail.com [216.40.44.123]) by kanga.kvack.org (Postfix) with ESMTP id 11C076B006C for ; Sat, 5 Jun 2021 00:34:11 -0400 (EDT) Received: from smtpin32.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id A16B4180ACEE8 for ; Sat, 5 Jun 2021 04:34:10 +0000 (UTC) X-FDA: 78218403060.32.AF51C2A Received: from mail-io1-f50.google.com (mail-io1-f50.google.com [209.85.166.50]) by imf04.hostedemail.com (Postfix) with ESMTP id EBF1599F for ; Sat, 5 Jun 2021 04:34:08 +0000 (UTC) Received: by mail-io1-f50.google.com with SMTP id p66so10469039iod.8 for ; Fri, 04 Jun 2021 21:34:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=o79xAv8VGlL9P0cnIMgEnd0kABY+0aVXPPf79qRUn38=; b=EfkqsrLHsB7OMvz7oioK9BBbvfX//VN0Qw/rqIoO6VTLg+nNlnZ/KwQq3Ak+aOlAJ3 4S1x1y+m8CXRSw/uKOh3GHNLGFovqdRQUIFX0Dcq6pC7OE+yBjpBJpGqqn+CRcKbBPAY 4mnCAWNE1DNFy3YE0B8updP/ljldtNDies0KZ25LEesppi4qXSwnW2uLmd/t/dWRN9Ia Jk1T9dWv2C5leuoyrJr5BQMj4Z9qUj/tleWND28vrxEqsj8DZ2aXJfQL9kYMwI7CfeIl Yzl9twL/atYxeXecU4ZgZwgwq00za2QJ/RHuxgZxyIRXUCMIvtLRYq7hcluVMYREzs8J MBPQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=o79xAv8VGlL9P0cnIMgEnd0kABY+0aVXPPf79qRUn38=; b=QoWs7l/iFSnKyeZrYvc2HU+rxhe8qNP4lj2aLqJDZe+UZ8OJLzzjYcnN6SlvFnocp8 Vj0YF2twlNO9uhrfcezaBndWqbXe9xuERA8CXvBy6qkJ6UlsshbPMLcRhpdeumGZvJSx 7W/HE8HNfT/1YsYmPk4B7H4FmBrGzk5NdRD2ipAiohXqBc2PtgBvX2SfGPoro2MOMvKx f96eAVaGrXx+b6OpmmtQBsxiQ7h2/Axa5qH/gCj7kQZC9sJCuqZndp+pypCOBmPRj1S5 NnR/PgPxgwUecEUk6ZigqjGrXstkorj/v0oXCNUynTmgODhNiHZ39iaE55O1yMw4DKbR KiGQ== X-Gm-Message-State: AOAM531j7MzzxuvroZqWIiElE+Bc1Of4IZPgeQiYDDoEExlrOOkGsP9q t5xPVAVDX49SdM+EBdU/+Z5XcrTrXMI= X-Google-Smtp-Source: ABdhPJxId09rwktS+wz23oEw5BLQX2VX0E1Io1PESo6MYBadnFs6NbNcFmDkmt3wim2iUcQ6z1nzfw== X-Received: by 2002:a63:1626:: with SMTP id w38mr7676348pgl.420.1622857358356; Fri, 04 Jun 2021 18:42:38 -0700 (PDT) Received: from bobo.ozlabs.ibm.com (60-242-147-73.tpgi.com.au. [60.242.147.73]) by smtp.gmail.com with ESMTPSA id q68sm5779056pjq.45.2021.06.04.18.42.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 04 Jun 2021 18:42:38 -0700 (PDT) From: Nicholas Piggin To: Andrew Morton Cc: Nicholas Piggin , Randy Dunlap , linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-mm@kvack.org, Anton Blanchard , Andy Lutomirski Subject: [PATCH v4 3/4] lazy tlb: shoot lazies, a non-refcounting lazy tlb option Date: Sat, 5 Jun 2021 11:42:15 +1000 Message-Id: <20210605014216.446867-4-npiggin@gmail.com> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20210605014216.446867-1-npiggin@gmail.com> References: <20210605014216.446867-1-npiggin@gmail.com> MIME-Version: 1.0 Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=gmail.com header.s=20161025 header.b=EfkqsrLH; spf=pass (imf04.hostedemail.com: domain of npiggin@gmail.com designates 209.85.166.50 as permitted sender) smtp.mailfrom=npiggin@gmail.com; dmarc=pass (policy=none) header.from=gmail.com X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: EBF1599F X-Stat-Signature: sfrhyy4kz7qm7inqooc1ix6y9mipn7wj X-HE-Tag: 1622867648-798749 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On big systems, the mm refcount can become highly contented when doing a lot of context switching with threaded applications (particularly switching between the idle thread and an application thread). Abandoning lazy tlb slows switching down quite a bit in the important user->idle->user cases, so instead implement a non-refcounted scheme that causes __mmdrop() to IPI all CPUs in the mm_cpumask and shoot down any remaining lazy ones. Shootdown IPIs are some concern, but they have not been observed to be a big problem with this scheme (the powerpc implementation generated 314 additional interrupts on a 144 CPU system during a kernel compile). There are a number of strategies that could be employed to reduce IPIs if they turn out to be a problem for some workload. Signed-off-by: Nicholas Piggin Signed-off-by: Nicholas Piggin --- arch/Kconfig | 13 +++++++++++++ kernel/fork.c | 51 +++++++++++++++++++++++++++++++++++++++++++++++++++ 2 files changed, 64 insertions(+) diff --git a/arch/Kconfig b/arch/Kconfig index 1cff045cdde6..f8136c893991 100644 --- a/arch/Kconfig +++ b/arch/Kconfig @@ -421,6 +421,19 @@ config ARCH_WANT_IRQS_OFF_ACTIVATE_MM # Use normal mm refcounting for MMU_LAZY_TLB kernel thread references. config MMU_LAZY_TLB_REFCOUNT def_bool y + depends on !MMU_LAZY_TLB_SHOOTDOWN + +# Instead of refcounting the lazy mm struct for kernel thread references +# (which can cause contention with multi-threaded apps on large multiprocessor +# systems), this option causes __mmdrop to IPI all CPUs in the mm_cpumask and +# switch to init_mm if they were using the to-be-freed mm as the lazy tlb. To +# implement this, architectures must use _lazy_tlb variants of mm refcounting +# when releasing kernel thread mm references, and mm_cpumask must include at +# least all possible CPUs in which the mm might be lazy, at the time of the +# final mmdrop. mmgrab/mmdrop in arch/ code must be switched to _lazy_tlb +# postfix as necessary. +config MMU_LAZY_TLB_SHOOTDOWN + bool config ARCH_HAVE_NMI_SAFE_CMPXCHG bool diff --git a/kernel/fork.c b/kernel/fork.c index dc06afd725cb..8085ff33c7f6 100644 --- a/kernel/fork.c +++ b/kernel/fork.c @@ -674,6 +674,53 @@ static void check_mm(struct mm_struct *mm) #define allocate_mm() (kmem_cache_alloc(mm_cachep, GFP_KERNEL)) #define free_mm(mm) (kmem_cache_free(mm_cachep, (mm))) +static void do_shoot_lazy_tlb(void *arg) +{ + struct mm_struct *mm = arg; + + if (current->active_mm == mm) { + WARN_ON_ONCE(current->mm); + current->active_mm = &init_mm; + switch_mm(mm, &init_mm, current); + } +} + +static void do_check_lazy_tlb(void *arg) +{ + struct mm_struct *mm = arg; + + WARN_ON_ONCE(current->active_mm == mm); +} + +static void shoot_lazy_tlbs(struct mm_struct *mm) +{ + if (IS_ENABLED(CONFIG_MMU_LAZY_TLB_SHOOTDOWN)) { + /* + * IPI overheads have not found to be expensive, but they could + * be reduced in a number of possible ways, for example (in + * roughly increasing order of complexity): + * - A batch of mms requiring IPIs could be gathered and freed + * at once. + * - CPUs could store their active mm somewhere that can be + * remotely checked without a lock, to filter out + * false-positives in the cpumask. + * - After mm_users or mm_count reaches zero, switching away + * from the mm could clear mm_cpumask to reduce some IPIs + * (some batching or delaying would help). + * - A delayed freeing and RCU-like quiescing sequence based on + * mm switching to avoid IPIs completely. + */ + on_each_cpu_mask(mm_cpumask(mm), do_shoot_lazy_tlb, (void *)mm, 1); + if (IS_ENABLED(CONFIG_DEBUG_VM)) + on_each_cpu(do_check_lazy_tlb, (void *)mm, 1); + } else { + /* + * In this case, lazy tlb mms are refounted and would not reach + * __mmdrop until all CPUs have switched away and mmdrop()ed. + */ + } +} + /* * Called when the last reference to the mm * is dropped: either by a lazy thread or by @@ -683,6 +730,10 @@ void __mmdrop(struct mm_struct *mm) { BUG_ON(mm == &init_mm); WARN_ON_ONCE(mm == current->mm); + + /* Ensure no CPUs are using this as their lazy tlb mm */ + shoot_lazy_tlbs(mm); + WARN_ON_ONCE(mm == current->active_mm); mm_free_pgd(mm); destroy_context(mm);