| Message ID | 20210608083418.137226-12-wangkefeng.wang@huawei.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | init_mm: cleanup ARCH's text/data/brk setup code | expand |
On Tue, Jun 8, 2021 at 1:56 PM Kefeng Wang <wangkefeng.wang@huawei.com> wrote: > > Use setup_initial_init_mm() helper to simplify code. > > Note klimit is (unsigned long) _end, with new helper, > will use _end directly. With this change klimit left with no user in this file and can be moved to some appropriate header. But in a separate series. > > Cc: Michael Ellerman <mpe@ellerman.id.au> > Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org> > Cc: linuxppc-dev@lists.ozlabs.org > Signed-off-by: Kefeng Wang <wangkefeng.wang@huawei.com> > --- > arch/powerpc/kernel/setup-common.c | 5 +---- > 1 file changed, 1 insertion(+), 4 deletions(-) > > diff --git a/arch/powerpc/kernel/setup-common.c b/arch/powerpc/kernel/setup-common.c > index 74a98fff2c2f..96697c6e1e16 100644 > --- a/arch/powerpc/kernel/setup-common.c > +++ b/arch/powerpc/kernel/setup-common.c > @@ -927,10 +927,7 @@ void __init setup_arch(char **cmdline_p) > > klp_init_thread_info(&init_task); > > - init_mm.start_code = (unsigned long)_stext; > - init_mm.end_code = (unsigned long) _etext; > - init_mm.end_data = (unsigned long) _edata; > - init_mm.brk = klimit; > + setup_initial_init_mm(_stext, _etext, _edata, _end); > > mm_iommu_init(&init_mm); > irqstack_early_init(); > -- > 2.26.2 > >
Le 08/06/2021 à 16:36, Souptick Joarder a écrit : > On Tue, Jun 8, 2021 at 1:56 PM Kefeng Wang <wangkefeng.wang@huawei.com> wrote: >> >> Use setup_initial_init_mm() helper to simplify code. >> >> Note klimit is (unsigned long) _end, with new helper, >> will use _end directly. > > With this change klimit left with no user in this file and can be > moved to some appropriate header. > But in a separate series. I have a patch to remove klimit, see https://patchwork.ozlabs.org/project/linuxppc-dev/patch/9fa9ba6807c17f93f35a582c199c646c4a8bfd9c.1622800638.git.christophe.leroy@csgroup.eu/ Christophe > >> >> Cc: Michael Ellerman <mpe@ellerman.id.au> >> Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org> >> Cc: linuxppc-dev@lists.ozlabs.org >> Signed-off-by: Kefeng Wang <wangkefeng.wang@huawei.com> >> --- >> arch/powerpc/kernel/setup-common.c | 5 +---- >> 1 file changed, 1 insertion(+), 4 deletions(-) >> >> diff --git a/arch/powerpc/kernel/setup-common.c b/arch/powerpc/kernel/setup-common.c >> index 74a98fff2c2f..96697c6e1e16 100644 >> --- a/arch/powerpc/kernel/setup-common.c >> +++ b/arch/powerpc/kernel/setup-common.c >> @@ -927,10 +927,7 @@ void __init setup_arch(char **cmdline_p) >> >> klp_init_thread_info(&init_task); >> >> - init_mm.start_code = (unsigned long)_stext; >> - init_mm.end_code = (unsigned long) _etext; >> - init_mm.end_data = (unsigned long) _edata; >> - init_mm.brk = klimit; >> + setup_initial_init_mm(_stext, _etext, _edata, _end); >> >> mm_iommu_init(&init_mm); >> irqstack_early_init(); >> -- >> 2.26.2 >> >>
On Tue, Jun 8, 2021 at 8:24 PM Christophe Leroy <christophe.leroy@csgroup.eu> wrote: > > > > Le 08/06/2021 à 16:36, Souptick Joarder a écrit : > > On Tue, Jun 8, 2021 at 1:56 PM Kefeng Wang <wangkefeng.wang@huawei.com> wrote: > >> > >> Use setup_initial_init_mm() helper to simplify code. > >> > >> Note klimit is (unsigned long) _end, with new helper, > >> will use _end directly. > > > > With this change klimit left with no user in this file and can be > > moved to some appropriate header. > > But in a separate series. > > I have a patch to remove klimit, see > https://patchwork.ozlabs.org/project/linuxppc-dev/patch/9fa9ba6807c17f93f35a582c199c646c4a8bfd9c.1622800638.git.christophe.leroy@csgroup.eu/ Got it. Thanks :) > > Christophe > > > > > >> > >> Cc: Michael Ellerman <mpe@ellerman.id.au> > >> Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org> > >> Cc: linuxppc-dev@lists.ozlabs.org > >> Signed-off-by: Kefeng Wang <wangkefeng.wang@huawei.com> > >> --- > >> arch/powerpc/kernel/setup-common.c | 5 +---- > >> 1 file changed, 1 insertion(+), 4 deletions(-) > >> > >> diff --git a/arch/powerpc/kernel/setup-common.c b/arch/powerpc/kernel/setup-common.c > >> index 74a98fff2c2f..96697c6e1e16 100644 > >> --- a/arch/powerpc/kernel/setup-common.c > >> +++ b/arch/powerpc/kernel/setup-common.c > >> @@ -927,10 +927,7 @@ void __init setup_arch(char **cmdline_p) > >> > >> klp_init_thread_info(&init_task); > >> > >> - init_mm.start_code = (unsigned long)_stext; > >> - init_mm.end_code = (unsigned long) _etext; > >> - init_mm.end_data = (unsigned long) _edata; > >> - init_mm.brk = klimit; > >> + setup_initial_init_mm(_stext, _etext, _edata, _end); > >> > >> mm_iommu_init(&init_mm); > >> irqstack_early_init(); > >> -- > >> 2.26.2 > >> > >>
diff --git a/arch/powerpc/kernel/setup-common.c b/arch/powerpc/kernel/setup-common.c index 74a98fff2c2f..96697c6e1e16 100644 --- a/arch/powerpc/kernel/setup-common.c +++ b/arch/powerpc/kernel/setup-common.c @@ -927,10 +927,7 @@ void __init setup_arch(char **cmdline_p) klp_init_thread_info(&init_task); - init_mm.start_code = (unsigned long)_stext; - init_mm.end_code = (unsigned long) _etext; - init_mm.end_data = (unsigned long) _edata; - init_mm.brk = klimit; + setup_initial_init_mm(_stext, _etext, _edata, _end); mm_iommu_init(&init_mm); irqstack_early_init();
Use setup_initial_init_mm() helper to simplify code. Note klimit is (unsigned long) _end, with new helper, will use _end directly. Cc: Michael Ellerman <mpe@ellerman.id.au> Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org> Cc: linuxppc-dev@lists.ozlabs.org Signed-off-by: Kefeng Wang <wangkefeng.wang@huawei.com> --- arch/powerpc/kernel/setup-common.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-)