From patchwork Tue Jun 8 11:52:48 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: SeongJae Park X-Patchwork-Id: 12306591 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 96AA8C47082 for ; Tue, 8 Jun 2021 11:53:31 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 4BE126128D for ; Tue, 8 Jun 2021 11:53:31 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4BE126128D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id E31076B0078; Tue, 8 Jun 2021 07:53:30 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E06556B007B; Tue, 8 Jun 2021 07:53:30 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C0D396B007D; Tue, 8 Jun 2021 07:53:30 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0163.hostedemail.com [216.40.44.163]) by kanga.kvack.org (Postfix) with ESMTP id 864C36B0078 for ; Tue, 8 Jun 2021 07:53:30 -0400 (EDT) Received: from smtpin25.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 2D10E180AD807 for ; Tue, 8 Jun 2021 11:53:30 +0000 (UTC) X-FDA: 78230396580.25.C7FE990 Received: from mail-qv1-f47.google.com (mail-qv1-f47.google.com [209.85.219.47]) by imf30.hostedemail.com (Postfix) with ESMTP id 359BAE0004C0 for ; Tue, 8 Jun 2021 11:53:28 +0000 (UTC) Received: by mail-qv1-f47.google.com with SMTP id w4so3137506qvr.11 for ; Tue, 08 Jun 2021 04:53:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=exn5/9MVsYyepOBbFagm+4+x6JfQKNCd23hgVVQiw28=; b=rW6VO0cYPPeohtegDgnMo56MynBg4r79O6s7fPi4Hdgb4YViiGit5ckAJxLvBxTHKG I8FeR8VtXvr2EsTbwvkB1bkBqhxzyiVvac7rSpDQhZj/P7OOAUfHdMCQkqlAkdbbLgr3 kQFCw79tAR2RAt/tCkDe6g4r0ptta+kQEJ6fYily/2qY5EUGH27vOKm7tarHYyj7spii Yeoje3bC0c7/17CK7Hy2F44baCEKYEdfvrHfIh248bmIgT/c6nc9e4OBf60PVslSTSj2 x08zgiiqh6DG0CuZvXn+j0UXu6G+Q3T8n4pat88EsZSJey77bIC0MZiVQDfFutphW8K2 ySaA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=exn5/9MVsYyepOBbFagm+4+x6JfQKNCd23hgVVQiw28=; b=T0A2z6Q8z2xrrZyH4d1QJX9pmux/VQhJS5xvKVCET8FHdDefCHtcJc+lY6KjfRHmLV ZF6ccgZ2Fgy+676dEo/Z15AjLZOeJWZL253TpkKk9QN5+O6Nm4Kuut3nkB1I56r5/4Yc MbzsOudsRKTKopTcwZv5HAYJDMvu+gcbcPAHTTpVOigmiQXNJbWa2GCjTn0ddbaHbg27 ZDLF7qo7m1fkVfALNGGeZR89CC5My2CdE/RlCOjZeJroYXbP9kkNQlqQG2gXtiAbnoOL n9aF2gNKlwJEarpm72Dcq7pkt3iziOAyfKmO3R1zkJF5W4IdqWWBNY06RQLxRNDTrpin 8oZg== X-Gm-Message-State: AOAM532wFVNUcrwodu1XbUBCTMbzQe/ccytEmzm3uYhHrPPkC+8GVV9p HKDwpoXyqSntgYBxKHjBqjA= X-Google-Smtp-Source: ABdhPJywm2xA13cQrhGtHNB/ZXuL7WSc2fz2N2COdktA1EihuHv9PfAyl9AWb4EmC9kEbP0RMKU+Zg== X-Received: by 2002:a0c:a99c:: with SMTP id a28mr22979057qvb.33.1623153209315; Tue, 08 Jun 2021 04:53:29 -0700 (PDT) Received: from localhost.localdomain (ec2-35-169-212-159.compute-1.amazonaws.com. [35.169.212.159]) by smtp.gmail.com with ESMTPSA id h4sm2133927qth.66.2021.06.08.04.53.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Jun 2021 04:53:28 -0700 (PDT) From: SeongJae Park To: akpm@linux-foundation.org Cc: SeongJae Park , Jonathan.Cameron@Huawei.com, acme@kernel.org, alexander.shishkin@linux.intel.com, amit@kernel.org, benh@kernel.crashing.org, brendanhiggins@google.com, corbet@lwn.net, david@redhat.com, dwmw@amazon.com, elver@google.com, fan.du@intel.com, foersleo@amazon.de, greg@kroah.com, gthelen@google.com, guoju.fgj@alibaba-inc.com, jgowans@amazon.com, mgorman@suse.de, minchan@kernel.org, mingo@redhat.com, namhyung@kernel.org, peterz@infradead.org, riel@surriel.com, rientjes@google.com, rostedt@goodmis.org, rppt@kernel.org, shakeelb@google.com, shuah@kernel.org, sj38.park@gmail.com, snu@zelle79.org, vbabka@suse.cz, vdavydov.dev@gmail.com, zgf574564920@gmail.com, linux-damon@amazon.com, linux-mm@kvack.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [RFC v2 08/14] mm/damon/dbgfs: Support prioritization weights Date: Tue, 8 Jun 2021 11:52:48 +0000 Message-Id: <20210608115254.11930-9-sj38.park@gmail.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20210608115254.11930-1-sj38.park@gmail.com> References: <20210608115254.11930-1-sj38.park@gmail.com> Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=gmail.com header.s=20161025 header.b=rW6VO0cY; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf30.hostedemail.com: domain of sj38park@gmail.com designates 209.85.219.47 as permitted sender) smtp.mailfrom=sj38park@gmail.com X-Rspamd-Server: rspam02 X-Stat-Signature: g7tfkwta7fb18acbfrx4sjgf5pt4r47o X-Rspamd-Queue-Id: 359BAE0004C0 X-HE-Tag: 1623153208-594301 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: From: SeongJae Park This commit allows DAMON debugfs interface users set the prioritization weights by putting three more numbers to the 'schemes' file. Signed-off-by: SeongJae Park --- mm/damon/dbgfs.c | 16 +++++++++++----- 1 file changed, 11 insertions(+), 5 deletions(-) diff --git a/mm/damon/dbgfs.c b/mm/damon/dbgfs.c index ea6d4fdb57fa..b90287b1e576 100644 --- a/mm/damon/dbgfs.c +++ b/mm/damon/dbgfs.c @@ -227,11 +227,14 @@ static ssize_t sprint_schemes(struct damon_ctx *c, char *buf, ssize_t len) damon_for_each_scheme(s, c) { rc = scnprintf(&buf[written], len - written, - "%lu %lu %u %u %u %u %d %lu %lu %lu %lu\n", + "%lu %lu %u %u %u %u %d %lu %lu %u %u %u %lu %lu\n", s->min_sz_region, s->max_sz_region, s->min_nr_accesses, s->max_nr_accesses, s->min_age_region, s->max_age_region, s->action, s->limit.sz, s->limit.ms, + s->limit.weight_sz, + s->limit.weight_nr_accesses, + s->limit.weight_age, s->stat_count, s->stat_sz); if (!rc) return -ENOMEM; @@ -313,11 +316,14 @@ static struct damos **str_to_schemes(const char *str, ssize_t len, while (pos < len && *nr_schemes < max_nr_schemes) { struct damos_speed_limit limit = {}; - ret = sscanf(&str[pos], "%lu %lu %u %u %u %u %u %lu %lu%n", + ret = sscanf(&str[pos], + "%lu %lu %u %u %u %u %u %lu %lu %u %u %u%n", &min_sz, &max_sz, &min_nr_a, &max_nr_a, &min_age, &max_age, &action, &limit.sz, - &limit.ms, &parsed); - if (ret != 9) + &limit.ms, &limit.weight_sz, + &limit.weight_nr_accesses, &limit.weight_age, + &parsed); + if (ret != 12) break; if (!damos_action_valid(action)) { pr_err("wrong action %d\n", action); @@ -1141,7 +1147,7 @@ static ssize_t dbgfs_monitor_on_write(struct file *file, static ssize_t dbgfs_version_read(struct file *file, char __user *buf, size_t count, loff_t *ppos) { - return simple_read_from_buffer(buf, count, ppos, "1\n", 2); + return simple_read_from_buffer(buf, count, ppos, "2\n", 2); } static const struct file_operations mk_contexts_fops = {