From patchwork Wed Jun 9 11:38:30 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Vlastimil Babka X-Patchwork-Id: 12309827 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 64CEDC48BD1 for ; Wed, 9 Jun 2021 11:39:35 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 138BA613C7 for ; Wed, 9 Jun 2021 11:39:35 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 138BA613C7 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.cz Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 94D9D6B0071; Wed, 9 Jun 2021 07:39:34 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 884106B0036; Wed, 9 Jun 2021 07:39:34 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6B00D6B0075; Wed, 9 Jun 2021 07:39:34 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0153.hostedemail.com [216.40.44.153]) by kanga.kvack.org (Postfix) with ESMTP id 382CB6B0036 for ; Wed, 9 Jun 2021 07:39:34 -0400 (EDT) Received: from smtpin14.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id CB47D180AD81A for ; Wed, 9 Jun 2021 11:39:33 +0000 (UTC) X-FDA: 78233990226.14.EDC155A Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by imf01.hostedemail.com (Postfix) with ESMTP id 1131B5001703 for ; Wed, 9 Jun 2021 11:39:28 +0000 (UTC) Received: from imap.suse.de (imap-alt.suse-dmz.suse.de [192.168.254.47]) (using TLSv1.2 with cipher ECDHE-ECDSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id B4A19219BC; Wed, 9 Jun 2021 11:39:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1623238771; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=vEDtjsnB/VDzYc0ii5k8c4+YLz6GPrWXLWLa4QOy8Fg=; b=IN8TwQl/nBF3IjB1x1wI2UnNVr4f2PMGC+TK64rkhGBc2qSF8AFsivay09xFcheo9OVNnb EyLzyuilsT1tTjlp2yyxsvWQb58GMdNR+OwaJ0TRA1eK8O/e7IFrccI/kDY37vtaVHZwGL s8ecWHWDT7kuc2g2E1LONThysPQHrZc= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1623238771; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=vEDtjsnB/VDzYc0ii5k8c4+YLz6GPrWXLWLa4QOy8Fg=; b=d08Kapwu2aJQczRX1Wiq9dop5yCfAX59yWf5r9X5g8KMXpk96Xqof3b8tqDspWR+X5J7f/ 8lm2LZHonHT3E8Cw== Received: from imap3-int (imap-alt.suse-dmz.suse.de [192.168.254.47]) by imap.suse.de (Postfix) with ESMTP id 7022111A98; Wed, 9 Jun 2021 11:39:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1623238771; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=vEDtjsnB/VDzYc0ii5k8c4+YLz6GPrWXLWLa4QOy8Fg=; b=IN8TwQl/nBF3IjB1x1wI2UnNVr4f2PMGC+TK64rkhGBc2qSF8AFsivay09xFcheo9OVNnb EyLzyuilsT1tTjlp2yyxsvWQb58GMdNR+OwaJ0TRA1eK8O/e7IFrccI/kDY37vtaVHZwGL s8ecWHWDT7kuc2g2E1LONThysPQHrZc= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1623238771; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=vEDtjsnB/VDzYc0ii5k8c4+YLz6GPrWXLWLa4QOy8Fg=; b=d08Kapwu2aJQczRX1Wiq9dop5yCfAX59yWf5r9X5g8KMXpk96Xqof3b8tqDspWR+X5J7f/ 8lm2LZHonHT3E8Cw== Received: from director2.suse.de ([192.168.254.72]) by imap3-int with ESMTPSA id WLXrGnOowGD6XgAALh3uQQ (envelope-from ); Wed, 09 Jun 2021 11:39:31 +0000 From: Vlastimil Babka To: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Christoph Lameter , David Rientjes , Pekka Enberg , Joonsoo Kim Cc: Sebastian Andrzej Siewior , Thomas Gleixner , Mel Gorman , Jesper Dangaard Brouer , Peter Zijlstra , Jann Horn , Vlastimil Babka Subject: [RFC v2 01/34] mm, slub: don't call flush_all() from list_locations() Date: Wed, 9 Jun 2021 13:38:30 +0200 Message-Id: <20210609113903.1421-2-vbabka@suse.cz> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210609113903.1421-1-vbabka@suse.cz> References: <20210609113903.1421-1-vbabka@suse.cz> MIME-Version: 1.0 Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b="IN8TwQl/"; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=d08Kapwu; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b="IN8TwQl/"; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=d08Kapwu; spf=pass (imf01.hostedemail.com: domain of vbabka@suse.cz designates 195.135.220.28 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none X-Stat-Signature: rzjge6hmtpt1hqreyrek7ypk8i9giihm X-Rspamd-Queue-Id: 1131B5001703 X-Rspamd-Server: rspam06 X-HE-Tag: 1623238768-474323 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: list_locations() can only be called on caches with SLAB_STORE_USER flag and as with all slub debugging flags, such caches avoid cpu or percpu partial slabs altogether, so there's nothing to flush. Signed-off-by: Vlastimil Babka --- mm/slub.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/mm/slub.c b/mm/slub.c index 3f96e099817a..f928607230b2 100644 --- a/mm/slub.c +++ b/mm/slub.c @@ -4839,8 +4839,6 @@ static int list_locations(struct kmem_cache *s, char *buf, GFP_KERNEL)) { return sysfs_emit(buf, "Out of memory\n"); } - /* Push back cpu slabs */ - flush_all(s); for_each_kmem_cache_node(s, node, n) { unsigned long flags;