From patchwork Wed Jun 9 11:38:53 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Vlastimil Babka X-Patchwork-Id: 12309873 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BDE56C48BD1 for ; Wed, 9 Jun 2021 11:40:16 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 7556C60FD8 for ; Wed, 9 Jun 2021 11:40:16 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7556C60FD8 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.cz Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 9A93E6B008C; Wed, 9 Jun 2021 07:39:38 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5C9586B0096; Wed, 9 Jun 2021 07:39:38 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3A86B6B0099; Wed, 9 Jun 2021 07:39:38 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0096.hostedemail.com [216.40.44.96]) by kanga.kvack.org (Postfix) with ESMTP id 06E316B0096 for ; Wed, 9 Jun 2021 07:39:37 -0400 (EDT) Received: from smtpin17.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 9F5A0181AEF2A for ; Wed, 9 Jun 2021 11:39:37 +0000 (UTC) X-FDA: 78233990394.17.1AB8B66 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by imf23.hostedemail.com (Postfix) with ESMTP id C9960A00014E for ; Wed, 9 Jun 2021 11:39:33 +0000 (UTC) Received: from imap.suse.de (imap-alt.suse-dmz.suse.de [192.168.254.47]) (using TLSv1.2 with cipher ECDHE-ECDSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 4A74A1FD6D; Wed, 9 Jun 2021 11:39:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1623238776; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=2GjVus2UBVIbubovFl8dtg2IvpbcICqCbHPjVLJTVoM=; b=o04cHXUdiGCGIfGonPs5+wcwkDX3KOGSlylgZ92FJt2EYgD7mTURBu8qyVVHAsNEAOWE4V q6drLCxA1yHq6/mHC8Wc7O3Mq5HVmLcYrSj81I7/VxeSDHhFvL8Mw6wOOmtTTDtbZOIL3t wRZmDqZHGINPKmx251+9SDrtFPMn+AI= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1623238776; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=2GjVus2UBVIbubovFl8dtg2IvpbcICqCbHPjVLJTVoM=; b=dfQb9bfoXcUTIavFmii6oJq++Hz+Aiv806ScHsu2USbjV7fDeKJt559qCUdaPGWsXHtY8e gz/V/lU1wR5fqpBg== Received: from imap3-int (imap-alt.suse-dmz.suse.de [192.168.254.47]) by imap.suse.de (Postfix) with ESMTP id 1BE6D118DD; Wed, 9 Jun 2021 11:39:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1623238776; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=2GjVus2UBVIbubovFl8dtg2IvpbcICqCbHPjVLJTVoM=; b=o04cHXUdiGCGIfGonPs5+wcwkDX3KOGSlylgZ92FJt2EYgD7mTURBu8qyVVHAsNEAOWE4V q6drLCxA1yHq6/mHC8Wc7O3Mq5HVmLcYrSj81I7/VxeSDHhFvL8Mw6wOOmtTTDtbZOIL3t wRZmDqZHGINPKmx251+9SDrtFPMn+AI= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1623238776; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=2GjVus2UBVIbubovFl8dtg2IvpbcICqCbHPjVLJTVoM=; b=dfQb9bfoXcUTIavFmii6oJq++Hz+Aiv806ScHsu2USbjV7fDeKJt559qCUdaPGWsXHtY8e gz/V/lU1wR5fqpBg== Received: from director2.suse.de ([192.168.254.72]) by imap3-int with ESMTPSA id KDVWBniowGD6XgAALh3uQQ (envelope-from ); Wed, 09 Jun 2021 11:39:36 +0000 From: Vlastimil Babka To: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Christoph Lameter , David Rientjes , Pekka Enberg , Joonsoo Kim Cc: Sebastian Andrzej Siewior , Thomas Gleixner , Mel Gorman , Jesper Dangaard Brouer , Peter Zijlstra , Jann Horn , Vlastimil Babka Subject: [RFC v2 24/34] mm, slub: detach whole partial list at once in unfreeze_partials() Date: Wed, 9 Jun 2021 13:38:53 +0200 Message-Id: <20210609113903.1421-25-vbabka@suse.cz> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210609113903.1421-1-vbabka@suse.cz> References: <20210609113903.1421-1-vbabka@suse.cz> MIME-Version: 1.0 Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=o04cHXUd; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=dfQb9bfo; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=o04cHXUd; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=dfQb9bfo; spf=pass (imf23.hostedemail.com: domain of vbabka@suse.cz designates 195.135.220.29 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none X-Stat-Signature: 3ncakkoqid3k1neqd6ct6qp4mfuzcuuq X-Rspamd-Queue-Id: C9960A00014E X-Rspamd-Server: rspam06 X-HE-Tag: 1623238773-878304 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Instead of iterating through the live percpu partial list, detach it from the kmem_cache_cpu at once. This is simpler and will allow further optimization. Signed-off-by: Vlastimil Babka --- mm/slub.c | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/mm/slub.c b/mm/slub.c index dcbc5baea702..3e0ec7211d55 100644 --- a/mm/slub.c +++ b/mm/slub.c @@ -2298,16 +2298,20 @@ static void unfreeze_partials(struct kmem_cache *s, { #ifdef CONFIG_SLUB_CPU_PARTIAL struct kmem_cache_node *n = NULL, *n2 = NULL; - struct page *page, *discard_page = NULL; + struct page *page, *partial_page, *discard_page = NULL; unsigned long flags; local_irq_save(flags); - while ((page = slub_percpu_partial(c))) { + partial_page = slub_percpu_partial(c); + c->partial = NULL; + + while (partial_page) { struct page new; struct page old; - slub_set_percpu_partial(c, page); + page = partial_page; + partial_page = page->next; n2 = get_node(s, page_to_nid(page)); if (n != n2) {