From patchwork Thu Jul 1 01:52:14 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrew Morton X-Patchwork-Id: 12353251 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_RED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 25417C11F66 for ; Thu, 1 Jul 2021 01:52:17 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id CD44C6146D for ; Thu, 1 Jul 2021 01:52:16 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CD44C6146D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 491D28D0233; Wed, 30 Jun 2021 21:52:16 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 467CA8D0202; Wed, 30 Jun 2021 21:52:16 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3575C8D0233; Wed, 30 Jun 2021 21:52:16 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0201.hostedemail.com [216.40.44.201]) by kanga.kvack.org (Postfix) with ESMTP id 0C7288D0202 for ; Wed, 30 Jun 2021 21:52:16 -0400 (EDT) Received: from smtpin17.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id D30B682E8741 for ; Thu, 1 Jul 2021 01:52:15 +0000 (UTC) X-FDA: 78312343830.17.E494F9A Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf07.hostedemail.com (Postfix) with ESMTP id 85BB710004CC for ; Thu, 1 Jul 2021 01:52:15 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id 80F0A61469; Thu, 1 Jul 2021 01:52:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1625104334; bh=TZ02/5BRV3MVGz6H7yhrD7JgNllspAGhg7ulbsDIIws=; h=Date:From:To:Subject:In-Reply-To:From; b=PchLKqP2i/PEF2rI96lR7wqUsu8+5uR7IJpmpfbGKZkZB1j51N8WANRroi+Yq4v3p 9B8pCP7QxtZ3ay+XpPEkLki+n8+mdgkn3nf3z0RVNukGpoJBgU5J0oEG5/s7BQhDYU 85ybDdPgJwQwRKqoR9VzTmZVxN2oBW7f4CwgQJSc= Date: Wed, 30 Jun 2021 18:52:14 -0700 From: Andrew Morton To: akpm@linux-foundation.org, chenli@uniontech.com, david@redhat.com, geert@linux-m68k.org, gerg@linux-m68k.org, linux-mm@kvack.org, mm-commits@vger.kernel.org, torvalds@linux-foundation.org, willy@infradead.org Subject: [patch 095/192] nommu: remove __GFP_HIGHMEM in vmalloc/vzalloc Message-ID: <20210701015214.X6biaOQaV%akpm@linux-foundation.org> In-Reply-To: <20210630184624.9ca1937310b0dd5ce66b30e7@linux-foundation.org> User-Agent: s-nail v14.8.16 Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=PchLKqP2; dmarc=none; spf=pass (imf07.hostedemail.com: domain of akpm@linux-foundation.org designates 198.145.29.99 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org X-Stat-Signature: i8ty5c7665yn89c8we5ssu1ph9idmy4y X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 85BB710004CC X-HE-Tag: 1625104335-342999 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: From: Chen Li Subject: nommu: remove __GFP_HIGHMEM in vmalloc/vzalloc mm/nommu.c: void *__vmalloc(unsigned long size, gfp_t gfp_mask) { /* * You can't specify __GFP_HIGHMEM with kmalloc() since kmalloc() * returns only a logical address. */ return kmalloc(size, (gfp_mask | __GFP_COMP) & ~__GFP_HIGHMEM); } nommu's __vmalloc just uses kmalloc internally and elimitates __GFP_HIGHMEM, so it makes no sense to add __GFP_HIGHMEM for nommu's vmalloc/vzalloc. [akpm@linux-foundation.org: coding style fixes] Link: https://lkml.kernel.org/r/875z00rnp8.wl-chenli@uniontech.com Signed-off-by: Chen Li Reviewed-by: Matthew Wilcox (Oracle) Reviewed-by: David Hildenbrand Cc: Greg Ungerer Cc: Geert Uytterhoeven Signed-off-by: Andrew Morton --- mm/nommu.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) --- a/mm/nommu.c~nommu-remove-__gfp_highmem-in-vmalloc-vzalloc +++ a/mm/nommu.c @@ -223,7 +223,7 @@ long vread(char *buf, char *addr, unsign */ void *vmalloc(unsigned long size) { - return __vmalloc(size, GFP_KERNEL | __GFP_HIGHMEM); + return __vmalloc(size, GFP_KERNEL); } EXPORT_SYMBOL(vmalloc); @@ -241,7 +241,7 @@ EXPORT_SYMBOL(vmalloc); */ void *vzalloc(unsigned long size) { - return __vmalloc(size, GFP_KERNEL | __GFP_HIGHMEM | __GFP_ZERO); + return __vmalloc(size, GFP_KERNEL | __GFP_ZERO); } EXPORT_SYMBOL(vzalloc);